From: Rob Landley <rob@landley.net>
To: Igor Mammedov <imammedo@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org, luto@mit.edu,
suresh.b.siddha@intel.com, avi@redhat.com,
a.p.zijlstra@chello.nl, johnstul@us.ibm.com,
arjan@linux.intel.com
Subject: Re: [RFC v2] [x86]: abort secondary cpu bringup gracefully
Date: Fri, 25 May 2012 13:11:05 -0500 [thread overview]
Message-ID: <4FBFCB39.6000101@landley.net> (raw)
In-Reply-To: <4FBE56C6.1020901@redhat.com>
On 05/24/2012 10:41 AM, Igor Mammedov wrote:
> ping for reviewers.
>
> Please review patch.
I can't hugely comment on the guts of what the patch is doing, but:
>> --- a/arch/x86/kernel/smpboot.c
>> +++ b/arch/x86/kernel/smpboot.c
>> @@ -136,6 +136,10 @@ EXPORT_PER_CPU_SYMBOL(cpu_info);
>>
>> atomic_t init_deasserted;
>>
>> +#ifdef CONFIG_HOTPLUG_CPU
>> +static void remove_siblinginfo(int cpu);
>> +#endif
>> +
#ifdefs should almost never be in C code, they should be in header
files. You can stub out functions with empty inline versions. For a
random example, see kernel/smpboot.h
Rob
--
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation. Pick one.
next prev parent reply other threads:[~2012-05-26 1:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 10:24 [PATCH 0/5] [x86]: Improve secondary CPU bring-up process robustness Igor Mammedov
2012-05-09 9:19 ` Peter Zijlstra
2012-05-09 12:29 ` Igor Mammedov
2012-05-09 13:12 ` Ingo Molnar
2012-05-10 17:31 ` Rob Landley
2012-05-10 17:39 ` Peter Zijlstra
2012-05-09 10:24 ` [PATCH 1/5] Fix soft-lookup in stop machine on secondary cpu bring up Igor Mammedov
2012-05-09 15:04 ` Shuah Khan
2012-05-09 15:22 ` Igor Mammedov
2012-05-09 15:34 ` Shuah Khan
2012-05-10 15:26 ` Shuah Khan
2012-05-10 16:29 ` Igor Mammedov
2012-05-10 16:38 ` Shuah Khan
2012-05-11 11:45 ` Thomas Gleixner
2012-05-11 15:16 ` Igor Mammedov
2012-05-11 21:14 ` Thomas Gleixner
2012-05-12 19:32 ` [RFC] [x86]: abort secondary cpu bringup gracefully Igor Mammedov
2012-05-12 17:39 ` Peter Zijlstra
2012-05-12 18:51 ` Igor Mammedov
2012-05-14 11:09 ` [RFC v2] " Igor Mammedov
2012-05-24 15:41 ` Igor Mammedov
2012-05-25 18:11 ` Rob Landley [this message]
2012-05-30 16:38 ` Igor Mammedov
2012-05-09 10:24 ` [PATCH 2/5] Take in account that several cpus might call check_tsc_sync_* at the same time Igor Mammedov
2012-05-09 10:25 ` [PATCH 3/5] Do not wait till next cpu online and abort early if lead cpu do not wait for us anymore Igor Mammedov
2012-05-09 10:25 ` [PATCH 4/5] Cancel secondary CPU bringup if boot cpu abandoned this effort Igor Mammedov
2012-05-09 10:25 ` [PATCH 5/5] Do not mark cpu as not present if we failed to boot it Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBFCB39.6000101@landley.net \
--to=rob@landley.net \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.intel.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome