From: Rafal Prylowski <prylowski@metasoft.pl>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Bryan Wu" <bryan.wu@canonical.com>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Rafał Pryłowski" <prylowski@metasoft.pl>
Subject: [PATCH] leds: don't disable blinking when writing the same value to delay_on or delay_off
Date: Mon, 28 May 2012 17:35:54 +0200 [thread overview]
Message-ID: <4FC39B5A.9010007@metasoft.pl> (raw)
Function led_set_software_blink() assumes that blink timer is still running,
but commit 488bc35bf40df89d37486c1826b178a2fba36ce7 introduced disabling
of blink timer before each call to led_set_software_blink().
Correct led_software_blink():
1) remove protection against reprogramming blink timer to the same values,
because it only disables blinking now,
2) remove unnecessary call to led_stop_software_blink().
Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
Cc: Bryan Wu <bryan.wu@canonical.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
Patch applies to current mainline.
drivers/leds/led-core.c | 7 -------
1 file changed, 7 deletions(-)
Index: mainline/drivers/leds/led-core.c
===================================================================
--- mainline.orig/drivers/leds/led-core.c
+++ mainline/drivers/leds/led-core.c
@@ -44,13 +44,6 @@ static void led_set_software_blink(struc
if (!led_cdev->blink_brightness)
led_cdev->blink_brightness = led_cdev->max_brightness;
- if (led_get_trigger_data(led_cdev) &&
- delay_on == led_cdev->blink_delay_on &&
- delay_off == led_cdev->blink_delay_off)
- return;
-
- led_stop_software_blink(led_cdev);
-
led_cdev->blink_delay_on = delay_on;
led_cdev->blink_delay_off = delay_off;
next reply other threads:[~2012-05-28 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 15:35 Rafal Prylowski [this message]
2012-05-29 1:52 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC39B5A.9010007@metasoft.pl \
--to=prylowski@metasoft.pl \
--cc=bryan.wu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome