mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Emmanuel Benisty <benisty.e@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: 71ca97da9d overrides user's kernel config
Date: Fri, 01 Jun 2012 20:14:06 +0200	[thread overview]
Message-ID: <4FC9066E.8060005@gmail.com> (raw)
In-Reply-To: <CA+55aFyK_m8aO57gC4Q1PJXmY3e1-uRXQ3E6PRgdBVixJSa2gQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]


> Yes, but I wonder if they should *also* be renamed, actually.
> 
> Those names are disgusting and unreadable, because the "MAC" part
> mixes with the actual name of the codepage. I really have a hard time
> reading something like MACROMANIAN, because to me it looks like it
> starts with "MACRO". It's just a bad name.
> 

I agree. It was something I've seen used as charset name but quick
websearch shows better alternatives like "Mac Romanian", "Mac OS
Romanian". Should I rename the charsets themselves as well?

> Also, the CODEPAGE part adds questionable value. I wonder if we should
> (a) remove the CODEPAGE part, (b) add an underscore between "MAC" and
> the name, and for the microsoft numeric codepages, do the same just to
> be consistent. IOW, use config names like NLS_DOS_1250 and
> NLS_MAC_ROMANIAN?

I'm ok with changing my newly-added charsets but I think that there is
no reason to rename already existing ones. It would just add a bunch of
new questions at reconfigure not corresponding to any real
functionality. Also, I believe, that the whole reason of NLS codepage
tables to exist is the ability to read old volumes and marginally the
ability to interchange data with old OS in a best available way. The
least it used for any purpose outside speaking with old OS or touching
old volumes, the better.
I'll prepare 2 patches: cleanup, config rename and codepage rename.
-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

  reply	other threads:[~2012-06-01 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+i8gKK5VJU_0YbBkeav6wTP+5YGp-rd52dTNqyoprz_YZrepA@mail.gmail.com>
     [not found] ` <4FC8E00E.60600@gmail.com>
2012-06-01 17:53   ` Linus Torvalds
2012-06-01 18:14     ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-06-01 18:48     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC9066E.8060005@gmail.com \
    --to=phcoder@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=benisty.e@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®