mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
	"olof@lixom.net" <olof@lixom.net>,
	Stephen Warren <swarren@nvidia.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dt: tegra: cardhu: register core regulator tps65911
Date: Fri, 08 Jun 2012 22:24:06 -0600	[thread overview]
Message-ID: <4FD2CFE6.9070500@wwwdotorg.org> (raw)
In-Reply-To: <20120609030608.GF3924@opensource.wolfsonmicro.com>

On 06/08/2012 09:06 PM, Mark Brown wrote:
> On Sat, Jun 09, 2012 at 12:52:03AM +0530, Laxman Dewangan wrote:
> 
>> So is it fine to go on the above binding?
>> In this case we need to find the match_regulator based on
>> regulator-id rather than by name.
> 
> I guess.  I'm not enthusiastic about it (some way of using the key/value
> nature of DT as a hash would be much nicer) but it seems that the
> combination of DT and the existing code for it can't really give us
> more.  
> 
> If we're going to do this we need to update all the existing DT bindings
> for drivers that use single node regulators like this.  Please also
> change the name used for the property to regulator-compatible to make it
> clear that the idea is the same as normal compatible properties.

I'm not sure of the logic behind naming the property
"regulator-compatible"; the standard compatible property identifies that
the node is of a particular type/class, whereas the regulator-id in the
example Laxman quoted would indicate the specific identity/object. Those
seem like different things.

  reply	other threads:[~2012-06-09  4:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 13:05 [PATCH 1/2] ARM: tegra: config: enable TPS65910 drivers Laxman Dewangan
2012-05-22 13:05 ` [PATCH 2/2] ARM: dt: tegra: cardhu: register core regulator tps65911 Laxman Dewangan
2012-05-22 16:40   ` Stephen Warren
2012-05-22 17:09     ` Laxman Dewangan
2012-05-22 17:19       ` Stephen Warren
2012-05-22 17:56         ` Laxman Dewangan
2012-05-22 18:27           ` Stephen Warren
2012-05-22 18:42             ` Laxman Dewangan
2012-06-01 19:23               ` Stephen Warren
2012-06-01 20:40                 ` Mark Brown
2012-06-01 20:44                   ` Stephen Warren
2012-06-01 21:04                     ` Mark Brown
2012-06-02 21:19                       ` Olof Johansson
2012-06-03  2:45                         ` Rob Herring
2012-06-03 12:05                           ` Mark Brown
     [not found]                             ` <4FCB8CA9.40602@firmworks.com>
2012-06-03 18:37                               ` Mark Brown
2012-06-03 11:55                         ` Mark Brown
2012-06-08 19:22                 ` Laxman Dewangan
2012-06-09  3:06                   ` Mark Brown
2012-06-09  4:24                     ` Stephen Warren [this message]
2012-06-11  2:57                       ` Mark Brown
2012-06-11 15:56                         ` Stephen Warren
2012-06-11 16:20                           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD2CFE6.9070500@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome