From: Ian Abbott <abbotti@mev.co.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Ian Abbott <ian.abbott@mev.co.uk>,
"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 12/15] staging: comedi: 8255: refactor subdev_8255_insn function
Date: Thu, 14 Jun 2012 10:03:55 +0100 [thread overview]
Message-ID: <4FD9A8FB.6020507@mev.co.uk> (raw)
In-Reply-To: <201206131542.46112.hartleys@visionengravers.com>
On 2012/06/13 11:42 PM, H Hartley Sweeten wrote:
> Refactor the subdev_8255_insn function to follow what the user
> space library is doing.
>
> 1) This function requires 'data' to contain 2 parameters. Add a
> sanity check for this (insn->n != 2).
Actually, the comedi core will have already checked that.
> 4) The user space library only checks for a < 0 return to indicate
> an error. It appears that the 'return 2' in this function is supposed
> to indicate the number of data parameters used to perform the command.
> Return the insn->n value for this, the open coded '2' looks wrong.
As long as it still returns 2, I don't care how you do it!
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2012-06-14 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 22:42 H Hartley Sweeten
2012-06-14 9:03 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD9A8FB.6020507@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®