From: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>,
mingo@kernel.org, LKML <linux-kernel@vger.kernel.org>,
roland@kernel.org, Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
efault@gmx.de, Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] sched: reset loop counters if all tasks are pinned and we need to redo load balance
Date: Tue, 19 Jun 2012 17:52:07 +0530 [thread overview]
Message-ID: <4FE06EEF.2090709@linux.vnet.ibm.com> (raw)
While load balancing, if all tasks on the source runqueue are pinned,
we retry after excluding the corresponding source cpu. However, loop counters
env.loop and env.loop_break are not reset before retrying, which can lead
to failure in moving the tasks. In this patch we reset env.loop and
env.loop_break to their inital values before we retry.
Signed-off-by: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
---
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 939fd63..60f8b66 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4520,8 +4520,11 @@ more_balance:
/* All tasks on this runqueue were pinned by CPU affinity */
if (unlikely(env.flags & LBF_ALL_PINNED)) {
cpumask_clear_cpu(cpu_of(busiest), cpus);
- if (!cpumask_empty(cpus))
+ if (!cpumask_empty(cpus)) {
+ env.loop = 0;
+ env.loop_break = sched_nr_migrate_break;
goto redo;
+ }
goto out_balanced;
}
}
next reply other threads:[~2012-06-19 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 12:22 Prashanth Nageshappa [this message]
2012-07-06 6:22 ` [tip:sched/core] sched: Reset " tip-bot for Prashanth Nageshappa
2012-07-24 14:20 ` tip-bot for Prashanth Nageshappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE06EEF.2090709@linux.vnet.ibm.com \
--to=prashanth@linux.vnet.ibm.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=roland@kernel.org \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome