From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77602C04AB4 for ; Fri, 17 May 2019 18:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F38920815 for ; Fri, 17 May 2019 18:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n4rnYPMZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727594AbfEQS1h (ORCPT ); Fri, 17 May 2019 14:27:37 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46360 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbfEQS1g (ORCPT ); Fri, 17 May 2019 14:27:36 -0400 Received: by mail-qt1-f195.google.com with SMTP id z19so9041883qtz.13; Fri, 17 May 2019 11:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:cc:message-id; bh=ylX4dkNphyKgjZG6Gfooblgch7RRdBC89uhBAsAa7as=; b=n4rnYPMZKQ+45s41or5HYS52g/J9VTXwFj38VqizwaLInn522QU7eqscGOnorMRGYA GuOo4H35CRWTu5OCGDQGju1C0pu+AcG9kbr9nczAFwbQWA8vSPcGzLv2tKDqIlaM3EXO fsQ2nvEYzLJZ9MIwJVHciFZZzooakJKiGZKzKjJn85bTeHWUrOp68YnER4F230jlyEYi n9ASrt08JH055jkQbCVCQ39/8AmpQYCSCgDovdsNmvnZOtP11zc8tROykxmIt4ca/gbS DFmhSg1QFptQtEW0Ge6yjL2PGT3If2HSKkkmtj9qp6Hboqw/ylCZ9KK1XlX6h4QS69U7 JItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:subject:to:cc:message-id; bh=ylX4dkNphyKgjZG6Gfooblgch7RRdBC89uhBAsAa7as=; b=rBkdDXteIK869jbRAvKC/Fid4F/ExmzjGYKFd/uQpKXVza9Pe630VypktVx7MauzRb 5KuUoT4Xr60Fn9UOutuUvQbXDxH9jL4pOOrQWJIUeGOe99KCGmIDXrQaqgoQ5ZbVXnhs jtZCDG7sO/i6ZU7NdhFOsOEdCmtnXiGMsn5R9kcuPxkaYy1eIb+sImSVF3yt/snssKWd V0+sC/4gQk6fpQtH8sZ4CNPHIcFNv5e/LFnh8lqxyFTvLllPsELrRpDjchMWD6MYDKnq MObU2gMLbi9mWRknApaGDYcRxKrqEH6ZejOBtn1Y1KrXdghWdrizupGfsYyGRbkCcsYa 9BnA== X-Gm-Message-State: APjAAAVkxNsPCCORTj0yMru2lo5z2dJDR4hYgvcJSwsWOsDygadPoITl pJC+ytK/EJzi72ip2UiPDCo= X-Google-Smtp-Source: APXvYqxycALsssZ+/j86lFwIUyRQef1lxX7mi14K8lB/RIFGWRUa8ImpLpUH9A8wJSAhswQN+sD91g== X-Received: by 2002:ac8:19f5:: with SMTP id s50mr49725912qtk.281.1558117655286; Fri, 17 May 2019 11:27:35 -0700 (PDT) Received: from [172.16.96.94] ([190.15.121.82]) by smtp.gmail.com with ESMTPSA id j23sm2583568qtl.78.2019.05.17.11.27.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 11:27:33 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Date: Fri, 17 May 2019 14:37:06 -0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <20190516225013.nvhwqi5tfwtby6qb@treble> <20190517050931.GB32367@kroah.com> <20190517073813.GB2589@hirez.programming.kicks-ass.net> <20190517085126.GA3249@kroah.com> <20190517152200.GI8945@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: Linux 4.19 and GCC 9 To: Ivan Babrou , Arnaldo Carvalho de Melo CC: Miguel Ojeda , Greg KH , Peter Zijlstra , Josh Poimboeuf , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel , Linux Kbuild mailing list , kernel-team Message-ID: <4FE2D490-F379-4CAE-9784-9BF81B7FE258@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 17, 2019 2:23:10 PM GMT-03:00, Ivan Babrou w= rote: >On Fri, May 17, 2019 at 8:22 AM Arnaldo Carvalho de Melo > wrote: >> >> Em Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda escreveu: >> > On Fri, May 17, 2019 at 10:51 AM Greg KH > wrote: >> > > >> > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: >> > > > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra > wrote: >> > > > > >> > > > > Right; if there is anything you can reproduce on linus=2Egit >I'll happily >> > > > > have a look=2E If it doesn't reproduce all you have to do is >find the >> > > > > patches that make it work and ask Greg=2E >> > > > >> > > > Just to clarify: Linus' master is clean of these issues with >GCC 9=2E1=2E1=2E >> > > >> > > Great! Care to find the patches that did that work and send me >the git >> > > commit ids so that I can queue them up? I don't have gcc9 here >yet on >> > > my systems, so I can not test for this=2E >> > >> > I am unsure about the perf and the objtools parts (Peter/Josh?), >but >> >> I'm not noticing these while building upstream perf with gcc 9=2E1=2E1 = on ^^^= ^^^^^^^^^^^^ >at >> least fedora:30=2E >> >> 33 fedora:30 : Ok gcc (GCC) 9=2E1=2E1 201905= 03 >(Red Hat 9=2E1=2E1-1) > >I've tried to replicate this in fedora:30 docker container and it's >there: > >[root@linuxkit-025000000001 perf]# gcc --version >gcc (GCC) 9=2E1=2E1 20190503 (Red Hat 9=2E1=2E1-1) > >[root@linuxkit-025000000001 perf]# pwd >/tmp/linux-4=2E19=2E44/tools/perf ^^^^^^^^^^^^^^ That is not upstream perf, please look for patches from 4=2E19 to Linus' m= aster Branch for fixes=2E I'll triple check here in a f30 container just in case meanwhile=2E Thanks, - Arnaldo > >[root@linuxkit-025000000001 perf]# make -j1 >=2E=2E=2E >trace/beauty/ioctl=2Ec: In function =E2=80=98ioctl__scnprintf_kvm_cmd=E2= =80=99: >trace/beauty/ioctl=2Ec:85:82: error: array subscript [-2147483648, -1] >is outside array bounds of =E2=80=98const char *[0]=E2=80=99 [-Werror=3Da= rray-bounds] > 85 | if (nr < strarray__kvm_ioctl_cmds=2Enr_entries && >strarray__kvm_ioctl_cmds=2Eentries[nr] !=3D NULL) > | >~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ >In file included from trace/beauty/ioctl=2Ec:82: >/tmp/linux-4=2E19=2E44/tools/perf/trace/beauty/generated/ioctl/kvm_ioctl_= array=2Ec:1:20: >note: while referencing =E2=80=98kvm_ioctl_cmds=E2=80=99 > 1 | static const char *kvm_ioctl_cmds[] =3D { > | ^~~~~~~~~~~~~~ >In file included from /usr/include/string=2Eh:494, > from util/debug=2Eh:7, > from builtin-help=2Ec:15: >In function =E2=80=98strncpy=E2=80=99, > inlined from =E2=80=98add_man_viewer=E2=80=99 at builtin-help=2Ec:192= :2, > inlined from =E2=80=98perf_help_config=E2=80=99 at builtin-help=2Ec:2= 84:3: >/usr/include/bits/string_fortified=2Eh:106:10: error: >=E2=80=98__builtin_strncpy=E2=80=99 output truncated before terminating n= ul copying as >many bytes from a string as its length [-Werror=3Dstringop-truncation] >106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos >(__dest)); >| =20 >^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >builtin-help=2Ec: In function =E2=80=98perf_help_config=E2=80=99: >builtin-help=2Ec:187:15: note: length computed here > 187 | size_t len =3D strlen(name); > | ^~~~~~~~~~~~ >trace/beauty/ioctl=2Ec: In function =E2=80=98ioctl__scnprintf_perf_cmd=E2= =80=99: >trace/beauty/ioctl=2Ec:109:84: error: array subscript [-2147483648, -1] >is outside array bounds of =E2=80=98const char *[0]=E2=80=99 [-Werror=3Da= rray-bounds] > 109 | if (nr < strarray__perf_ioctl_cmds=2Enr_entries && >strarray__perf_ioctl_cmds=2Eentries[nr] !=3D NULL) > | >~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ >In file included from trace/beauty/ioctl=2Ec:106: >/tmp/linux-4=2E19=2E44/tools/perf/trace/beauty/generated/ioctl/perf_ioctl= _array=2Ec:1:20: >note: while referencing =E2=80=98perf_ioctl_cmds=E2=80=99 > 1 | static const char *perf_ioctl_cmds[] =3D { > | ^~~~~~~~~~~~~~~ >cc1: all warnings being treated as errors > >> > about the -Wmissing-attributes I cleaned, they were these: >> >> > a6e60d84989f ("include/linux/module=2Eh: copy __init/__exit attrs to >> > init/cleanup_module") >> > c0d9782f5b6d ("Compiler Attributes: add support for __copy (gcc >=3D >9)") >> > ff98e20ef208 ("lib/crc32=2Ec: mark crc32_le_base/__crc32c_le_base >> > aliases as __pure") >> > >> > Cheers, >> > Miguel >> >> -- >> >> - Arnaldo