From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] regulator: tps65910: Remove unused min_uV and max_uV from struct tps_info
Date: Fri, 22 Jun 2012 11:27:17 +0530 [thread overview]
Message-ID: <4FE4093D.4070704@nvidia.com> (raw)
In-Reply-To: <1340275546.2922.1.camel@phoenix>
On Thursday 21 June 2012 04:15 PM, Axel Lin wrote:
> The min_uV and max_uV fields of struct tps_info are not used in the code.
> For the case voltage_table is provided, the min_uV and max_uV are the same
> values as volt_table[0] and volt_table[n_voltages -1].
> For the case voltage_table is not available, having the min_uV and max_uV seems
> misleading. Current code uses equations to get the voltage value in this case,
> but these equations do not use the min_uV and max_uV fields of struct tps_info.
>
> Thus this patch removes the min_uV and max_uV fields from struct tps_info.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2012-06-22 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 10:45 Axel Lin
2012-06-21 10:48 ` [PATCH 2/2] regulator: tps65910: Convert to regulator_list_voltage_table Axel Lin
2012-06-22 5:55 ` Laxman Dewangan
2012-06-22 5:57 ` Laxman Dewangan [this message]
2012-06-22 9:18 ` [PATCH 1/2] regulator: tps65910: Remove unused min_uV and max_uV from struct tps_info Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE4093D.4070704@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome