From: "Jan Beulich" <JBeulich@suse.com>
To: "Kay Sievers" <kay@vrfy.org>
Cc: <yuanhan.liu@linux.intel.com>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] syslog: fill buffer with more than a single message for SYSLOG_ACTION_READ
Date: Mon, 25 Jun 2012 08:05:17 +0100 [thread overview]
Message-ID: <4FE829CD020000780008B9DB@nat28.tlf.novell.com> (raw)
In-Reply-To: <CAPXgP13nd7k3v3YGcW9F45L8LhT5tctw64jaooUwQ8=ypfVH+g@mail.gmail.com>
>>> On 23.06.12 at 20:03, Kay Sievers <kay@vrfy.org> wrote:
>> Furthermore, this patch also addresses the problem dealt with in
>> commit 4a77a5a06ec66ed05199b301e7c25f42f979afdc ("printk: use mutex
>> lock to stop syslog_seq from going wild"), so I'd recommend reverting
>> that one too (albeit there's no direct collision between the two).
>
> Are you sure that is covered? Doesn't the other thread would just
> return 0 to the caller then, instead of continuing to stay in the
> syscall when the first thread got the message?
The old code permitted returning zero in that case too, so I don't
see why the new code shouldn't be allowed to. But anyway, as
said this patch doesn't directly conflict, and hence it's up to the
maintainer(s) of the code to decide whether to keep it. The
conflicting one, however, imo ought to be reverted in any case.
Jan
next prev parent reply other threads:[~2012-06-25 7:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 15:36 Jan Beulich
2012-06-23 18:03 ` Kay Sievers
2012-06-25 7:05 ` Jan Beulich [this message]
2012-06-25 19:20 ` Greg KH
2012-06-25 19:35 ` Kay Sievers
2012-06-26 0:01 ` Greg KH
2012-06-26 0:34 ` Kay Sievers
2012-06-26 19:55 ` Greg KH
2012-06-27 7:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE829CD020000780008B9DB@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®