From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: ccross@android.com, olof@lixom.net, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: apbio: use dmaengine based dma driver
Date: Fri, 29 Jun 2012 11:04:53 -0600 [thread overview]
Message-ID: <4FEDE035.6040005@wwwdotorg.org> (raw)
In-Reply-To: <1340969407-7662-1-git-send-email-ldewangan@nvidia.com>
On 06/29/2012 05:30 AM, Laxman Dewangan wrote:
> Use the dmaengine based Tegra APB DMA driver for
> apbio access in place of legacy Tegra APB DMA.
>
> The new driver is selected if legacy driver is not
> selected and new DMA driver is enabled through config
> file.
> +bool tegra_apb_dma_init(void)
> +{
...
> + tegra_apb_dma_chan = dma_request_channel(mask, NULL, NULL);
> + if (!tegra_apb_dma_chan) {
> + pr_err("%s: can not allocate dma channel\n", __func__);
> + goto err_dma_alloc;
> + }
That fires quite a few times during boot, before the DMA driver is
probed. I think the message should be down-graded to a pr_dbg(). Do you
agree? I can fix that myself when applying this if you're OK with the
change.
Aside from that, this looks fine to me.
next prev parent reply other threads:[~2012-06-29 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 11:30 Laxman Dewangan
2012-06-29 17:04 ` Stephen Warren [this message]
2012-06-30 15:01 ` Laxman Dewangan
2012-06-29 23:10 ` Stephen Warren
2012-06-29 11:34 Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEDE035.6040005@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ccross@android.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®