From: "Jan Beulich" <JBeulich@suse.com>
To: "Glauber Costa" <glommer@parallels.com>
Cc: "Ingo Molnar" <mingo@elte.hu>, <jeremy@goop.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: __force_order usage on x86's CRn accesses
Date: Tue, 03 Jul 2012 11:08:14 +0100 [thread overview]
Message-ID: <4FF2E0AE020000780008D48E@nat28.tlf.novell.com> (raw)
In-Reply-To: <4FF2C19D.4040608@parallels.com>
>>> On 03.07.12 at 11:55, Glauber Costa <glommer@parallels.com> wrote:
>> Furthermore, the addition of these constraints happened
>> without any real explanation - the code comment that was added
>> doesn't really help understand why "volatile" isn't sufficient here.
>
> If my memory dont't fail me, I believe this is because gcc will feel
> free to reorder a sequence of instructions that does not access memory.
> Specially since it has no knowledge of what's in the inline assembly,
> and what are its constraints. It only knows that it is an register
> operation, and treats it like one.
>
> Also, I believe what we are concerned with here is not arbitrary reorder
> between that and other instructions, which we welcome, but reordering
> between a read and a write to the same crX - specially of concern for
> things doing read-modify-writes of control registers.
But such sequences can't be re-ordered when the asm-s are
volatile qualified.
>> Finally (and this is because I lack the explanation why the
>> artificial constraint is needed in the first place), why is it that
>> clts() doesn't need one too?
>>
>
> Because we're not using it to do read-modify-write of the control register.
Sequences of read_cr0()/clts()/write_cr0() certainly exist (in
the xor implementations), so if a read_cr0()/write_cr0() can
have issues (which is impossible if the value written depends on
the one read), read_cr0()/clts() would be even more affected,
as there's no compiler visible dependency between the two.
But I don't think any such can happen in reality, and I was
hoping to be provided with an example of proving me wrong
(and understand the whole situation).
Jan
next prev parent reply other threads:[~2012-07-03 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4FF2D6AB020000780008D460@nat28.tlf.novell.com>
2012-07-03 9:55 ` Glauber Costa
2012-07-03 10:08 ` Jan Beulich [this message]
2012-07-03 9:04 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF2E0AE020000780008D48E@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=glommer@parallels.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®