From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH v2 2/2] ata: implement MODE SELECT command
Date: Thu, 05 Jul 2012 23:42:33 +0400 [thread overview]
Message-ID: <4FF5EE29.6020706@mvista.com> (raw)
In-Reply-To: <4FF58320.1050606@redhat.com>
Hello.
On 07/05/2012 04:05 PM, Paolo Bonzini wrote:
>>> +
>>> + /*
>>> + * No mode subpages supported (yet) but asking for _all_
>>> + * subpages may be valid
>>> + */
>>> + if (spg && (spg != ALL_SUB_MPAGES))
>>> + goto invalid_param;
>> Rather "paramater not supported" (0x26/0x01)...
> SCSI spec begs to differ... there is no reference to that sense code in
> the whole SPC spec.
Right you are, I was just picking the more fitting ASC/ASCQ from the table
instead of reading the command description itself. :-<
MBR, Sergei
next prev parent reply other threads:[~2012-07-05 19:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 9:40 [PATCH v2 0/2] ata: MODE SELECT implementation Paolo Bonzini
2012-07-05 9:40 ` [PATCH v2 1/2] ata: support MODE SENSE request for changeable and default parameters Paolo Bonzini
2012-07-05 9:40 ` [PATCH v2 2/2] ata: implement MODE SELECT command Paolo Bonzini
2012-07-05 11:42 ` Sergei Shtylyov
2012-07-05 12:05 ` Paolo Bonzini
2012-07-05 19:42 ` Sergei Shtylyov [this message]
2012-07-26 7:25 ` [PATCH v2 0/2] ata: MODE SELECT implementation Paolo Bonzini
2012-07-26 13:47 ` Jeff Garzik
2012-07-26 13:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5EE29.6020706@mvista.com \
--to=sshtylyov@mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome