From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753420Ab2GJGNl (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Jul 2012 02:13:41 -0400
Received: from na3sys009aog126.obsmtp.com ([74.125.149.155]:41838 "EHLO
	na3sys009aog126.obsmtp.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752543Ab2GJGNi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Jul 2012 02:13:38 -0400
Message-ID: <4FFBC808.5050602@ti.com>
Date: Tue, 10 Jul 2012 11:43:28 +0530
From: Rajendra Nayak <rnayak@ti.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110805 Thunderbird/3.1.12
MIME-Version: 1.0
To: Kishon Vijay Abraham I <kishon@ti.com>
CC: grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net,
        linux@arm.linux.org.uk, gregkh@linuxfoundation.org, b-cousson@ti.com,
        tony@atomide.com, devicetree-discuss@lists.ozlabs.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, balbi@ti.com,
        linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, hvaibhav@ti.com
Subject: Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data
References: <1340884267-28908-1-git-send-email-kishon@ti.com> <1340884267-28908-9-git-send-email-kishon@ti.com>
In-Reply-To: <1340884267-28908-9-git-send-email-kishon@ti.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
> Add twl4030-usb data node in twl4030 device tree file.
>
> Signed-off-by: Kishon Vijay Abraham I<kishon@ti.com>
> ---
>   arch/arm/boot/dts/twl4030.dtsi |   21 +++++++++++++++++++++
>   1 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
> index 22f4d13..66534a3 100644
> --- a/arch/arm/boot/dts/twl4030.dtsi
> +++ b/arch/arm/boot/dts/twl4030.dtsi
> @@ -37,6 +37,18 @@
>   		regulator-max-microvolt =<3150000>;
>   	};
>
> +	vusb1v5: regulator@3 {
> +		compatible = "ti,twl4030-vusb1v5";
> +	};

These @3, @4 are actually wrong since the node do
not have a 'reg' property in it. This was commented on
by David Brown on my original series which added this but
it somehow slipped through the cracks. I understand that
you would have looked up what existed in the file and
extended, but what already exists in the file needs to
be fixed up too. I'll send in a patch to fix those up.

regards,
Rajendra

> +
> +	vusb1v8: regulator@4 {
> +		compatible = "ti,twl4030-vusb1v8";
> +	};
> +
> +	vusb3v1: regulator@5 {
> +		compatible = "ti,twl4030-vusb3v1";
> +	};
> +
>   	twl_gpio: gpio {
>   		compatible = "ti,twl4030-gpio";
>   		gpio-controller;
> @@ -44,4 +56,13 @@
>   		interrupt-controller;
>   		#interrupt-cells =<1>;
>   	};
> +
> +	twl4030-usb {
> +		compatible = "ti,twl4030-usb";
> +		interrupts =<  10 4>;
> +		usb1v5-supply =<&vusb1v5>;
> +		usb1v8-supply =<&vusb1v8>;
> +		usb3v1-supply =<&vusb3v1>;
> +		usb_mode =<1>;
> +	};
>   };