From: Laxman Dewangan <ldewangan@nvidia.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Stephen Warren <swarren@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 2/2] dma: tegra: fix residual calculation for cyclic case
Date: Fri, 13 Jul 2012 11:09:02 +0530 [thread overview]
Message-ID: <4FFFB476.9050006@nvidia.com> (raw)
In-Reply-To: <1342149336.1726.5.camel@vkoul-udesk3>
On Friday 13 July 2012 08:45 AM, Vinod Koul wrote:
> On Mon, 2012-07-02 at 10:02 -0600, Stephen Warren wrote:
>> On 07/02/2012 02:22 AM, Laxman Dewangan wrote:
>>> In cyclic mode of DMA, the byte transferred can be more
>>> than the requested size and in this case, calculating
>>> residuals based on the current position of DMA transfer to
>>> bytes requested i.e. bytes required to transfer to reach
>>> bytes requested from current DMA position.
>>>
>>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>> This makes sense to me, although I wonder if details like this aren't
>> something that the dmaengine core should be handling.
> No core doesn't know anything about the how much you are transferring
> and where you are. That is the driver to calculate and provide.
Just for confirmation, are you going to apply this patch or do I need to
do anything here.
Thanks,
Laxman
next prev parent reply other threads:[~2012-07-13 5:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 8:22 Laxman Dewangan
2012-07-02 8:22 ` [PATCH 1/2] dma: tegra: rename driver and compatible to match with dts Laxman Dewangan
2012-07-02 16:01 ` Stephen Warren
2012-07-13 3:21 ` Vinod Koul
2012-07-02 16:02 ` [PATCH 2/2] dma: tegra: fix residual calculation for cyclic case Stephen Warren
2012-07-13 3:15 ` Vinod Koul
2012-07-13 5:39 ` Laxman Dewangan [this message]
2012-07-13 6:28 ` Vinod Koul
2012-07-13 6:39 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFFB476.9050006@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome