From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754071AbdHUUzO (ORCPT ); Mon, 21 Aug 2017 16:55:14 -0400 Received: from mout.web.de ([212.227.15.3]:50650 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbdHUUzN (ORCPT ); Mon, 21 Aug 2017 16:55:13 -0400 Subject: [PATCH 2/4] w1: Improve a size determination in two functions From: SF Markus Elfring To: "Andrew F. Davis" , Christophe Jaillet , Greg Kroah-Hartman , "Gustavo A. R. Silva" , Evgeniy Polyakov , "Maciej S. Szmigiero" , Sebastian Reichel , Wei Yongjun Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <4a01f6e8-6054-db98-a738-e42dd23a76b9@users.sourceforge.net> Date: Mon, 21 Aug 2017 22:54:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:mT68HGcA7WwgTPjoYVBBcpHi/Vha+zUhZ2y/cmUHbtPqMAr5RF2 EqUlMBzeNHkTpwyUftmYtRxGl2V8W1V4Akws3I7O6nhZxI1rNa9JEe1IH8ez3WM03NKwxnM LdjlTn4+YIjPiYCkbQ/wALCbOyLg6MSpJ9McPrYQTInrwlnuHtqVjb0khRZ3dutVx7YSjoR Ol4603+OnSAVEpDBgeBoQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:47Ghf90tuQg=:nwvNtUCkqmP07pl/nIQ5Rz +B4jj1GeUGDiu1aWjYyYzn4U9Edi3lXBzy7RKkV1UIaYFNj/PkuZGjMC/aT/l1IMItjthbKTH Ev4I+DI69oDDAKkd/dCfYqj3tGEpqSzb0DnQVblWRC1Mzr4DoDmF5c5WhgIasWGh5ILcJcF7w BLiY1uRpJ760ixj65fN7J4RA7eHf5kBvUSw8pV7F1xX1jnIstzr47048cwe2d9VbaQg4qeF81 mh+FiGaEaCkDYoUZm4nKvSkCYkSDGLuugwZDESp/GP7RLvFlh5rJEhN8bx46F18V8MOZZr6lG 4c7eHDIbN+k/bsbuMEDZPcfqtXT4KClJE/3pICKW38EPU1F8C/+WrpWkcLwk3UP5OCAGTYVd1 zG+TJESjKbV3x7nCopv/Fg1zhXgL2/DJLeBUX7N1PPvmyDhzmHhXPKXq2gKkdv6gZXKc+2sgU EKjBhDPluPaBT7Kn1LbZf8nibwVvHTyNM7xv0MPbjSQxwwT0Su6Zt1KwV2MOgApTtvdoLG78f Svqp3tI5P8xTFkxIBzLrGxyccDxU2uwLZ6s+GW7gaF8k7U7iUxOzMMUyIQT136WKgrTyCOaTI 3pymLbK6gqFrcBlm1TzEX8ZeYaMhqUoRhQz/U9My6Ygh0COSmK1AtdMiLpj7iAyMfzHQkoOUW jQEM3lvf26S5WIeuynWHJ44vg9A6ByiHTUCLXhsPhJghGC5D0Cdhj/1cjd8LSPODAEAkAgHzZ jWKzW9d+xUs9/7WWjPGQ1sF70iYltLm2ThdPPh3PTJUlhN8rUi1soe43DMIckFftBbleBalUO ZmflY1/MPytNyMGxIOepUs1R7DpDerggOEDw7lK2zET7cGkjhf4wy3nxAJe5QximEQ4GwjQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 21 Aug 2017 21:17:01 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/w1/slaves/w1_ds28e04.c | 2 +- drivers/w1/w1.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds28e04.c b/drivers/w1/slaves/w1_ds28e04.c index ec234b846eb3..794db5e8f46f 100644 --- a/drivers/w1/slaves/w1_ds28e04.c +++ b/drivers/w1/slaves/w1_ds28e04.c @@ -397,5 +397,5 @@ static int w1_f1C_add_slave(struct w1_slave *sl) struct w1_f1C_data *data = NULL; if (w1_enable_crccheck) { - data = kzalloc(sizeof(struct w1_f1C_data), GFP_KERNEL); + data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index f26c1ea280dd..9f71dc7aca3a 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -711,5 +711,5 @@ int w1_attach_slave_device(struct w1_master *dev, struct w1_reg_num *rn) int err; struct w1_netlink_msg msg; - sl = kzalloc(sizeof(struct w1_slave), GFP_KERNEL); + sl = kzalloc(sizeof(*sl), GFP_KERNEL); if (!sl) -- 2.14.0