From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFDA2ED14C for ; Tue, 25 Nov 2025 09:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764064778; cv=none; b=Ht55+8ymDpDq0tnVfBG0RyyHOpTMzGEEry4euMhz/R5XcE56p8TE06FF/aJsXdg6b5r4bl6C/l2FP5mCoy9iiaSVkXtSI08cRkTK7M764lXN0ohsOVlASW0/n9U4kH8JxJAm5IgINN0v3FIyTdv+E8IT0/+M2fewe8pCC4kt+vU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764064778; c=relaxed/simple; bh=R6QMB1wFC2BATzYNPhRuQ8QidzB6qeV3IovdUk/YQTI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=prbbWbjgEtas4Lq7+WClxdZ8m2HXh73WZLDFbxWkVP1hVgqT62gv4KRbivrvZKPiw18U+u4mSbthRknq1mhHjCKbl/KULWBXh62J2mxQHajIczWbdUdquk7qLdEtlJovkt3DBBzQmCdF9B1v7pTS8qkxwBXorMi7+J+gY3NmnoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iM54Qs/B; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iM54Qs/B" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-641977dc00fso7546374a12.1 for ; Tue, 25 Nov 2025 01:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764064775; x=1764669575; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fgh4ODFDnXgu6g2WTTqzK1hFnk5Jr1ZOv10EVLwZMBY=; b=iM54Qs/B6/n5IrKlNppjpuL91giWasf+ib/GKeY4wgUM5PapbJNBzhmeYkHOqRmmCn 5+hkIxAYrA6m2BPIU1h9DGfcVj/wsd/5nk2BfhwBpOQKiYNmq67jW2qsBDr1qbbEcDnM UNLj1GUL98yAdQA9zCf/i3evPIdBrJH86espWP9SrVA7dFrh4tFtImyt/cWS1BKlerre zcLoGFlx/De2VSolFm8RYGX8ZNOO71XeenEi1aBIMBWdRuaIXi5LXwe+d1lMIDdl3Q8C 65xPDlavFwHHZj9mLOYu4d68JP6oQWOg1H73zrIermC6hIxARXM4knK8OAsEMBJ8v2Hz ly7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764064775; x=1764669575; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fgh4ODFDnXgu6g2WTTqzK1hFnk5Jr1ZOv10EVLwZMBY=; b=o1xc7e2z77+Rxj3YhpMvNDDGdoeDOF+I1+GMqd/t/BLJQucjZPNH3khV/v1DRU1cAc UV3To3+EG64osv3dhzGiPVXh4I7WzX63ivHXE3XfCRfXUE0pQr2LT5wVIvBJScdu7JGx cRpatgwDdqVcN1LJXJzHOzEKMJELoFvyiohGSwzRppOdhZ7YS0VFXkdsa0HXyY+hTmQ/ P2d34GkJzj/06CYscxoMpuLyGhZ+BmjCP7Mn31HUxkc4uQIAS75NGoVMJm8+Qvfj3arn JHnY3kAD6j/H8fESrB74MQ1Z8V/3o8oQ8k+oigkJ32W95y/RhHP3gCBbkO/UElzCm4hJ NRIg== X-Forwarded-Encrypted: i=1; AJvYcCVePsrPWWyNRIXHlFyxXgpnt3m+Vguo7yHOW46ltDebPtVx8TjqRNTgKoM8zWEdcmtgjOa//GC9G+9kqGw=@vger.kernel.org X-Gm-Message-State: AOJu0YxeJfe9GXlih6IfbllGZ5xLFMAaIGdvPilBGNUUvuudnxW31SK5 7gRvdTATXJZDc7tikH7iuM8TtkWStBAx7rFCGqYZKHH6lI1nqbiaUP1J X-Gm-Gg: ASbGncssKEuCGRCuh8+6FWZZMONpm1ADDJj1Em2mYieyad6CO7C87IV5j0rJYs5gI18 kxSjrSalZky1S3HyY6PvAaJv+7T3ihQupbmMfjCWcG7SAQNzefyhafKYW6sUwPAA9LAHZ5m6WFb oCSORa7bmvAwWqECUzIqC0GQk+p4TjrK5piSeb//ZrTDMzQQWrjaBEX3gpGMmnIAP3UCp7Pt+O0 t6UU2m5BsLKEzsIwZqM4v0a6NY5tb3iP1le8ErUNgT9Cslae4DhiG705a/hJronbJ9zS1xQUBM3 095vXcFGY78k4SWi9DxXcZBcqwUMCib+gnZSt/Cy8F2hOHNsCzr7BffBmHePtrx/EGY7iECWQaj Sz16Uzxn+VRpL8Eb/EwGQ9W+AvXKy42Qree9dcS0xvI7etOrqDiwhLp+KYepdW45xrOpRhCmuDR 08NIVPHMDMpvsiUz6uVmawsmBslCuPcWEsOannD6hisKI= X-Google-Smtp-Source: AGHT+IESxJDwS/BJ1YU+rQ3vBeFJBP5tEOROc8lHgEyTp+47bod8zHWxWQ5jr9upDauFLWFNyK0Ddg== X-Received: by 2002:a17:907:3daa:b0:b73:57eb:688 with SMTP id a640c23a62f3a-b767183c4b1mr1636055866b.53.1764064774524; Tue, 25 Nov 2025 01:59:34 -0800 (PST) Received: from [10.25.216.228] ([128.77.115.157]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654fd51fbsm1498870766b.33.2025.11.25.01.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 01:59:34 -0800 (PST) Message-ID: <4a022153-009c-44fd-8c4b-39819ae69390@gmail.com> Date: Tue, 25 Nov 2025 01:59:31 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit index To: Frank Li Cc: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> <20251114133738.1762-3-laurentiumihalcea111@gmail.com> <6be8a682-6c72-45c8-be0e-880ab66045ff@gmail.com> Content-Language: en-US From: Laurentiu Mihalcea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/24/2025 7:41 AM, Frank Li wrote: > On Mon, Nov 24, 2025 at 01:28:32AM -0800, Laurentiu Mihalcea wrote: >> On 11/21/2025 7:38 AM, Frank Li wrote: >>> On Fri, Nov 14, 2025 at 05:37:34AM -0800, Laurentiu Mihalcea wrote: >>>> From: Laurentiu Mihalcea >>>> >>>> Replace the reset map mask with the bit index to make it clear that all >>>> reset lines are managed by exactly 1 bit. >>> I don't think there are benefit because I met some periphal need a magic >>> number to reset. >> >> Please provide more information. What SoC? Which peripherals? What block control? >> > I can't reminder exact one. I grep some code > > [IMX8MP_MEDIABLK_PD_LCDIF_1] = { > .name = "mediablk-lcdif-1", > .clk_names = (const char *[]){ "disp1", "apb", "axi", }, > .num_clks = 3, > .gpc_name = "lcdif1", > .rst_mask = BIT(4) | BIT(5) | BIT(23), > .clk_mask = BIT(4) | BIT(5) | BIT(23), > .path_names = (const char *[]){"lcdif-rd", "lcdif-wr"}, > .num_paths = 2, > }, > > mask is more extenable and easily support more hardware in future. Change > to bit number have not big benefit. sure, I'm fine with the mask-based approach. The big idea here is to make this driver usable in as many scenarios as possible. Philipp, please let me know if you're okay with the proposal. Will also have to tweak one of the subsequent patches since, so far, we've been operating under the assumption that reset lines are 1 bit.