From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kapsi.fi (mail-auth.kapsi.fi [91.232.154.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E494C96; Tue, 10 Jun 2025 05:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.232.154.24 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749531755; cv=none; b=erZWFvlrzl1ZLrs7gbD0xbvqSpQ9L1pyZC1AwP5B8qLS+Xnb9xBHNvbNoKK64VF9Kjv+ixh8s7gz//2HPJeM5emkhhjGWpp5Xx3CzGn3pRDs83227XQBgJjbmZUoFz0cfT5N+N7Ehg/FmZsi57m7oc2tgk1Vjouf8AHwNQmiHrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749531755; c=relaxed/simple; bh=PuBli1XtljBCsdtOuuaqRRhjsjOtq43kGbKlBLDMlpw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j6wrU3je+wxFbXmgz+L2EIEH9n2T/BXxfeCZLnlCs2V1jNwOFXEcCnYkYU7vu9Q4JtrZp7VyOfiQttNzqwwi9+ZVv+gNnCdRiian0XQEnBk7Tyt27qK0W7BfyCPTDBg+fqoghEQHYdO20JnfTQalfvzoPIOtF2hfP/B+v4dBnIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kapsi.fi; spf=pass smtp.mailfrom=kapsi.fi; dkim=pass (2048-bit key) header.d=kapsi.fi header.i=@kapsi.fi header.b=W1t/L6lG; arc=none smtp.client-ip=91.232.154.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kapsi.fi Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kapsi.fi Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kapsi.fi header.i=@kapsi.fi header.b="W1t/L6lG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5svVUtchtz7CoHBdcy+lHR9EZn7myAFDhWihgVXNkmI=; b=W1t/L6lGDPF0R10ik8dKmaitbo OUzeLg5OH5khxiIyjwI8s22Y2VCSIQxNpyXxAyIriv8mbtlJXSem52+ApcWsByo06eFQZMSI1lEOu QAvWgsBsJYflMs9DZTSpHrZIc8vjxSBXVnGqLyYYlvLwM1VGVMuAw5dN8ldDee1W8MAgCO7YrDh6+ eujydMqiTzJAVs7vgwtH9QxYhw4l1L7leci8JPkygSFhHpqT6wn+l0cNl5YPFPMizTqzZ1HQ6nY2B IWm7C4T+2/kNrRwMw+K+XmeC9ooGN4fuenm8oj7twmUXD5El+J3dwmgNv77dv2HR6tc2TNPx0Ckh4 H+JFgzjQ==; Received: from [2404:7a80:b960:1a00:5eaa:b33c:a197:a90f] by mail.kapsi.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uOr7q-007STv-2n; Tue, 10 Jun 2025 08:02:19 +0300 Message-ID: <4a02f671-2be0-45c9-b471-071596b22338@kapsi.fi> Date: Tue, 10 Jun 2025 14:01:01 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: tegra: Add NVJPG node To: Diogo Ivo , Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org References: <20250606-diogo-nvjpg-v1-0-5f2c36feeb39@tecnico.ulisboa.pt> <20250606-diogo-nvjpg-v1-3-5f2c36feeb39@tecnico.ulisboa.pt> Content-Language: en-US From: Mikko Perttunen In-Reply-To: <20250606-diogo-nvjpg-v1-3-5f2c36feeb39@tecnico.ulisboa.pt> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2404:7a80:b960:1a00:5eaa:b33c:a197:a90f X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false On 6/6/25 7:45 PM, Diogo Ivo wrote: > The Tegra X1 chip contains a NVJPG accelerator capable of > encoding/decoding JPEG files in hardware, so add its DT node. > > Signed-off-by: Diogo Ivo > --- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > index 6f8cdf012f0f12a16716e9d479c46b330bbb7dda..087f38256fd40f57c4685e907f9682eb49ee31db 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > @@ -253,7 +253,13 @@ vic@54340000 { > nvjpg@54380000 { > compatible = "nvidia,tegra210-nvjpg"; > reg = <0x0 0x54380000 0x0 0x00040000>; > - status = "disabled"; > + clocks = <&tegra_car TEGRA210_CLK_NVJPG>; > + clock-names = "nvjpg"; > + resets = <&tegra_car 195>; > + reset-names = "nvjpg"; > + > + iommus = <&mc TEGRA_SWGROUP_NVJPG>; > + power-domains = <&pd_nvjpg>; > }; > > dsib: dsi@54400000 { > Please mention Tegra210 in the commit subject, and perhaps adjust the commit message to say that you're updating and enabling the device tree node (rather than adding, since it's already there). With that, Reviewed-by: Mikko Perttunen