From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BBEC05027 for ; Thu, 26 Jan 2023 12:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236640AbjAZMcd (ORCPT ); Thu, 26 Jan 2023 07:32:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236531AbjAZMcb (ORCPT ); Thu, 26 Jan 2023 07:32:31 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7B004B48D for ; Thu, 26 Jan 2023 04:32:29 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso1005808wmq.5 for ; Thu, 26 Jan 2023 04:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/bNSq7yyd0Fn2CFk8JA2YspzkodNLpfvLBCK3Yp7urY=; b=oum0aFT6waydlwgkxuNblpIgYLzAffKOlwHZFRBf593vlK/BANnDrFdlUS89AZ4me7 t7F6gSmf8fSgbwgpL7y/garFTLUp+3M6lFJC2LuvieLGCrmvohxqkdVOTmg15uiAdWSr u7PCpDbuD767PgolBOStee35yRZH1oW1CXAkmaD7K8ArEbklE/UhfaIKa2h5eUubSv3N MCjBVvk/gkImWs2O5/kFk+JCzaVIBCHPwuKnpx+btOXeAAtbhtIc+oO5Vafu7R2ZCKK9 v38yuYW6hkPJLkKUBJSmgKVA6thZpcFaZhKFhp0Jtn16H6Ngnz9i7X4h/wBAgGzIFGWf Lw3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/bNSq7yyd0Fn2CFk8JA2YspzkodNLpfvLBCK3Yp7urY=; b=oCegZgStZE6UHWDV8vv2yx7PexEKZTLrHAHwOt5Ln+LB2bN95rZw+Wylyjj95/WOj/ TzG1kFPxFijmPdJFehHyFcWF4nQ/o01nRloDTuD/nhAwVQSyR0UlK44rnkpedZ8/WGi6 3M3332q0nF9WXIvPfw9itViIgcocWaF8cMEdRR6JZjGTeAbR2gTlKCVtEQNBJ5t7Ckg4 t+d4/b02ek154JYYlT5pCsUYR11CFswN8BXxYCOA7SsHsY5eozWbhEPAYj9c5b2E3xR/ ohXe1+YED6g0KhvyPi83VuyNfCpOl62sWzIJTr7huwJqWGr6AO4vIAqD3Tsi6bT8ggfo B7UA== X-Gm-Message-State: AFqh2krlSGW68rMEAUguPSyL6qBoCqNYUOYo0wnvop1W/IcSDqqAQHz8 oDmuI0xWMMLwGOsdAGW6EVapyQ== X-Google-Smtp-Source: AMrXdXv8WZZLPkrmDbdaf70Msw/d1T9RanynwxtPxW0TwnaFzZhcu526bILzcynC0l7mfwL8btwJWw== X-Received: by 2002:a05:600c:3d14:b0:3da:f793:fff6 with SMTP id bh20-20020a05600c3d1400b003daf793fff6mr35093224wmb.16.1674736348297; Thu, 26 Jan 2023 04:32:28 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id p12-20020a05600c468c00b003dc22ee5a2bsm2350815wmo.39.2023.01.26.04.32.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 04:32:27 -0800 (PST) Message-ID: <4a02f9be-04df-352b-fe49-7990eba5dc2e@linaro.org> Date: Thu, 26 Jan 2023 13:32:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v8 1/5] dt-bindings: input: pwm-beeper: Convert txt bindings to yaml Content-Language: en-US To: Manuel Traut , linux-kernel@vger.kernel.org Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Frieder Schrempf , linux-input@vger.kernel.org, devicetree@vger.kernel.org References: <20230126091825.220646-1-manuel.traut@mt.com> <20230126091825.220646-2-manuel.traut@mt.com> From: Krzysztof Kozlowski In-Reply-To: <20230126091825.220646-2-manuel.traut@mt.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/01/2023 10:18, Manuel Traut wrote: > Converts txt binding to new YAML format. > > Signed-off-by: Manuel Traut Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > new file mode 100644 > index 000000000000..351df83d5cbe > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/input/pwm-beeper.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop quotes from both. Apologies for not noticing it earlier. > + > +title: PWM beeper > + > +maintainers: > + - Dmitry Torokhov > + > +description: Registers a PWM device as beeper. > + > +properties: > + compatible: > + const: pwm-beeper > + > + pwms: > + maxItems: 1 > + > + amp-supply: > + description: > > + phandle to a regulator that acts as an amplifier for > + the beeper Drop "phandle to a" > + > + beeper-hz: > + description: bell frequency in Hz > + > +required: > + - compatible > + - pwms > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + beeper_amp: amplifier { > + compatible = "fixed-regulator"; > + gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; > + }; Drop this device node, not related. > + > + beeper { > + compatible = "pwm-beeper"; > + pwms = <&pwm0>; > + amp-supply = <&beeper_amp>; > + }; Best regards, Krzysztof