mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>,
	chunkuang.hu@kernel.org, matthias.bgg@gmail.com,
	robh+dt@kernel.org
Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
	jassisinghbrar@gmail.com, fparent@baylibre.com,
	yongqiang.niu@mediatek.com, hsinyi@chromium.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH V7 2/5] dt-bindings: display: mediatek: revise enum to const
Date: Mon, 14 Mar 2022 11:10:57 +0100	[thread overview]
Message-ID: <4a05db05-47c6-d035-06b7-b1bd65727601@collabora.com> (raw)
In-Reply-To: <20220314090033.25773-3-rex-bc.chen@mediatek.com>

Il 14/03/22 10:00, Rex-BC Chen ha scritto:
> There won't be more than 1 fallback for these bindings, so we modify
> them to use const instead of enum.
> 
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   .../devicetree/bindings/display/mediatek/mediatek,aal.yaml  | 3 +--
>   .../bindings/display/mediatek/mediatek,ccorr.yaml           | 3 +--
>   .../bindings/display/mediatek/mediatek,color.yaml           | 6 ++----
>   .../bindings/display/mediatek/mediatek,dither.yaml          | 3 +--
>   .../bindings/display/mediatek/mediatek,gamma.yaml           | 3 +--
>   .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml  | 6 ++----
>   .../devicetree/bindings/display/mediatek/mediatek,rdma.yaml | 6 ++----
>   7 files changed, 10 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> index 6c8c83988a24..eaf23428b30d 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> @@ -31,8 +31,7 @@ properties:
>                 - mediatek,mt8183-disp-aal
>                 - mediatek,mt8192-disp-aal
>                 - mediatek,mt8195-disp-aal
> -          - enum:
> -              - mediatek,mt8173-disp-aal
> +          - const: mediatek,mt8173-disp-aal
>   
>     reg:
>       maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> index 0ed53b6238f0..7766c806c102 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> @@ -28,8 +28,7 @@ properties:
>         - items:
>             - enum:
>                 - mediatek,mt8195-disp-ccorr
> -          - enum:
> -              - mediatek,mt8192-disp-ccorr
> +          - const: mediatek,mt8192-disp-ccorr
>   
>     reg:
>       maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> index 3ad842eb5668..0c9095b0411e 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> @@ -32,15 +32,13 @@ properties:
>             - enum:
>                 - mediatek,mt7623-disp-color
>                 - mediatek,mt2712-disp-color
> -          - enum:
> -              - mediatek,mt2701-disp-color
> +          - const: mediatek,mt2701-disp-color
>         - items:
>             - enum:
>                 - mediatek,mt8183-disp-color
>                 - mediatek,mt8192-disp-color
>                 - mediatek,mt8195-disp-color
> -          - enum:
> -              - mediatek,mt8173-disp-color
> +          - const: mediatek,mt8173-disp-color
>     reg:
>       maxItems: 1
>   
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> index 6657549af165..8180ed0a89ff 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> @@ -28,8 +28,7 @@ properties:
>             - enum:
>                 - mediatek,mt8192-disp-dither
>                 - mediatek,mt8195-disp-dither
> -          - enum:
> -              - mediatek,mt8183-disp-dither
> +          - const: mediatek,mt8183-disp-dither
>   
>     reg:
>       maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> index 78442339314f..5f1825b4512b 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> @@ -29,8 +29,7 @@ properties:
>             - enum:
>                 - mediatek,mt8192-disp-gamma
>                 - mediatek,mt8195-disp-gamma
> -          - enum:
> -              - mediatek,mt8183-disp-gamma
> +          - const: mediatek,mt8183-disp-gamma
>   
>     reg:
>       maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index f77094e61443..51f8235f1b1b 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -33,13 +33,11 @@ properties:
>             - enum:
>                 - mediatek,mt7623-disp-ovl
>                 - mediatek,mt2712-disp-ovl
> -          - enum:
> -              - mediatek,mt2701-disp-ovl
> +          - const: mediatek,mt2701-disp-ovl
>         - items:
>             - enum:
>                 - mediatek,mt8195-disp-ovl
> -          - enum:
> -              - mediatek,mt8183-disp-ovl
> +          - const: mediatek,mt8183-disp-ovl
>   
>     reg:
>       maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> index e8c72afa0630..9a6756f185ee 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> @@ -35,13 +35,11 @@ properties:
>             - enum:
>                 - mediatek,mt7623-disp-rdma
>                 - mediatek,mt2712-disp-rdma
> -          - enum:
> -              - mediatek,mt2701-disp-rdma
> +          - const: mediatek,mt2701-disp-rdma
>         - items:
>             - enum:
>                 - mediatek,mt8192-disp-rdma
> -          - enum:
> -              - mediatek,mt8183-disp-rdma
> +          - const: mediatek,mt8183-disp-rdma
>   
>     reg:
>       maxItems: 1



  reply	other threads:[~2022-03-14 10:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14  9:00 [PATCH V7 0/5] add display support for MediaTek SoC MT8186 Rex-BC Chen
2022-03-14  9:00 ` [PATCH V7 1/5] dt-bindings: display: mediatek: add aal binding for MT8183 Rex-BC Chen
2022-03-14 10:11   ` AngeloGioacchino Del Regno
2022-03-15 10:56   ` Krzysztof Kozlowski
2022-03-15 11:44     ` Rex-BC Chen
2022-03-14  9:00 ` [PATCH V7 2/5] dt-bindings: display: mediatek: revise enum to const Rex-BC Chen
2022-03-14 10:10   ` AngeloGioacchino Del Regno [this message]
2022-03-14  9:00 ` [PATCH V7 3/5] dt-bindings: display: mediatek: change to use enum for mutex Rex-BC Chen
2022-03-14 10:11   ` AngeloGioacchino Del Regno
2022-03-14  9:00 ` [PATCH V7 4/5] dt-bindings: display: mediatek: add MT8186 SoC binding Rex-BC Chen
2022-03-14 10:10   ` AngeloGioacchino Del Regno
2022-03-14  9:00 ` [PATCH V7 5/5] drm/mediatek: add display support for MT8186 Rex-BC Chen
2022-03-14 10:10   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a05db05-47c6-d035-06b7-b1bd65727601@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fparent@baylibre.com \
    --cc=hsinyi@chromium.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rex-bc.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®