From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbdHGMuw (ORCPT ); Mon, 7 Aug 2017 08:50:52 -0400 Received: from mail-sn1nam01on0072.outbound.protection.outlook.com ([104.47.32.72]:29520 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750751AbdHGMus (ORCPT ); Mon, 7 Aug 2017 08:50:48 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; lip6.fr; dkim=none (message not signed) header.d=none;lip6.fr; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 4/5] mmc: sdhci-of-arasan: constify sdhci_pltfm_data and sdhci_ops structures To: Julia Lawall , Michal Simek CC: , , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Adrian Hunter , Ulf Hansson , , , References: <1502099444-10473-1-git-send-email-Julia.Lawall@lip6.fr> <1502099444-10473-5-git-send-email-Julia.Lawall@lip6.fr> From: Michal Simek Message-ID: <4a087f6a-a51c-2add-402f-2d377457482e@xilinx.com> Date: Mon, 7 Aug 2017 14:50:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502099444-10473-5-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23242.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39410400002)(39400400002)(39860400002)(39840400002)(39450400003)(2980300002)(438002)(24454002)(189002)(199003)(2906002)(54906002)(81156014)(81166006)(6246003)(33646002)(65826007)(4001350100001)(47776003)(36386004)(65956001)(65806001)(8676002)(23676002)(356003)(305945005)(64126003)(39060400002)(83506001)(50466002)(77096006)(63266004)(508600001)(8936002)(626005)(4326008)(38730400002)(5660300001)(106466001)(53546010)(31686004)(6666003)(229853002)(2950100002)(50986999)(230700001)(54356999)(76176999)(31696002)(86362001)(189998001)(230783001)(9786002)(36756003)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR02MB2723;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT035;1:qAiq3wXLR2FUcuZw0G6g3RyGKJVX8d4KKOVw6fefOGgJYFv6kkLD+NHQrqc5NqyE0n6iea8H1stQtwxsd4eG+Y1jlLsk9/77Y4R3KKbfh/YLE75WzSfrJtvTLll4fAC5ZdJXOS4AJdzrXPD0DBD1shSb/B7wnwYLsNfAm25sCbcjj/IFgsdimVHMFKpePyHxJJfvJIzT3f/x82dD2uJ8Ym9PrqWUNv66VNPjJbAwBqhVV+OPJdiTXPFczNbcV1L4K+a12N6pg4F6cFR5A92PVs3KsLikBDGnC0ssjx1ynVqaOe95JMHeegq0LVzvaJ99ZNWpzSkg5pbCsZdDKSy0hPQCZGln6Msgyez7zO4iVeA0QcZ6S2DPS183DRiqXaV+o/hkJrXrpK06TtYn2GTV8vxmhP4vOVhJ3S/UFgBCff939ZGXRDQ5a834KjoLQGO1JAOoSum0xdlhE3uaKd/gAa2N/EMqhmvZcYyLTGDicDde/FsoV7DLr0YhW5XEUeK4H4hZ1AQlgx0qmU6Luv8T5yU6W/JB1jOFdjQiYvWNJ0LfPRwtopHZVaBJcfcg8MT5HF1RiPe8hhJZuSYe1Kx8rh7whuNtoPrl+acOtopSUCHWbaLFnlt8ojXqvQ20X9Z/8FR4Wfah278YBsQAbk68QWDX0Qr5fdROy7PWy88OB6ayB+S/Vguh22TvbgI53TCSjWbpAqQ2X9ExgXnPWPjTy9BOmUTVdh45shFY6gtGS4HsczfziMRK4hwfFdYAYcao+C83n61r7k7OdLK1jSuvRXACZkQdgMTorGAB6DYB6P6+GoIbio8KBwKmBSQsRfzvCI629Ivr9Clva97WVamtcqE0C+PafkCx/3TIse0j448p2+l5C0kT2ZOs2l8jz1SF X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9bd5e978-1eda-4430-fedb-08d4dd92eb55 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN6PR02MB2723; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2723;3:pD0GmP5BRjtVVOIXLWa9E7MDy4hQd26+/Dmk+rKVtHkUH6rGrhaBpnsHT373JmkzPTP9SvG9GF7YSLbe6ttRHUlD04v73TXFHXett4eJqWQ0L0TnZEwsniafELOoyr2wKfwkYfO1d9a1GoRRr0QMyGyR8Xil66t66jVwcUYCFqMOD4Spubx2Wq1wIJ0h7QoN/UFeTTifAQwMZJn3Pvww7eZpODbWJOfhPj0bR73wOo23nwFjTFTFiDnDVYTFwxELGFMAAq8vQcBdGDhW/aIkrmbULabR6VqH2fzeffsGiE39pSdm/fkcqaBEYC/rBdwnZwVnqEbbyKTJxx7ijsHMvCRPd0Xv/BTtgLE9y6j6X+c=;25:9GpM8MAi3hJz/YOZpUs2aXzT/34tRHrNd9CYuGeEjyYZUM36KAbxsWL85qroUGc/24P29Kb9DHaXjCmTQG7g54BnkKikMEm/7AqbHA1k0ZpZGkm+806yI8mXKv9Di/cM5397jaASqUd463O35mCpjK+FwR7Owm6j+M5yNJyIx2n4pTVTrvrWKclGM6xgydy8JWP8ow69OOrvleLxPDJUpe+22ypEwip99IWjzPNMOmsuZQoJnueYvqceN8UTKSpT0F5BptUO8r6wxvX6AzSGUh+oglIlBF7Xx7r44M/OCwj8sGPX9n/80DGoiS+W7PEJ0HoelayzrwwgZ2oV/MzQbw== X-MS-TrafficTypeDiagnostic: BN6PR02MB2723: X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2723;31:aSAqbZpyzv0hEhRGUWpuebXEbCUHtOjJntVuV79PVTv7XZ3j9UO/FUchIKUkZqNdwYRjQZaXt5T3seZYBf4NzTUdif36fc00S5GuYqbTGAwJVBMQ0vPRXltBcp3D0q0WxBKKRrwwiomQjd1fipEtH9BhgxQFqxVQhVDh/hCXgHxCVmsVZb9M+NtR3X0y2QETenw6czQ3rJHgBLRzuGd7aqliB4LnXWMWEay6N/YUMMs=;20:4wNkJAxOsstqEjSX9j9wb+6fOZqHWlcYJwveB9swwtrCHFbW04zC3eadCc5pu9UGhkDuWQG9AInISoB3xSKTNvDEgJVvokE0Ap/FAIybMIWsBlruaohR5mjSsW+pRFUbIem30rrzSgyLrvxTK5RKVQbqPRh9HLYod9Saqsr8qUz4vhEMPFtPo+5j5EvJtTWZLpkSdSxG48rEB2fCMyb0xGCtuEsf9k4Xn+Cw8Frd9VfplHrl+cK3gaKArNey2kUo+L0H2ZTLzSFU6gRanhCgygBBffBjWZN6TrJ0Ppal9NAY+oJ2lsQ/mfZWZOBUAOwdOxzNjtBqIWpSnpCJUFqHjuSK7eZ/cpF7rx532NtxCDM03FXutS8XGEDTFoKt5Fo5Mr6I6hpWEvmVNGUt+g0cO/gspMD6t9Pgpej3wIvvaDZkmenF5stSOZNLC/ss9PfmzAzzIeTNw1GKZ3mfau0j92/Pm8WoXNhaUircgEr5LObbx0xmnfQqf1CIpGY5pPef X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(13016025)(8121501046)(13018025)(3002001)(10201501046)(93006095)(93004095)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201703011903075)(201702281528075)(201703061421075)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR02MB2723;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR02MB2723; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2723;4:/239tesXFjpRIp8l5B+JkZ5+4en9fwVYlMixATjWeBHlF61L6bhtRz2PgldKk+pm3KDw8mg8yWW9P7uvUsyKtQZE3KpEU74a3x8+3LWJH6ZOuaQE8xY/kmQt9p/bcnOZyQk/DSR5ymLXz7UPNI6Ip3xM6j80bSc+CpqFhaneb5h9T9qgRf+I9CfckG66a8zK/yoMXlKCqxzliicVpQAM5x957y/k2ntXjl2QAH9SJF/j1lTSrt36pZlh/9qxskWw2rZg2NDp1yPyGAzF34chtkfivEYAz7ZcNyf1lC4SStA= X-Forefront-PRVS: 0392679D18 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAyTUIyNzIzOzIzOi9GZkZjMTNFWFJONlhWallBVEx3Zm9vckNB?= =?utf-8?B?SFovUm5MREI4N1NZa2x0QWF6WEVwdmgvMFZ6UHJFLzNldWNpci9lT2g4NDVH?= =?utf-8?B?U2hsTlpnOXFzRVZsZFpyVDY5RWlkRnN0SHFNR1RwV1VQZ0o1TUkwK0tPOUJT?= =?utf-8?B?Y20xUFc3TjNFVkw4YlNPVkNWV3E4ZVhUWmFTbG5PcTkyVk1iNHBkR0Z0NkVk?= =?utf-8?B?c2huZUk3akxjTkRMdTB5bkMvNHRqaUFLUXlXMXFCdExHeTM3RjhHaktUbFFa?= =?utf-8?B?THpEdlF0Z2FHTWNyNmpRNUZMYkJ5VXNPY2RKMk83VkhzR0V4cDN0SkpGRUZm?= =?utf-8?B?dXdWTnpFalpEZ3VUU0VoWndqZGUvQjVZRFRQZTQ1a0Q0QjhGMGN6N1dJQUxK?= =?utf-8?B?OVdWWW14TWNEWDZaOG9tejhxMUhIeCt6ZjFFb2F5Tk00ZDdzbEd0YmZXdzN3?= =?utf-8?B?ZVZvdmdVQi9ETldGNThpakNsUmhzVWU0N2VLWW5KRWpXbFNyOU9mRnZWWUYw?= =?utf-8?B?VVlnbVBaY1YzTTkvMWlJYjZON0I0bDFzZUwwMThvclVWSzBMVW1seGNPRmhZ?= =?utf-8?B?UHFlaiszaWtPNVFseWcvb1owN0l3NmQ0UmJVS2dtTW1OSElLN2VmU09ocS9s?= =?utf-8?B?dVlzZE1MdW81S0E4Yk1KcVNBNm1IYWd3VFNCd2NweGhGQzFycWlXb2kreGVy?= =?utf-8?B?cVdxQmM0MUlWNWN2SGNSenhRenNMb0c1QXhzMHhadGlxRzdWcDNFcHdiOWlh?= =?utf-8?B?QTJzTkZJVlJnZGVHdmdtNURhc3c1TTZRNmpTRzJjWlYzaDR4STVmdlBDcWIr?= =?utf-8?B?ejM3T015Ukl4U01sNGhJSnVmbStoZXArd3ozN1I3dXJ0QnhLUlFLUFFjc0pI?= =?utf-8?B?Z3I1L1VYVUVNaXg0a1NZSy90dk9HdVRWV0ZVMm8vTW4vdTZXQXRWYTFKMkRm?= =?utf-8?B?NzllY3RoVnhmUjlRZTNFOVNZODNQYVVaNVBOUVVuZjlNVk95Q2RScjBoMnA4?= =?utf-8?B?VDRIdHZtR00xcE1DL1lIemkxUG1yTnI1TXlrc1UrY1FQL2N2UWptSE1OejNI?= =?utf-8?B?Tkl1UnNJNkRqejhaT2gvV2xVTUtOTStrZG02RkliQVcyR1hONHpRclh3bnRz?= =?utf-8?B?L0Jhb2JrNXYwQWVVWHp3MzNjUklGTnZNNUk1WkRncEN4UTlncEFJTEpUcHdv?= =?utf-8?B?UjRmY0d3Rk9pL3VRMlRyRGtoNnVoVmxXa1Nmc0Z5VDZ4RGdxcVAxaHdvZFZr?= =?utf-8?B?NTcySFM2ZXoyQ1ZsVlpFRHI0eDVoZHdMWmFkSzRGOTAzeDhHczN2c1R1eWJV?= =?utf-8?B?ZFE2K29HWDcwR1BXdjBUOGpEb2c0eTNaMHQ0Z0FaQzFDVlBzeC9qNzE5Znhq?= =?utf-8?B?bDBrYmlBaCtJdzl6TjNoY3kwTnVGajlUUE9jUzJOQyt4OURlZ3NKNTVXdHRm?= =?utf-8?B?TW9WNlBDYi9BUnJpTVliTWYvQmhMTUh5M3piV2FWM1VCSWk5cDBCQURxMmpQ?= =?utf-8?B?MUx4L245OWxUZVh4L2pQNXB6TFVLMmkxU2g0L3czYVlXU04zS0toTngwWWRC?= =?utf-8?B?M1ZjYUVJMHduRGF1QlFqNTdKR2NDTUJlajE0V2pIbUs1QmIyeS9EVmxZV3ZR?= =?utf-8?B?VEdiY3NtYkg3MVpOamZZOVNNMDFKWkpPZ3BURnUvcmg2bVQ5VHlidzJvWGwy?= =?utf-8?B?N2xWY2oxK2QwdC8wdjV5bjFlMXBmMzdiVHJBdFZMdm50VndGL0NqTHZta0Q2?= =?utf-8?B?ckxqZi9DUTk3d1dWQVdaUHkxRVRWWENzUDAvNkxySE9EUkx2STNiZU1Ram43?= =?utf-8?B?MUJxNmNqT25VK0laaGxsRkhjWCsvV0FITWF1a3dYZHgrZWJBZUtWNjZCL2Y3?= =?utf-8?B?bmd5MWxTa25yZFVLaTNJcm1ML3Z0Qjkva1dOWW1oOHRNVGhrWDN3NTMwWmV3?= =?utf-8?B?bXJhRmtabGFBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2723;6:aK+7fU8iWT7Ekam7F3RnqV043z9sScVreJl3jNUPMCV/IFov0TiOOIRhlD2OTH54Av8woBS1QDBC+DaZfkWHTxNYoqh8zzfEsaWA3ZvyZUIZBKGi6E/XSbqwJ8gvYS6hrfAqOY3cmuXCFiiR1WVj3ngjwspk8ad7r0rD7CQlyrt+RYzJt+3AJdjElQBXcCyJdPJG0oaN/wNmtJfwJuCb4Nn956KKjPpXpiE+3UEyDU8pJQoeco1f8D3WCvSqshE4cuCVh1WpaswcdD3k7CCS7lOeJbZOM0wCDkyFpVIVt2rjJI+uf126LN+Cc6C0CSLH1/mrjPKLDnHJlMF5TEFcAQ==;5:SzPA+zZTnnfMbRL4hq6NPdd4iKEX+UOUYO6LndVFdPsGsq0oA2pBTmUF7oxBPJiK/pCsqjdwLxrG4yDFf0QMjAcudnRJWWKVrOoeWLtjjTs1+/pmsSa9xw41r5TTaTbwpOsU8DXMvHKXOKuG73WiXw==;24:vAu+VTEeGPGgH/Y7oMJ/1ft1/ruyIb1kHMWDkB98LxA6Fm6jaPx4dwZDFk/kS+sz0IAoOzMmcwI0pzNWqX1WEanUKh9eISKdhxhgZ8Vjfag=;7:0C4JHu0XziREWkpKVfZLVaHG8fgKTh9o5Irfc/xDciZWByu3E8yRvaebE8ZAePTpk9pcFURS00oaksqw//Tj2zpw5i+cfVXUQWcII83uE9i2KJZsf+8hyrC259L7ZfrtTJNFsPaGlIE3HalOzQ4dUwqEAyUzbWeQfeXSOWoljZUZvz68G8T2STQquyW+4iDwBk1bzc7dRWxuLKtF2RQX1T1IvzczaulkuMgekolMGdg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2017 12:50:44.4483 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2723 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7.8.2017 11:50, Julia Lawall wrote: > The sdhci_pltfm_data structure is only passed as the second argument > of sdhci_pltfm_init, which is const, while the sdhci_ops structure > is only stored in the ops field of a sdhci_pltfm_data structure, > which is also const. Thus both kinds of structures can be const as > well. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/mmc/host/sdhci-of-arasan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 528a5d2..0720ea7 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -262,7 +262,7 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc, > return -EINVAL; > } > > -static struct sdhci_ops sdhci_arasan_ops = { > +static const struct sdhci_ops sdhci_arasan_ops = { > .set_clock = sdhci_arasan_set_clock, > .get_max_clock = sdhci_pltfm_clk_get_max_clock, > .get_timeout_clock = sdhci_pltfm_clk_get_max_clock, > @@ -271,7 +271,7 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc, > .set_uhs_signaling = sdhci_set_uhs_signaling, > }; > > -static struct sdhci_pltfm_data sdhci_arasan_pdata = { > +static const struct sdhci_pltfm_data sdhci_arasan_pdata = { > .ops = &sdhci_arasan_ops, > .quirks = SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, > .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | > Acked-by: Michal Simek Thanks, Michal