From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D479C48BE8 for ; Wed, 16 Jun 2021 15:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39E2761002 for ; Wed, 16 Jun 2021 15:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234484AbhFPPac (ORCPT ); Wed, 16 Jun 2021 11:30:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48432 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234357AbhFPPa3 (ORCPT ); Wed, 16 Jun 2021 11:30:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623857302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BLas3/nFvDzs67dkoqE0uPTj+WWCmULhYvLflkP+fWo=; b=GGkC1mWrAWu23uiP2Y0xREcTmmf7C3JuBaGHskSMoxQP4Ar5qrmZ9b6YsTImHrkmlaJbqY zBidF4nAqAE1SGhScxDaxwXV4vupAOqlCZ/26lBu6KOF9y0G8e8K5GA+6ckdywo1xncNlI ir20uQjLiKw2A/7BP8EBuOl6R/9LWUU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-543-kD5j4zOvND6YXVSds5LdBA-1; Wed, 16 Jun 2021 11:28:21 -0400 X-MC-Unique: kD5j4zOvND6YXVSds5LdBA-1 Received: by mail-ed1-f72.google.com with SMTP id j3-20020aa7c3430000b0290393f7aad447so1244471edr.18 for ; Wed, 16 Jun 2021 08:28:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BLas3/nFvDzs67dkoqE0uPTj+WWCmULhYvLflkP+fWo=; b=biqCOmblYBHJZHPuBsfF2ghRt94HwaMb753WjyL9cwMLiTKoTyyZE+hD2H67JkeZQR 7jDGfwdNUhDgItHFMJ4Biw5VTkezaotE+g82jfMM/9+70WNQJ1mrqJdlTTfhBTusC44X jyllXh/8hfZs7in+sM1a5Qfs5zTZCSQO8vE6iynh2gCWXp6EiorMOHUN2SYQfnTowThS 8KHpFVGHTMq4Y+KHTm5HvF2UKCzX86/441fdruNRVAGlu18C5vq56PI8wfWHXRzaHnP1 CMub/B437nR39WzTSWTQDSACwmAEqwubsvY9y7QFjEmyLHWLYrgqma7HsejxE5hOaSlw 5Ffw== X-Gm-Message-State: AOAM530eGVjK3Mr46yGaXIXaIAGnW4EPipGPiqndP21WWPWqxXahVeRG BUu7WU/IDGQUoeJ1mHLyLf5Jj6E9jt+cjGppQtzYbQvBIZ4KD6XkcDBWxeXO6+WhgYoVZplyep2 1kXHj3w2NjDdwQWne0Prd6a8srNKFrldSNvu+6JQA+sHEQ0oPuJLGvEq8udAdnBC+vNMw5gb3LI ZH X-Received: by 2002:a17:907:6f2:: with SMTP id yh18mr80065ejb.5.1623857300211; Wed, 16 Jun 2021 08:28:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/ww3BJp4hsJ3ry2mzr6M3d8roZGAdHTBAEdOEGDLnh0e3VRj2B6oTQ86XraJunbgXUJNDuQ== X-Received: by 2002:a17:907:6f2:: with SMTP id yh18mr80047ejb.5.1623857299995; Wed, 16 Jun 2021 08:28:19 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id n23sm2136526edr.87.2021.06.16.08.28.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 08:28:19 -0700 (PDT) Subject: Re: [PATCH 2/5] ACPI: scan: Make acpi_walk_dep_device_list() To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux ACPI , LKML References: <3140195.44csPzL39Z@kreacher> <1881350.PYKUYFuaPT@kreacher> From: Hans de Goede Message-ID: <4a08edff-df90-aeee-1d1d-76e6e0b9af4d@redhat.com> Date: Wed, 16 Jun 2021 17:28:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 6/16/21 5:11 PM, Rafael J. Wysocki wrote: > On Wed, Jun 16, 2021 at 4:41 PM Hans de Goede wrote: >> >> Hi, >> >> On 6/16/21 4:22 PM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> Because acpi_walk_dep_device_list() is only called by the code in the >>> file in which it is defined, make it static, drop the export of it >>> and drop its header from acpi.h. >>> >>> Signed-off-by: Rafael J. Wysocki >> >> Actually, acpi_walk_dep_device_list() was split out as a >> helper function used to implement acpi_dev_clear_dependencies() >> because it will be used outside of drivers/acpi. > > Not exactly. > >> Specifically it will be used in the new intel_skl_int3472 driver: >> https://patchwork.kernel.org/project/platform-driver-x86/patch/20210603224007.120560-6-djrscally@gmail.com/ > > That driver will use acpi_dev_get_first_consumer_dev() which is based > on acpi_walk_dep_device_list(), but still defined in > drivers/acpi/scan.c. > >> Which I plan to merge into pdx86/for-next today, I've just merged >> your linux-pm/acpi-scan PULL-req which exports acpi_walk_dep_device_list() >> as preparation for this. > > No, the acpi_walk_dep_device_list() is a leftover there AFAICS. You are right, my bad. So with this resolved, this patch is fine too: Reviewed-by: Hans de Goede Regards, Hans