From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249AbcHSBWC (ORCPT ); Thu, 18 Aug 2016 21:22:02 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:60207 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754513AbcHSBVl (ORCPT ); Thu, 18 Aug 2016 21:21:41 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: briannorris@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <36e15ad5cdafe0b2a7855102886031cd> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v9 2/2] PCI: Rockchip: Add Rockchip PCIe controller support To: Bjorn Helgaas References: <1470297128-6213-1-git-send-email-shawn.lin@rock-chips.com> <1470297128-6213-2-git-send-email-shawn.lin@rock-chips.com> <20160818212444.GQ27353@localhost> Cc: shawn.lin@rock-chips.com, Bjorn Helgaas , Marc Zyngier , linux-pci@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Heiko Stuebner , Doug Anderson , Wenrui Li , Rob Herring , devicetree@vger.kernel.org, Brian Norris From: Shawn Lin Message-ID: <4a09c742-053b-7a16-efd1-a3c972d7c9a8@rock-chips.com> Date: Fri, 19 Aug 2016 09:20:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160818212444.GQ27353@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/8/19 5:24, Bjorn Helgaas 写道: > Hi Shawn, > > On Thu, Aug 04, 2016 at 03:52:08PM +0800, Shawn Lin wrote: >> This patch adds Rockchip PCIe controller support found >> on RK3399 Soc platform. > >> --- a/drivers/pci/host/Kconfig >> +++ b/drivers/pci/host/Kconfig >> @@ -264,4 +264,15 @@ config PCIE_ARTPEC6 >> Say Y here to enable PCIe controller support on Axis ARTPEC-6 >> SoCs. This PCIe controller uses the DesignWare core. >> >> +config PCIE_ROCKCHIP >> + bool "Rockchip PCIe controller" >> + depends on ARM64 && ARCH_ROCKCHIP > > I don't see any actual ARM64 dependencies in the code (which is a very > good thing!). Can we remove the "depends on ARM64" part? sure, we could. Actually we are going to use this controller for arm32 as well, so yes, I will remove it. > >> + depends on OF >> + depends on PCI_MSI_IRQ_DOMAIN >> + select MFD_SYSCON >> + help >> + Say Y here if you want internal PCI support on Rockchip SoC. >> + There is 1 internal PCIe port available to support GEN2 with >> + 4 slots. > > > -- Best Regards Shawn Lin