From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752554AbdHUIod (ORCPT ); Mon, 21 Aug 2017 04:44:33 -0400 Received: from hermes.aosc.io ([199.195.250.187]:53696 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdHUIoc (ORCPT ); Mon, 21 Aug 2017 04:44:32 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 21 Aug 2017 16:44:30 +0800 From: icenowy@aosc.io To: Maxime Ripard Cc: devicetree@vger.kernel.org, Chen-Yu Tsai , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: sun8i: a33: add dts for Q8 tablets with different resolution In-Reply-To: <20170821084053.s4qmhlvgsmckmqgh@flea.lan> References: <20170817074926.3410-1-icenowy@aosc.io> <20170821084053.s4qmhlvgsmckmqgh@flea.lan> Message-ID: <4a0a72b4679db296a8e48512c41a2ce5@aosc.io> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2017-08-21 16:40，Maxime Ripard 写道： > On Thu, Aug 17, 2017 at 03:49:26PM +0800, Icenowy Zheng wrote: >> Q8 tablets with Allwinner A33 SoC now come with two kind of LCD, >> either >> 800x480 or 1024x600. >> >> In order for sun4i-drm to be able to choose correct LCD configuration, >> two different device trees should be present, one for a resolution. >> >> Add stub device trees for two resolutions. >> >> As the sun4i-drm driver still has some problems to support the LCDs, >> the >> real LCD device nodes are not added to the device tree files. >> >> Signed-off-by: Icenowy Zheng > > This should be an overlay, ideally applied by the bootloader. I think this is not suitable for overlay. The two kind of Q8 tablets are not compatible at all, and they should both have a suitable device tree. The old DT without resolution is only kept for backward compatibility. > > Maxime > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel