From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbdDJUUF (ORCPT ); Mon, 10 Apr 2017 16:20:05 -0400 Received: from mout.web.de ([212.227.17.12]:60171 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbdDJUUD (ORCPT ); Mon, 10 Apr 2017 16:20:03 -0400 Subject: [PATCH 2/3] ACPI/int340x_thermal: Improve size determinations in two functions From: SF Markus Elfring To: linux-pm@vger.kernel.org, Eduardo Valentin , Srinivas Pandruvada , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org References: <3ba36cc1-8445-462c-ca75-2b0928f3290a@users.sourceforge.net> Message-ID: <4a122a0b-ac75-4a89-c991-487cc0017c5a@users.sourceforge.net> Date: Mon, 10 Apr 2017 22:19:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <3ba36cc1-8445-462c-ca75-2b0928f3290a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Rjlxcmf3NdeSMHJU8rwkC3RduzA7igUayC3mq4vR8sYRut//vVD MWlKAEmJUOEaRc0ud6cwRYCJo+1Wq57An+EveV5yraarzix+wsaS4lh5rA4upS6BWUT+g8v /UGuW/+uRdYte+VoJucNj4rJvF3ZWuUX/3kpCpaeZM9iGhFSu8XImnTG9wAhSrE0QmEoRsr AnL18OjMJyIi8fhaWiMcA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Y8Cj57EuWpA=:bWyZpLlX0o53NmeUVFnNQU mgDxIGPFWpD3y1PJvxrStYMZogn8oGRMv93hIPy4B4HMkXnpUmpkZJEXKWR2msIPNmLyklbpN ZByeD/6KCh6Rbwa4fCwRz1fkzvH7aW1Mea8OsP3Hq3mY0GKAYWokmo6rBUMaGARMyb/ZJJP3y 8jNNSYXSgRRXo7uYO3TV7ZrIl9GJXVguvUGpzb/jCewDBuLRPOHnDIy3UIPzZOzRrCDUK5Ut5 97x2ng3927bVUkqfO7awlTjEySa0x8Jb9sSnSjQm6BWmCk5Si+694BXSsy0EUuH54Q1irM5VP bSg/yDpjV4sKgebM+FGYCXbRUaGatJS4bRPC/K/Grs3M1k2X/esQG9aZLYEBnJLanvtX1GgC1 V0rCfz9KQrNkzirJ5gb1iAjxf8jxRnFOh7q14Ab08b8QxcQkIbfmemPWV2U8b5QOcJrfxxT12 FxW/GftUqcIPVbPNlL06dbtjes80SkbEnEudgCysQOwuBkquLBgJFAi20K7OmN7BWqolwjQbs xzyMYhPOs31Mcs2uII32dy3Rnd6LKEusvxAVio6Kfhph70rU3hKSsDdUFGajv0Bm5j/xJm5bD kU4/FTygPYh3oD9FNNOFxT27SNACApAc1UR9oLJvKEFf2+brP5QWlu2vVBjPMdd+R/fFl+9ue CCX7u0S1vkOJyoars5GrjwpUBiB9pPatlgj7HeRKs0+wEtKBIjm2n+mc1OlP7oeZJqil7/sfD nBp3++l+e3/RDjONfDoi82JCxkAgI+yEibZ+mpKk17uAt0t/jMF1wS0T7/ZMVlAr6x+ps7/Qj dpfE3j1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 10 Apr 2017 21:42:44 +0200 Replace the specification of two data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determinations a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/thermal/int340x_thermal/acpi_thermal_rel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/int340x_thermal/acpi_thermal_rel.c b/drivers/thermal/int340x_thermal/acpi_thermal_rel.c index 52a5fe0f81e8..d7791b1fec33 100644 --- a/drivers/thermal/int340x_thermal/acpi_thermal_rel.c +++ b/drivers/thermal/int340x_thermal/acpi_thermal_rel.c @@ -247,7 +247,7 @@ static int fill_art(char __user *ubuf) ret = acpi_parse_art(acpi_thermal_rel_handle, &count, &arts, false); if (ret) goto free_art; - art_len = count * sizeof(union art_object); + art_len = count * sizeof(*art_user); art_user = kzalloc(art_len, GFP_KERNEL); if (!art_user) { ret = -ENOMEM; @@ -283,7 +283,7 @@ static int fill_trt(char __user *ubuf) ret = acpi_parse_trt(acpi_thermal_rel_handle, &count, &trts, false); if (ret) goto free_trt; - trt_len = count * sizeof(union trt_object); + trt_len = count * sizeof(*trt_user); trt_user = kzalloc(trt_len, GFP_KERNEL); if (!trt_user) { ret = -ENOMEM; -- 2.12.2