From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932115AbdKONHW (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Nov 2017 08:07:22 -0500
Received: from lelnx193.ext.ti.com ([198.47.27.77]:60288 "EHLO
        lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752796AbdKONHM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Nov 2017 08:07:12 -0500
Subject: Re: [PATCH 2/2] leds: lm3692x: Introduce LM3692x dual string driver
To: Pavel Machek <pavel@ucw.cz>
CC: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
        <jacek.anaszewski@gmail.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org>
References: <20171113205052.25884-1-dmurphy@ti.com>
 <20171113205052.25884-2-dmurphy@ti.com> <20171115104526.GC456@amd>
 <1b0c05a6-2261-85d5-a3c6-9753f7600a20@ti.com> <20171115130057.GA11557@amd>
From: Dan Murphy <dmurphy@ti.com>
Message-ID: <4a13eae0-044a-95f1-ab3e-68b2114f623b@ti.com>
Date: Wed, 15 Nov 2017 07:06:37 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171115130057.GA11557@amd>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Pavel

On 11/15/2017 07:00 AM, Pavel Machek wrote:
> Hi!
> 
>>>> +	ret = regmap_write(led->regmap, LM3692X_PWM_CTRL,
>>>> +		LM3692X_PWM_FILTER_100 | LM3692X_PWM_SAMP_24MHZ);
>>>> +	if (ret)
>>>> +		dev_err(&led->client->dev, "Failed programming PWM CTRL\n");
>>>> +
>>>> +	ret = regmap_write(led->regmap, LM3692X_BOOST_CTRL,
>>>> +			LM3692X_BRHT_MODE_RAMP_MULTI |
>>>> +			LM3692X_BL_ADJ_POL |
>>>> +			LM3692X_RAMP_RATE_250us);
>>>> +	if (ret)
>>>> +		dev_err(&led->client->dev, "Failed programming BOOST CTRL\n");
>>>> +
>>>> +	ret = regmap_write(led->regmap, LM3692X_AUTO_FREQ_HI, 0x00);
>>>> +	if (ret)
>>>> +		dev_err(&led->client->dev, "Failed programming AUTO HI FREQ\n");
>>>
>>> If something fails, is it wise to continue?
> 
> If something fails, is it wise to continue?
> 

Sorry missed that comment.  It is ok to continue but probably should goto out and return
an error so the probe fails.

Dan

> 									Pavel
> 


-- 
------------------
Dan Murphy