From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] drm/bochs: add edid present check
Date: Wed, 19 Dec 2018 17:37:10 +0200 [thread overview]
Message-ID: <4a1897bf-2b48-fdd7-25e3-d7d25b9885c3@gmail.com> (raw)
In-Reply-To: <20181219152129.k7v4ttpsazguswke@sirius.home.kraxel.org>
On 12/19/18 5:21 PM, Gerd Hoffmann wrote:
> Hi,
>
>> You could probably have a comment here explaining the magic below
>> (just like in the commit message to ease the task of understanding
>> while reading the code why 2 of 8 bytes of the EDID header is checked
>> and why it is all needed). Of course one can use git blame... Up to you
> Makes sense.
>
>>> + if (readb(bochs->mmio + 0) != 0x00 ||
>>> + readb(bochs->mmio + 1) != 0xff)
>> bochs->mmio is defined as "void __iomem *mmio;". Can we please avoid
>> void pointer arithmetic here?
> Why is that a problem? gcc uses bytes when doing pointer arithmetic
> with void pointers (even though it is undefined in the C standard),
> and as far I know the linux kernel depends on that behavior anyway.
>
> Also the driver already does it everywhere.
Ok then, just to be consistent with the rest of the driver.
> cheers,
> Gerd
>
prev parent reply other threads:[~2018-12-19 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 7:33 Gerd Hoffmann
2018-12-19 14:10 ` Oleksandr Andrushchenko
2018-12-19 15:21 ` Gerd Hoffmann
2018-12-19 15:37 ` Oleksandr Andrushchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a1897bf-2b48-fdd7-25e3-d7d25b9885c3@gmail.com \
--to=andr2000@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®