mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andy Yan" <andyshrk@163.com>
To: "Heiko Stuebner" <heiko@sntech.de>
Cc: hjc@rock-chips.com, andy.yan@rock-chips.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re:[PATCH] drm/rockchip: vop2: fail cleanly if missing a primary plane for a video-port
Date: Thu, 12 Jun 2025 14:11:37 +0800 (CST)	[thread overview]
Message-ID: <4a19525.4f96.19762c3f163.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <20250610212748.1062375-1-heiko@sntech.de>


Hi Heiko,
At 2025-06-11 05:27:48, "Heiko Stuebner" <heiko@sntech.de> wrote:
>Each window of a vop2 is usable by a specific set of video ports, so while
>binding the vop2, we look through the list of available windows trying to
>find one designated as primary-plane and usable by that specific port.
>
>The code later wants to use drm_crtc_init_with_planes with that found
>primary plane, but nothing has checked so far if a primary plane was
>actually found.
>
>For whatever reason, the rk3576 vp2 does not have a usable primary window
>(if vp0 is also in use) which brought the issue to light and ended in a
>null-pointer dereference further down.
>
>As we expect a primary-plane to exist for a video-port, add a check at
>the end of the window-iteration and fail probing if none was found.
>
>Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
>Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Andy Yan <andy.yan@rock-chips.com>

Thanks


>---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>index 7ddf311b38c6..a8dc2e55812a 100644
>--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>@@ -2425,6 +2425,10 @@ static int vop2_create_crtcs(struct vop2 *vop2)
> 				break;
> 			}
> 		}
>+
>+		if (!vp->primary_plane)
>+			return dev_err_probe(drm->dev, -ENOENT,
>+					     "no primary plane for vp %d\n", i);
> 	}
> 
> 	/* Register all unused window as overlay plane */
>-- 
>2.47.2
>

  reply	other threads:[~2025-06-12  6:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 21:27 [PATCH] " Heiko Stuebner
2025-06-12  6:11 ` Andy Yan [this message]
2025-07-08 17:35 ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a19525.4f96.19762c3f163.Coremail.andyshrk@163.com \
    --to=andyshrk@163.com \
    --cc=andy.yan@rock-chips.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®