From: James Smart <james.smart@broadcom.com>
To: Daniel Wagner <dwagner@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH] scsi: lpfc: Move work items to a stack list
Date: Tue, 19 Nov 2019 09:25:54 -0800 [thread overview]
Message-ID: <4a1fedc9-03f1-7312-fd50-a041a78c0294@broadcom.com> (raw)
In-Reply-To: <20191119132854.mwkxx4fixjaoxv4w@beryllium.lan>
On 11/19/2019 5:28 AM, Daniel Wagner wrote:
> On Tue, Nov 12, 2019 at 10:15:00PM -0500, Martin K. Petersen wrote:
>>> While trying to understand what's going on in the Oops below I figured
>>> that it could be the result of the invalid pointer access. The patch
>>> still needs testing by our customer but indepent of this I think the
>>> patch fixes a real bug.
> I was able to reproduce the same stack trace with this patch
> applied... That is obviously bad. The good news, I have access to this
> machine, so maybe I able to figure out what's the root cause of this
> crash.
fyi - Dick and I were taking our time reviewing your patch as the major
concern we had with it was that the splice and then the re-add of the
work-list could have an abort complete before the IO, which could lead
to DC.
We'll look anew at your repro.
-- james
next prev parent reply other threads:[~2019-11-19 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 8:08 Daniel Wagner
2019-11-13 3:15 ` Martin K. Petersen
2019-11-19 13:28 ` Daniel Wagner
2019-11-19 13:32 ` Daniel Wagner
2019-11-19 17:25 ` James Smart [this message]
2019-11-19 18:14 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a1fedc9-03f1-7312-fd50-a041a78c0294@broadcom.com \
--to=james.smart@broadcom.com \
--cc=dick.kennedy@broadcom.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®