From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755018AbcHSBTT (ORCPT ); Thu, 18 Aug 2016 21:19:19 -0400 Received: from mail-sn1nam01on0065.outbound.protection.outlook.com ([104.47.32.65]:6016 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754016AbcHSBTP (ORCPT ); Thu, 18 Aug 2016 21:19:15 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PART2 PATCH v5 12/12] svm: Implements update_pi_irte hook to setup posted interrupt To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1469439131-11308-1-git-send-email-suravee.suthikulpanit@amd.com> <1469439131-11308-13-git-send-email-suravee.suthikulpanit@amd.com> <20160813120325.GH8001@potion> <20160816163329.GE12385@potion> CC: , , , , , From: Suravee Suthikulpanit Message-ID: <4a230960-6e69-a513-cd27-b2919903be2d@amd.com> Date: Thu, 18 Aug 2016 22:43:30 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160816163329.GE12385@potion> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [171.96.222.253] X-ClientProxiedBy: KL1PR02CA0066.apcprd02.prod.outlook.com (10.167.54.34) To MWHPR12MB1454.namprd12.prod.outlook.com (10.172.55.135) X-MS-Office365-Filtering-Correlation-Id: ca84f013-79e6-4b12-8407-08d3c77e5374 X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1454;2:EmczhYmX9zxovs++xKdILS7YuC/PSpFfFmh+cj4GkRATxIswY8WtlVwz6nn0B9XYVMDHEWlFVTf7CPhdyd7AcUEPHhZLxLFbrX4pNu3a3wvyIR3ROK3YDGxARnMcP+Yh7arRx0mKEgmRz/7SQgsrJ5pC8vu6AXJIBodESx40/zpsA+zU+XdlQT5o/hKqMCDE;3:kxIUddk+lvzL3PbAbkQGCDLcT3py0Coe2FoeObR1RvayJxy6TqZMmxx1UtipSIM6/2Ms0p2fmdjaR/t2odkeZhwLDDgaTpa0goFG12zeRyFqfosHIKhL/AXcL9Y0GbES;25:OsoUdnS4xDAuJF1r9ozjYtZnAAMLV9HuhMGzZuMWx3676eDzEDvh0AY9d19kLFZYGPtoo42nydjGERvGq3oI5v0a7CPmxg3xCKJRxoGhPjp9CxG/BiBHVTnOiooCI/NYOZQDq2TNBcBigUGet3eEIvqRh3AmarQUth/LosSjtn08WrhJDu6y97f6ax98nvFZ0pUGY4HT2aebwUJJxo06dGhtqHSL3o2HGicnlJ2PL9ZZqCknVqm7rGyKkgl/YbvrJbsHSNZ/JhIyiOKs8H0IEqa5v6TlfDcrH6j49Zu8WQQbzzJbe2a4SiUnR041zbTlr4zQ4Oi7sWBj518yKVx8wgBCxWNRKTNWNhdZE5u2yWQdSP3vUV9G8+ZZaYt1WPsqUGweuqiH4epekq/CPjRZeraoVEw9uMsuGWm/pT0pZuA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1454; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1454;31:x0MswqOdpZ3GHos0uuVYrTKPWtL/cJqEJQgiHxtDXwqjfZo80Q9zRQHuRLAj5ZrvS2lDRbBkJw5mtbcoxMD/LVJfkXl1FYng/FnPzKn+DFJmeINZZ+5kTG8aS3Ed5dZzWsxpqvuTAhWR1w/xm/RayTCKvFx/OGtCw4y0eNz+6U/VNKhjePBaUvRiY+p1acHU9xTnMl1Y+bCvmfyAeqBhX9ibWGXC1KbQ6k4o3tWQuT0=;20:/cGM2MGXAB+8fCWFNUw9fvmwGQ6HMFmIYoLPSqsJI1J012kleaKRh+yMsiOtg01ym3attOm5D+thaW34cb1E8UIqBjKEzbp/rzgk5t8lzFQDRJupL/F83slST2pQiTjUQiCK6RoTnrnCXJMvshoC4YZsZ6lHu7SOPsYrosJOVmrkhfjTdWgwcm5nzeZRb4IeZ3LKmu9piK7lfM+BGOHipU5U5QDLbSIjFCHvABaO1HMzxh0vRmFNZoO+umXH0z6NBwjhLxdoEYde790QKk7BuGkhQpnNgSWLrkq6iNyhAdQ5SkQ74VPTuelT8feeB4H/kNcOtdehZ8ZOsPU/OWBncyXjghibVJg5rC8SqNYjR90mEJ7G2yAd3oOhX5jaKw60gR3F9pK68JiJpJnfobkKt08Ac4OblqrX94OIPY6sdgnqKxpF4rcxBGoveAXLGsXesmXxdhtIqdBQqao3bKGzMIi0vTIFQiOno8Nqa+k8vMSiurW91kPp8/XSqdOvb1l/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:MWHPR12MB1454;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1454; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1454;4:341efF8Qg5TeFtF1+puYqObLXQVPxrTpUK8oZGVXaFKaL/G2ITJRQBbVdHvzzIoHKOcWrzJt1wIRlrjgoAA4hqavHpjUCcDQ0okKpxWJqbnOBJhrj+Y0ephTxKTQ6aqhrththkj2lbG4WKskjiuMSg3jjbAE0tFA2lbvA1hgX1XsLBc3ywavtYFEpniTLfwOcBQleQIsQR8Yw1pfirArRh34jNXieHqh6TP/RqTO4ltu7R/MIaE6erjJvTGDCZV4L+Buqqqz+kCo1pa9IvUz3pphkSomEk6ZirJZMePWsXzl41jFb28EZsaOrdLJKjuHLC8KEvuospN/GRj/Nj5JGEPpfX1agGkq4svBUCEwLGhtkAa1QQGDu1NX4/huLcFEWZa+RcqUBq5I8AJKJp19wA== X-Forefront-PRVS: 0038DE95A2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(24454002)(199003)(2870700001)(76176999)(31696002)(47776003)(65806001)(86362001)(36756003)(101416001)(83506001)(23676002)(105586002)(50466002)(7736002)(65956001)(64126003)(93886004)(3846002)(81156014)(6116002)(50986999)(7846002)(2906002)(68736007)(305945005)(586003)(66066001)(54356999)(77096005)(81166006)(2950100001)(8676002)(4001350100001)(4326007)(42186005)(110136002)(189998001)(92566002)(97736004)(33646002)(106356001)(31686004)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1454;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxNDU0OzIzOkRrV1NxbWY3VWRYZ2V5QWpybXJIWmI0TTVI?= =?utf-8?B?WWhDSFBSVDI3bWx3ZVRiMXF1T3gvSmhsZ3BENUw5Z2tHZUN2UkpYTWlBUjE5?= =?utf-8?B?R1lJd09EaUx6NVVEL242ZEpqRG90dW1scVJNd0xxY2gvelpmWUY5ZjA0WG5s?= =?utf-8?B?TFpRWDAxWDY1b1loRHRRd0ZFdjFqRzdlUXNmSy9mTmIxbmVrblVVZnR0clhl?= =?utf-8?B?MmVBRG9aV3pUL0VsTUhXOVZyRklKLzFOVEpxVEhLYTgwY1pQOFRHYjFuYzd6?= =?utf-8?B?YTd0MER5VmZZL2MyTXdDWUJxd3JrU0ZrWjFqY2pqMkZaK1FJVUZ3VGZPVDhM?= =?utf-8?B?KzF3M05nV29UU0lIMSttcnNRd3pRUE9zNFBWK0RwcXpFVFdXTXBSa1poYnlm?= =?utf-8?B?VnJWWFlZeVRyRTBJSlJSMkZDUGphT3VoZHVzMlJlazhQaE80NUpMeGRGUTVi?= =?utf-8?B?VWNDU0p2SnhjNDJNR25JdWw3SGJhVE1kR2FiWmNBc1NmVUZZUmt5VUdZMzZu?= =?utf-8?B?TFdST2lGV3Q4RDQwc01uZDJMRmtWYk1kb0x1MWV4U3VHMmR4VXFQV01DeTFD?= =?utf-8?B?MHgxaUZPWklPVVB6c1huaU1tZkQxNVZGM2hQSmFrSEx4dkVxQnREV3E0RjZG?= =?utf-8?B?MmNlYmFNczNWeWFCRDU2TDFTZGtjMHRkWlhOY0t6NkRKbTBQYkc5SFJYV1p1?= =?utf-8?B?NmdmMk1hVjNpM3Z4a1pLdVpMZ29MQ1BuckQwczlaYnJGaHNTeFYvT0lrNDZa?= =?utf-8?B?djdCczF3ck9jaVk0WEgvNnUyWktSaDdFY2MzUk9Qb1Z6Y3prazgrellqKy9i?= =?utf-8?B?UHJXdTdya0pzR1JUaCs4RUhOb1pSNTVodVVKaWdvdmRvZHI0Nk1XVmZ6aHJU?= =?utf-8?B?V2YwY25zdUV2SmNTTEplMjVkNk1FcjV5dGdWOFZNUmF6L1FUTHpDODN2K3Ro?= =?utf-8?B?eGpvNDFxc3lBSnI0am9heHlhbEJob3ZaSFFEOU1KR3F4dWpQa2NBZWxEOURP?= =?utf-8?B?aStkOUUvOTVJTlZoV2ZGMExTVE9WT1N5TDJ0dVBHcis2V3lwWmRRSWJFNUtt?= =?utf-8?B?WWNLTEZtajJjSmYvbHZtZG5KbzRLSmlRQ3l5NGx2KzhZd2R3cnQzcE1Fb2xk?= =?utf-8?B?aitrNThOQmVnVWFJRTV5ZVVLTk5ZRENqUzU1dHp2VHVVb3k2QVRzaWFMeTlI?= =?utf-8?B?N0RoK1B0aHYvdW1kVk9UcHhsdFZhdmlKZmh3ZDE2RFA3ZjNDZm5aZVpyYito?= =?utf-8?B?N2hiODZIOUgxSkNITjdyRXRjRjBkeFZwQmM5MUZ0cXhrOEJ0OGxSTEU0b2tI?= =?utf-8?B?RHZTaWM1MktGUE8yMkpNNkhUbGtOVWYyVTEwL0I1d3lyRVRVempmLzhxdnN1?= =?utf-8?B?Qmo2RTdPcVhTUkNtay8rY21TSTBWS05hcDNDdWp3Z2JZNmw2RmRiYUM5aGJU?= =?utf-8?B?VUNRb3dCcWpUb1BOWmMvYmVacTN3YmNXM3hCVEtWWFhkaWxnTEV0SEtBZHpR?= =?utf-8?B?L2JLZkZQeUZlTUYwS2J2bVJyc0xWd3lpTkkzQ1lqL1JTbm1qeHFlRTJZK1Np?= =?utf-8?Q?c7MGhnjGuCoD/gPzHpw6VthwAqmqRTvPHrTNG+leDp6w=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1454;6:VAIGX5KozOANkzGQShix9OqBdwUtk/g0u52I/dGaP0R1CShin1K72gJ9PkvY6Qw2yWGrLyfl5MOGj/j1r8efP+VE/Za9Nh1Q7dFZsvHHpnpFtVS7D6FhQmcR70+fOWrNv7G7hUQNSX5xCIbw0qPjgR2Nz4ObDhRA2vKeWVy5mq+Su2bZ5uWWUjmucB1uIBdWLyrBr75Lo/yTPlASAZxCsOzQZ6jJi8gFykF04oizn6+bqLOZ4GmZOR4BFtSvutWS5TpPz1iVO3WocUGOuEIqYLDAEX9dCv8LcKBmeKym+Bi3hQyyaH7bXhBtPS8HSon6PGGOMaDfLoYqnnPA4J/3Uw==;5:WTqpoch44i+75yPfEotpGFpV4LZ2B/ohvfJM9t3TZqMkdTZf2BeYsYJruoHeXjVJe0rtZKqN5j4+u+i06K3nFiM5a/oMJn4Ecqcj1Cd47MaOKYWRd37p5399/3lf+T2CrkrgCyarsEPOVDXLEX+jpg==;24:dm1uGO5LCVaVQN6SHUhxJ9RTMKGGQj0e2WVRgdF4K42KZ7/j+m1L7zeMgnjmzfP+K9VpsyXEn9chd6+lvh8C1mBi7RAy5Wghsq6utSjZqUg=;7:oHaSgzHobgK/wkS0eGRpzXWHfjEQN1tc9waB9R9TNfrCaXDAL+U6XW7KXEyouxBwUL6TP/F26ijbFewhavGLQB18NGrklwU9PN638I43mEE1UYtmHI/5EQXr3buz6xPtzX67EAY/Z3XVAB9PxtvkB+D/r+j3KjfOqTj4jBNgwc55BJR7dy89kov35T6ZzFZ5P4O64f42XDPWu0obiGa8axgVU82HRV13eUipbO9puVinrz394+4rZPeboqU0USmp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1454;20:41jm9c2LsKMvVbqo9kgfauXlthEPlCztCOjb4CF08NNFB/9nKi5tEComEi7m3jiXk5eCOrG2LiYNmZAseqjffeyuy8lyDTKAfFMOcv+PNfS0tZK2ZDOLbdcVtMa57kTdAIxjFQX4I5gAJJecyh1UrNer6Nr1jK+1+YMsqpsHQgriwiet6b7yMBZn1g5wxGuLuWyDQjIu6wIjAui9a7nRDDcanVO9upzaAfLKkZ0jv1dtIMVNpR/GMaCVFoQXLQ1C X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2016 15:42:54.6144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1454 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Radim, On 8/16/16 23:33, Radim Krčmář wrote: >>> Maybe I was a bit confused by reusing amd_iommu_pi_data when all we care >>> >> about is a list of cur->ir_data -- can't we have a list of just ir_data? >> > >> > Actually, in SVM, we care about posted-interrupt information, which is >> > generated from the SVM side, and stored in the amd_iommu_pi_data. This is >> > also communicated to IOMMU via the irq_set_vcpu_affinity(). >> > >> > Here, I only use ir_data to differentiate amd_iommu_pi_data. > I'm still confused then. :) > > struct amd_iommu_pi_data is a throwaway structure for I/O with > irq_set_vcpu_affinity(), but we keep it afterwards ... > is it more than a wrapper that allows us to put ir_data into a list, > because we don't want to add list_head directly to ir_data? Hm... I see you point now. I'll change it to ir_data list. Thanks, Suraveee