Re: [PATCH] drm/tiny: pixpaper: Fix missing dependency on DRM_GEM_SHMEM_HELPER

[Thomas Zimmermann <tzimmermann@suse.de>]

Am 22.09.25 um 04:57 schrieb LiangCheng Wang:
> The driver uses drm_gem_shmem_prime_import_no_map() and
> drm_gem_shmem_dumb_create(), but the Kconfig currently selects
> DRM_GEM_DMA_HELPER instead of DRM_GEM_SHMEM_HELPER. This causes
> link failures when DRM_GEM_SHMEM_HELPER is not enabled.
>
> Select DRM_GEM_SHMEM_HELPER to fix the build.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509220320.gfFZjmyg-lkp@intel.com/
> Fixes: c9e70639f591 ("drm: tiny: Add support for Mayqueen Pixpaper e-ink panel")
>
> Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
> This patch fixes a build failure in the Pixpaper DRM tiny driver caused by
> a missing dependency on DRM_GEM_SHMEM_HELPER. The driver calls
> drm_gem_shmem_prime_import_no_map() and drm_gem_shmem_dumb_create(), which
> require CONFIG_DRM_GEM_SHMEM_HELPER to be enabled.
>
> The issue was reported by the 0-day kernel test robot. This patch updates
> the Kconfig to select DRM_GEM_SHMEM_HELPER instead of DRM_GEM_DMA_HELPER.
> ---
>   drivers/gpu/drm/tiny/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
> index 94a5bf61a115929640022128e20c723ab7c0e735..7d9e85e932d7fd7bdb6ad7a4c6ba0f835841f623 100644
> --- a/drivers/gpu/drm/tiny/Kconfig
> +++ b/drivers/gpu/drm/tiny/Kconfig
> @@ -86,7 +86,7 @@ config DRM_PIXPAPER
>           tristate "DRM support for PIXPAPER display panels"
>           depends on DRM && SPI
>           select DRM_CLIENT_SELECTION
> -        select DRM_GEM_DMA_HELPER
> +        select DRM_GEM_SHMEM_HELPER
>           select DRM_KMS_HELPER
>           help
>   	  DRM driver for the Mayqueen Pixpaper e-ink display panel.
>
> ---
> base-commit: 846bd2225ec3cfa8be046655e02b9457ed41973e
> change-id: 20250922-bar-cd1f3e834e78
>
> Best regards,

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)