From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C90FC4360C for ; Thu, 26 Sep 2019 20:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BDB7222C2 for ; Thu, 26 Sep 2019 20:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728733AbfIZUQW (ORCPT ); Thu, 26 Sep 2019 16:16:22 -0400 Received: from foss.arm.com ([217.140.110.172]:58960 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727889AbfIZUQW (ORCPT ); Thu, 26 Sep 2019 16:16:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D2B9142F; Thu, 26 Sep 2019 13:16:21 -0700 (PDT) Received: from [172.23.27.158] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 877923F67D; Thu, 26 Sep 2019 13:16:18 -0700 (PDT) Subject: Re: [PATCH 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC To: Catalin Marinas Cc: ard.biesheuvel@linaro.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org References: <20190920142738.qlsjwguc6bpnez63@willie-the-truck> <20190926060353.54894-1-vincenzo.frascino@arm.com> <20190926060353.54894-2-vincenzo.frascino@arm.com> <20190926080616.GB26802@iMac.local> <0ff3d5f4-11c9-4207-c6ab-2f8e9ee7de5e@arm.com> <20190926151704.GH9689@arrakis.emea.arm.com> From: Vincenzo Frascino Message-ID: <4a25b76b-0d17-778d-aff5-88f8fbae2819@arm.com> Date: Thu, 26 Sep 2019 21:17:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190926151704.GH9689@arrakis.emea.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/26/19 4:17 PM, Catalin Marinas wrote: > On Thu, Sep 26, 2019 at 01:22:01PM +0100, Vincenzo Frascino wrote: >> On 9/26/19 11:56 AM, Vincenzo Frascino wrote: >>> On 9/26/19 9:06 AM, Catalin Marinas wrote: >>>> Now, could we not generate a COMPATCC in the Makefile and use >>>> $(COMPATCC) here instead of $(CROSS_COMPILE_COMPAT)gcc? It really >>>> doesn't make sense to check that gcc is gcc. >>>> >>> >>> All right, COMPATCC is already in the makefile, I will use it in here. >> >> What you are proposing seems not possible because Kconfig runs first and then >> the arch Makefile, hence compatcc does not take effect on the Kconfig. I will >> post v2 with what I proposed, please feel free to comment if you have a better idea. > > I think it works as long as you export COMPATCC from the > arch/arm64/Makefile. The arch Makefile is used in the config step > AFAICT. See the diff I posted in my reply to your v2. > All right I will retry and repost v3 if I can get it working. -- Regards, Vincenzo