From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09F272E8B86 for ; Mon, 29 Sep 2025 10:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759140692; cv=none; b=KD3O9OePBAnsN0Swy8LAwticrPpa5l9em+7uovdwL7oi6nEcvpn2gINxXqXFXbFnoE/KEmE8Pca6isqr4Pkkdrjl3XUybf+GZG4yWVgRSEzkdrJLMnuMuHtH2RjgmT7d1N8WZqVN/wpFrzlGXtcxb8aT92osFqNwtcbL7bLTWL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759140692; c=relaxed/simple; bh=SNlPsVtVvLE+7Qc32BXbo+x7QO7oxtlaKyVIWZUYfdY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N2h+dD9nneoZ8yhujCsiLgnDv5+J6ftyp+kEMvenCUGmPZiQXEphL9rv+FSpAjL8P8b2Pu1sFDepK9xDhzd/cSPAIEQUtCCtdD6aPr+QU1oaWM66dvhG4Ry/Fqa8oTM8Dryzu5Jioc9k4HnijPjnkRvvwv5p/UM16t3B2I4ZWu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qi0UgehH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qi0UgehH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58T9ut6x032263 for ; Mon, 29 Sep 2025 10:11:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KAy6TsCY0/+8cRPvCOBR5q3OazEKN7PJw0wUDI9VBI8=; b=Qi0UgehHpBKMgFxZ nSMXe6dms8moOAvkBuo0I0/Ac760RPu2rluzEcx/+aRUAl3P+HEHRRlLZVayG2iw iXyXeKqXKJBok+hJu8IY3PvUvZp/buUpj8mfGO4P0uLUTm02u6QTxF9NGyCkt6Xx jgpasyBuVF2R755vHCaEi4qp/FGUhU2rZeDvmoDz1w8UPA1IQ7jIj15nCgMmiP3K /ZHISxC0WF7izjocTox0ROdnUakxLEZWKyhG2Y8XdZQXZH56dwkINon7fEgUUMJ/ GpQZb7SmHC7FtajVB+i816WLE89GEgYcOiBuMUNK2fhpXpNZJQRZKd/60b+3BRo6 PZV3gg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e59mw4d3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 29 Sep 2025 10:11:29 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b4f93fe3831so6159563a12.0 for ; Mon, 29 Sep 2025 03:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759140688; x=1759745488; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KAy6TsCY0/+8cRPvCOBR5q3OazEKN7PJw0wUDI9VBI8=; b=q5igkRrD29wGSsJEm5cwRZLI9IO3TmBx5TY2Fg87c9j21s+jxq7MSDfFFVtl7Fv5Nl neJ50qtl8/UlG/prOW3Yvv26huxnPME6fDTn0PJvXZY9T2ec//HYlhA1ThNf2NzNWwtD MOYHvttnz/YHcPuBgmJcQgtt/EEOWD6J5F5zophaqKHVnrUlQFvNxe38JB2AyZzsr9Yj i+F8stl97HkCkn0Kcl9nRx4r7pfXS6JTxQxk6HWvPPok59UxzxpAXVWoPdmfczu4a4wI DEi54zbd6m3x5o8axUvPAPjsNHGdHBkapz8yO8duqzNynYrB0cGI2dctC1p5gezHDjPf 5PRg== X-Forwarded-Encrypted: i=1; AJvYcCVOjIq2uuywrb9QVDJAcsvINPwTPre5DNcq6NDABVON/WUC6G5EiLEtI7VNXKeohoxnXvV7caV1Epziueo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq+I3inUYJ4ncumROPjZR3zNW/kZrleVfuEUvg2F7KYjgymSVS 8rmc8hASbv61qe/FvaBeDLIXsKGIPG8o9OhaxYoAL6EjUchCp0u4Fis9A+wnaImwQ0H3zeWuUYy Kwv3r9ZFJHd1UvPQHANqHFZaUXcNSAS1RqVxaZf+nnqLu5XcbtAVNUapgRPf8jdRzkzA= X-Gm-Gg: ASbGncsuYcUOiKW+jkLyM8b2+3LZm5YNH5esAQAw+EBmCM2RFUE4XB0EZTp/mr44IP5 7KIELviuP42PVB2TWGYa7WjW1pxKcXKz4UYqhR+I2Ha/m5fRgPaEu0V9FRwst+ZpLVVKElwqko4 ptpd6JvdQE64+9KIuX5u3pEX2wD0jMRxnXwIXLQ74hsPdCrcXnjduZES3YNMFN722bXG1y3hGy+ 0Jyw2rwRVXqK+EULuBGMEYDAPwl7eB4YQ89UjZa2UB2IMWF2KOgJ5881x6JqQo7ze1LuC3tfrEX YfQJ1V3J0C3UntpyjupZvzNjAhxp5gwKH6myy8rp6ZQll9pIR79DS6MmhfvJpLw5/wpho9i0Iqt 5P33q/X+JMesorlub3oj4aH1Mu8Qx98pJACU= X-Received: by 2002:a05:6a20:9192:b0:2bf:183c:aca3 with SMTP id adf61e73a8af0-2e7c1eb1322mr19674182637.12.1759140688482; Mon, 29 Sep 2025 03:11:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzemKX0SD6GSKVWhUTVYl9RL2yj6+ykC20lMCtAy+GTBdDXQQON7rWIJ2aTOuGZH74HCqu5Q== X-Received: by 2002:a05:6a20:9192:b0:2bf:183c:aca3 with SMTP id adf61e73a8af0-2e7c1eb1322mr19674138637.12.1759140688000; Mon, 29 Sep 2025 03:11:28 -0700 (PDT) Received: from [10.133.33.234] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b57c52eee5fsm11103220a12.0.2025.09.29.03.11.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Sep 2025 03:11:27 -0700 (PDT) Message-ID: <4a25e085-39f8-49dc-85c6-7a4267689dd1@oss.qualcomm.com> Date: Mon, 29 Sep 2025 18:11:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP To: Dmitry Baryshkov Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-remoteproc-v1-0-611bf7be8329@oss.qualcomm.com> <20250924-knp-remoteproc-v1-1-611bf7be8329@oss.qualcomm.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: zCasYa24Ivup_Jr019J515O2L8U_ti-5 X-Authority-Analysis: v=2.4 cv=O4g0fR9W c=1 sm=1 tr=0 ts=68da5b51 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=dVhWkjGdtg-RV6iV_LsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: zCasYa24Ivup_Jr019J515O2L8U_ti-5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAwMSBTYWx0ZWRfX4WtEvnf8Ouu4 QVBKJ9KmCgbmmwesfHqteh+GHfHnRAflFKvKumeWY+ZtEFGx88XkNHUN4HeujZjwoCaJxLgddIl gVfJLzTeyPFr44BM3lpJIZncJK6NzSUTINe4OUqZ3avfwO3T8v3CVu9EwwOy1h+0dKqhSFXWj24 ChBzhJe2mhfSfhVQ5CCLq1dTSjeaVwUgreDWCRvDJzDaVsGIlGsjIPeSIQftikawDxOevJdyYfi SNPYDdlEYjAOP+c2SDl0awPgEAd6ZeJ2oqKhxdH7Xr0Ntop9oIHRO09MJLpoJ8+ck+hT95cZ+nQ Ci66Sy/DnxXn4ZSw0aObVJ73hc1J3Eqh5GTs6ou2ujhH0/u1o1E7egyFG1W60k9fdABHL1+CjJm nAg/oRNl0ckWnP0q7mQ2xQMSAstODw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-29_04,2025-09-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270001 On 9/29/2025 5:39 PM, Dmitry Baryshkov wrote: > On Mon, Sep 29, 2025 at 02:06:11PM +0800, Jingyi Wang wrote: >> >> >> On 9/25/2025 10:19 AM, Dmitry Baryshkov wrote: >>> On Wed, Sep 24, 2025 at 04:37:22PM -0700, Jingyi Wang wrote: >>>> Document compatible for Qualcomm Kaanapali SoC ADSP PAS which looks fully >>>> compatible with SM8750, which can fallback to SM8550 except for one more >>>> interrupt ("shutdown-ack"). >>>> >>>> Signed-off-by: Jingyi Wang >>>> --- >>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>> index 2dd479cf4821..be9e2a0bc060 100644 >>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>> @@ -28,7 +28,9 @@ properties: >>>> - qcom,x1e80100-adsp-pas >>>> - qcom,x1e80100-cdsp-pas >>>> - items: >>>> - - const: qcom,sm8750-adsp-pas >>>> + - enum: >>>> + - qcom,kaanapali-adsp-pas >>>> + - qcom,sm8750-adsp-pas >>>> - const: qcom,sm8550-adsp-pas >>>> - items: >>>> - const: qcom,sm8750-cdsp-pas >>>> @@ -95,6 +97,7 @@ allOf: >>>> compatible: >>>> contains: >>>> enum: >>>> + - qcom,kaanapali-adsp-pas >>> >>> This one and the next entry are redundant. Do you see why? >>> >> >> This one describe the interrupt: >> >> - if: >> properties: >> compatible: >> contains: > >> enum: >> - qcom,kaanapali-adsp-pas >> - qcom,sm8750-adsp-pas > > It's still redundant. Don't you see it? > sorry I didn't get your point here, could you explain more? >> then: >> properties: >> interrupts: >> maxItems: 6 >> interrupt-names: >> maxItems: 6 >> memory-region: >> maxItems: 2 >> >> >>>> - qcom,sm8750-adsp-pas >>>> then: >>>> properties: >>>> @@ -185,6 +188,7 @@ allOf: >>>> compatible: >>>> contains: >>>> enum: >>>> + - qcom,kaanapali-adsp-pas >> >> This one describe the power domain >> >> - if: >> properties: >> compatible: >> contains: >> enum: >> - qcom,kaanapali-adsp-pas >> - qcom,sm8550-adsp-pas >> - qcom,sm8650-adsp-pas >> - qcom,sm8750-adsp-pas >> - qcom,x1e80100-adsp-pas > > Likewise > indeed, here is redundant as "qcom,sm8550-adsp-pas" is added in the dts. I will remove this. Thanks, Jingyi >> then: >> properties: >> power-domains: >> items: >> - description: LCX power domain >> - description: LMX power domain >> power-domain-names: >> items: >> - const: lcx >> - const: lmx >> >> >>>> - qcom,sm8550-adsp-pas >>>> - qcom,sm8650-adsp-pas >>>> - qcom,sm8750-adsp-pas >>>> >>>> -- >>>> 2.25.1 >>>> >>> >> >> Thanks, >> Jingyi >