From: Shawn Lin <shawn.lin@rock-chips.com>
To: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org
Cc: shawn.lin@rock-chips.com,
Christian Zigotzky <chzigotzky@xenosoft.de>,
Manivannan Sadhasivam <mani@kernel.org>,
mad skateman <madskateman@gmail.com>,
"R . T . Dickinson" <rtd2@xtra.co.nz>,
Darren Stevens <darren@stevens-zone.net>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Lukas Wunner <lukas@wunner.de>,
luigi burdo <intermediadc@hotmail.com>, Al <al@datazap.net>,
Roland <rol7and@gmx.com>, Hongxing Zhu <hongxing.zhu@nxp.com>,
hypexed@yahoo.com.au, linuxppc-dev@lists.ozlabs.org,
debian-powerpc@lists.debian.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v2 0/4] PCI/ASPM: Allow quirks to avoid L0s and L1
Date: Tue, 11 Nov 2025 09:33:52 +0800 [thread overview]
Message-ID: <4a2a4203-3eb0-4eab-a06e-ce5c6bf18ff4@rock-chips.com> (raw)
In-Reply-To: <20251110222929.2140564-1-helgaas@kernel.org>
在 2025/11/11 星期二 6:22, Bjorn Helgaas 写道:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> We enabled ASPM too aggressively in v6.18-rc1. f3ac2ff14834 ("PCI/ASPM:
> Enable all ClockPM and ASPM states for devicetree platforms") enabled ASPM
> L0s, L1, and (if advertised) L1 PM Substates.
>
> df5192d9bb0e ("PCI/ASPM: Enable only L0s and L1 for devicetree platforms")
> (v6.18-rc3) backed off and omitted Clock PM and L1 Substates because we
> don't have good infrastructure to discover CLKREQ# support, and L1
> Substates may require device-specific configuration.
>
> L0s and L1 are generically discoverable and should not require
> device-specific support, but some devices advertise them even though they
> don't work correctly. This series is a way to add quirks avoid L0s and L1
> in this case.
>
Tested-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> Bjorn Helgaas (4):
> PCI/ASPM: Cache L0s/L1 Supported so advertised link states can be
> overridden
> PCI/ASPM: Add pcie_aspm_remove_cap() to override advertised link
> states
> PCI/ASPM: Convert quirks to override advertised link states
> PCI/ASPM: Avoid L0s and L1 on Freescale Root Ports
>
> drivers/pci/pci.h | 2 ++
> drivers/pci/pcie/aspm.c | 25 +++++++++++++++++--------
> drivers/pci/probe.c | 7 +++++++
> drivers/pci/quirks.c | 38 +++++++++++++++++++-------------------
> include/linux/pci.h | 2 ++
> 5 files changed, 47 insertions(+), 27 deletions(-)
>
next prev parent reply other threads:[~2025-11-11 1:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 22:22 Bjorn Helgaas
2025-11-10 22:22 ` [PATCH v2 1/4] PCI/ASPM: Cache L0s/L1 Supported so advertised link states can be overridden Bjorn Helgaas
2025-11-10 22:22 ` [PATCH v2 2/4] PCI/ASPM: Add pcie_aspm_remove_cap() to override advertised link states Bjorn Helgaas
2025-11-12 17:27 ` Manivannan Sadhasivam
2025-11-12 20:46 ` Bjorn Helgaas
2025-11-13 4:02 ` Maciej W. Rozycki
2025-11-10 22:22 ` [PATCH v2 3/4] PCI/ASPM: Convert quirks " Bjorn Helgaas
2025-11-10 22:22 ` [PATCH v2 4/4] PCI/ASPM: Avoid L0s and L1 on Freescale Root Ports Bjorn Helgaas
2025-11-11 1:33 ` Shawn Lin [this message]
2025-11-11 9:33 ` [PATCH v2 0/4] PCI/ASPM: Allow quirks to avoid L0s and L1 Lukas Wunner
2025-11-11 15:44 ` Bjorn Helgaas
2025-11-12 14:40 ` Lukas Wunner
2025-11-11 17:11 ` Bjorn Helgaas
2025-11-12 11:15 ` Roland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a2a4203-3eb0-4eab-a06e-ce5c6bf18ff4@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=al@datazap.net \
--cc=bhelgaas@google.com \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=debian-powerpc@lists.debian.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=hypexed@yahoo.com.au \
--cc=intermediadc@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=madskateman@gmail.com \
--cc=mani@kernel.org \
--cc=rol7and@gmx.com \
--cc=rtd2@xtra.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®