From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9646E2EDD7E for ; Wed, 3 Dec 2025 10:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759203; cv=none; b=pemVmoWgnJG5+mKdPc5ZWwemTl3j1KlWKbewPt2M4F+ctc2Tq3ux2kezAR3sNzdjeWCw7rltaSb4AKvE3zAr7x5AGb9c+3KuwGZwNAr4jbY2sGVIam+aZY5X4GqpPFzt7fYadHErFsPJJ0SCyMwHQrVNqekyiVMt2tvU1rrEfQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759203; c=relaxed/simple; bh=sX/FMluP7cm6oBzkdDmIBYZducN6JLY0n6VDOz8piAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bB8b/q1/fzyLhKGumqCHtGOLKg7mZ93HIaHd3fWxvw7wyBvKgccn8cbUX2pEw9dcy8wHNSImMS2GWcOiTzjp4jXOYncKz6x28eYrCtljopN1PM6f4MZCxEbM3ajSpqp4ERGQkNLL+u4BekFkv3E/AgybQNk2C+Qg7m6yOEjZMCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=giPtAnlu; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="giPtAnlu" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-29ba9249e9dso73366835ad.3 for ; Wed, 03 Dec 2025 02:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764759201; x=1765364001; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TvuDz+LB2nlmtHgXkSOi62X+EzFaBu+241NUXS5oP38=; b=giPtAnlujke9+rOyvzP6uUYPBywlcR++M3a/aQRxe8Df1/331UK25L/LWmcqMEfdP+ py0834u8Wimx0jQu8GbdXuw6sx8lcRzb+Jzuv/R0IQ3bajUnFtdFjKWBwSyEPTIY+mMe bSdsckF5O4051VdXbCXrg81lQPdI+TcW7rJqFFROpsyh6XSShml1dojpRiakqUiqKVhV k6DeMhRWodqkM/1oJzDi/mUEELh54KzGqw3DLks7EeCgzFLgQGhIXGhXzOPiJfk1u66K JWgAid0j14S64OgE3n2eWx0NI1GJqmPPjmmyGzIhniHpDU4wTEc6sY0Bxm/+9bxuzOMp AtMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764759201; x=1765364001; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TvuDz+LB2nlmtHgXkSOi62X+EzFaBu+241NUXS5oP38=; b=jqRCzgdPfvN3qR94SrUZfrxMB/jntLn2ZuEp3UlyOV/qFySnIz9MaoJ089kka0KYAk WZlxbjXVI5p0X3gPlppKtfBAWTuvXVKwyEKw6GLdCaRIbNlVnHTY/MITr37W4XhVPSz8 v9W7Vkj8z//oKKa2GCQn5orI7Bw+x6FDl1iML2ro/+N508w1r+xskrjqA7AAINxiMQ8Z k3BtBkuah1kqc9j2qbHsETjPxUsSZO0kc+QH5Gl7gQUgpmQaEkMtHN16DPvct8pa7j8H +Cp0CFgD/g5PyoaaPXFnOztTAM4dmDfWFPhZ7Cutwxwah2r5F0hlwjMmzJ/KePtF6COS lQGw== X-Forwarded-Encrypted: i=1; AJvYcCXdpQORWb42M6Zn8sBdxcRV0n31l0Nx7P42lQHfoUSKnQWgKzykh3L2o3EmYaCtnV7s34sONVfq8YQzxiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+uSvMCbCRkVRS/Zx+f0TAtLaBWKR+TQfV7C0ZWiRHB9xWmbzz RXnXC/kKIgXBTkp1kd1TNHcLZxA1yKLwhHSDvJnQmkwEu2UpA9go9UXIEjAYqoaGAeM= X-Gm-Gg: ASbGncsCmP5DJVIhyVR25pYWTnRxenVEpK6Nx9ozeEvap4yzYF11RpAWW4DaM0zE3ia VZcrEa+vFG6uwwl2PAEFPlrjdX78QtuwCo/KDoHZ3m7cY/YAgf5OCZyJnD1MMWD4RGmMGYiTK61 jbZW7U65Yz1JauoGlAn6KPB1jhXITiIrjnvMbcDqsftXceFGKFUhAJIikXYtnuJ81oSweLquhXt U5InS1puVwQoWDEhu8srk0EfubkjE8jSJfu8JdhrcnvqBN6EB3v0o9gg19Gccd116hTaRbdstDm W5Yya5XghQj06c1tOUGVXNj463rKa6yh4uqGDYIsp4qEpXw9J8MdtdR66GVjMFJ2OfJ9NUuJxH1 bTrmtmy6LNmpD/wnyu8WmjoS5Wx0zeKKNkg+IIEF6p6jlo4y+pyUZQNMg8JT1qHbnB9/ShGTUlu BPcGu+km5ZWWEyUf4ZXTtR8LS8f6jJCh08cQLQEQJiS9spLdNfL1H5b5GzalcMdW4OEcQ= X-Google-Smtp-Source: AGHT+IFu6rDs1WjAmEfM15hO6wuMabAqzc9FQplLGsJzz8ObkXxSQU6urKus59RzMtiQQPcdUfnxfQ== X-Received: by 2002:a17:903:3550:b0:295:5945:2920 with SMTP id d9443c01a7336-29d684013b2mr22438785ad.34.1764759200806; Wed, 03 Dec 2025 02:53:20 -0800 (PST) Received: from [10.131.179.186] (zz20234032476F6CA7C6.userreverse.dion.ne.jp. [111.108.167.198]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce40b993sm186012355ad.14.2025.12.03.02.53.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 02:53:20 -0800 (PST) Message-ID: <4a2f44d1-e81c-48e8-a8ba-1ed66bfde7b8@gmail.com> Date: Wed, 3 Dec 2025 19:53:17 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Add support to detect hardware damage detection capability. To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Hans de Goede , platform-driver-x86@vger.kernel.org, LKML , njoshi1@lenovo.com, Mark Pearson References: <20251203034032.6018-1-nitjoshi@gmail.com> <22f766d6-9010-3e87-f05b-bfd9b5888881@linux.intel.com> <2f94f4bb-c0e5-40c0-9cf3-7ba31fefbc2b@gmail.com> Content-Language: en-US From: Nitin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/3/25 19:39, Ilpo Järvinen wrote: > On Wed, 3 Dec 2025, Nitin wrote: > >> Hi Ilpo, >> >> Thank you for reviewing the patch. >> >> On 12/3/25 18:44, Ilpo Järvinen wrote: >>> On Wed, 3 Dec 2025, Nitin Joshi wrote: >>> >>>> Thinkpads are adding the ability to detect and report hardware damage >>>> status. Add new sysfs interface to identify the impacted component >>>> with status. >>>> Initial support is available for the USB-C replaceable connector. >>>> >>>> Reviewed-by: Mark Pearson >>>> Signed-off-by: Nitin Joshi >>>> --- >>>> .../admin-guide/laptops/thinkpad-acpi.rst | 26 +++ >>>> drivers/platform/x86/lenovo/thinkpad_acpi.c | 179 ++++++++++++++++++ >>>> 2 files changed, 205 insertions(+) >>>> >>>> diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst >>>> b/Documentation/admin-guide/laptops/thinkpad-acpi.rst >>>> index 4ab0fef7d440..4a3220529489 100644 >>>> --- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst >>>> +++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst >>>> @@ -54,6 +54,7 @@ detailed description): >>>> - Setting keyboard language >>>> - WWAN Antenna type >>>> - Auxmac >>>> + - Hardware damage detection capability >>>> A compatibility table by model and feature is maintained on the web >>>> site, http://ibm-acpi.sf.net/. I appreciate any success or failure >>>> @@ -1576,6 +1577,31 @@ percentage level, above which charging will stop. >>>> The exact semantics of the attributes may be found in >>>> Documentation/ABI/testing/sysfs-class-power. >>>> +Hardware damage detection capability >>>> +----------------- >>>> + >>>> +sysfs attributes: hwdd_status >>>> + >>>> +Thinkpads are adding the ability to detect and report hardware damage. >>>> +Add new sysfs interface to identify the impacted component. >>>> +Initial support is available for the USB-C replaceable connector. >>>> + >>>> +The available commands are:: >>>> + >>>> + cat /sys/devices/platform/thinkpad_acpi/hwdd_status >>>> + >>>> +This value displays device type and location of device with damage >>>> status. >>>> +For example: >>>> +if no damage is detected: >>>> + No damage detected >>>> +if damage detected: >>>> + Damage detected: >>>> + Device: TYPE-C >>>> + Location: Base, Right side, Center port >>>> + >>>> +The property is read-only. If feature is not supported then sysfs >>>> +class is not created. >>>> + >>>> Multiple Commands, Module Parameters >>>> ------------------------------------ >>>> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c >>>> b/drivers/platform/x86/lenovo/thinkpad_acpi.c >>>> index cc19fe520ea9..c3629bed9a8e 100644 >>>> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c >>>> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c >>>> @@ -11080,6 +11080,180 @@ static const struct attribute_group >>>> auxmac_attr_group = { >>>> .attrs = auxmac_attributes, >>>> }; >>>> +/************************************************************************* >>>> + * HWDD subdriver, for the Lenovo Hardware Damage Detection feature. >>>> + */ >>>> + >>>> +#define HWDD_GET_DMG_USBC 0x80000001 >>>> +#define HWDD_GET_CAP 0 >>>> +#define HWDD_NOT_SUPPORTED BIT(31) >>>> +#define HWDD_SUPPORT_USBC BIT(0) >>> Align values. >> Ack, i will align values like below: >> >> #define HWDD_GET_CAP 0 >> #define HWDD_GET_DMG_USBC 0x80000001 >> #define HWDD_SUPPORT_USBC BIT(0) >> #define HWDD_NOT_SUPPORTED BIT(31) > These are not aligned as values starts from different columns. Please > put a tab char there in between so the values start at the same column (or > varying number of tabs depending on the length of the name). > > There are plenty of good examples in the code, including in this file > you're modifying. Ack, i will modify it . Thank you ! >