From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C00761E5B7A for ; Sun, 28 Dec 2025 19:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766949290; cv=none; b=Zyj+8ctHD+vIY8vyEz03kjLEleK7iXGpBCmgqx9aSwMw+6j2JQGfkaaai8VCEPbvutO6c87sucj8nHnimaqzdIWBnZg51ebiH3wq+MiK42/meJ/OvP54Zy4hoLZHZlB6OnFXIhgDT39R99RZBMpiLzjNMbGGCMnnC5/owSifZnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766949290; c=relaxed/simple; bh=Teue05T2vtyfM6JbLM9Wx4ESn3eOITo3NXRewvGunxs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mt0XfyPucjzperKy4TXYhc8KIQP68VhJPQgsBjbZsFxBUxiX/I1Cvsk25E9JaUjQDlW1Z+2LtWL7gCrT3y+iD+ODxBwGFiV9t1vOzhtigPyyH+yeqZug04/I8gKZDk+O8rJTLxDWHhYitmjxOjCdXwZXy2WNdphEerZDs5UCixU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gMWvp45C; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gMWvp45C" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7aae5f2633dso8559259b3a.3 for ; Sun, 28 Dec 2025 11:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766949288; x=1767554088; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=2/EDnVTKqc9Alw2a85WyLludgkhnt57ScPSQHXR/F+0=; b=gMWvp45C/g8JDsZwyJhN/5klNPtlBizoLI/gwPBaG3HekiJSXaXsscTbOcn+sYy8F8 SktZZg3QA8AqxbKhWtIZruC5MfPRocHD0wYU0XPNwT1Gw7V7L7Tg3yybk2/gviiFz8mR Mkzt5yBVVwuykLX4wMJOcNFogwciE1PL4Wsqo5AjBpJN/pMStUPYmEUeYezzDroteu9Z de975pU+0suLKkt/z+JJJahk1OmeDiV7sFDOfcvHGLtINH4w+pWqbPAQ15bGG9QCiqmV 9vQ8y8mptvamg2HdF/ZrLOmPkna/Pk2TJ3AeSn7SaEvtUBeIdgh1Wzhn9S6hi3XVXygL jrZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766949288; x=1767554088; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2/EDnVTKqc9Alw2a85WyLludgkhnt57ScPSQHXR/F+0=; b=UH5rTJJftvmKa5T3yVfe9oqAkPNSLcFdO4eN3rIoJra1zVjEUvp7vuD1IYD1Lew1gU A+do10d7u7Qq0mxGVArw8cGjwVpCagqPBq1sMYk9S4N5tJ91fjnhLSUe28cdeZwVRRjM RSQNuB3qxEsalIxejtsCLH4SkOWMU5KF5rSjonv26EymUvbjdZxdkxBPRY9a1/0ZY/Zp lxysdA10hJ3EY1aU1S4kJDZBj2AaU5RXEanOkFHsvblCDJbfuENgZuUwzPqgrB13tqbW CATepq8QBh3ti0C7ATBViLdcf8OswvekMdy6zjNqUEY0TUO5LXra1d7Dms5WeuuBOTKQ ERLg== X-Forwarded-Encrypted: i=1; AJvYcCUtX7hlAQNIZ3cAA4taMzWCrQZngUS8r5atcRhp/14iAJKwyVK0Jmf0KaWahBIgEGm2l56PRqPSxBKbdQc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj42sqkWgkNHDAkwjz1HnGdw2Jhh1IYXpRsTLyM/ys9ThR36Wt DLZgzsCJrHGCnpW1e1kBNlQu3xw7xdz7tBLDF2nofp581Khh7QJJcx/H X-Gm-Gg: AY/fxX6mdQl7eNLFgDebGYXReYqulHHFoMCh6H0jvfAxIvfe2cr9hQn/Gggt9i53J2o /JnfyuPMpL939lSj/Etj/loku6S9xxWGQIeefaw2LexAe/vfEX3HsPUaaN9Kx8R77UG8YVdQEXY yjxpMRMen2pbDU9G2G3H824djWYVLeic7QjFz3VdPsYeSiRRUccq3MCGxghy8A8fUhtc4NAO0OH LiuQrCGhe4YwAHhNgYsaI2fp9T6VIt+yVzogRwPGRRyPMrMhWY5whHdZCRKAzR+p6MVRQfA+0ki giqaDapkOrim2PuyMXP/UIsgZKlbaOuNAnNxL7HtuSH15m8usqiaEt0ycDQ8IslniTSJRzuIPJy WBg8aj/7hF0Uie9IUo0XPgQm+E8mfG0eD5Tf1FPlJGQ4TCgitr5MTJg16FRUBYb3zRkfcxjllMO 9ln/ZJSe4LGQvp9bGh6K8cnIWL X-Google-Smtp-Source: AGHT+IF25KeLOl7jzXHpJk6dyM7oMA5PYF/NEBQktiKPuJGfWtsQgLBOA+8b4PoMCuZ7U2cZUKzoug== X-Received: by 2002:a05:7022:e98d:b0:11e:3e9:3e8b with SMTP id a92af1059eb24-12172312a4fmr27428339c88.50.1766949287821; Sun, 28 Dec 2025 11:14:47 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724dd7f5sm109599250c88.5.2025.12.28.11.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 11:14:47 -0800 (PST) Sender: Guenter Roeck Date: Sun, 28 Dec 2025 11:14:45 -0800 From: Guenter Roeck To: "Rafael J. Wysocki" Cc: Linux PM , LKML , Ulf Hansson , Brian Norris , Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH v1 08/23] watchdog: rz: Discard pm_runtime_put() return values Message-ID: <4a2fc1a6-343c-4fc3-ab5e-7c134216aa22@roeck-us.net> References: <6245770.lOV4Wx5bFT@rafael.j.wysocki> <3340071.5fSG56mABF@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3340071.5fSG56mABF@rafael.j.wysocki> On Mon, Dec 22, 2025 at 09:07:46PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Failing a watchdog stop due to pm_runtime_put() returning a negative > value is not particularly useful. > > Returning an error code from pm_runtime_put() merely means that it has > not queued up a work item to check whether or not the device can be > suspended and there are many perfectly valid situations in which that > can happen, like after writing "on" to the devices' runtime PM "control" > attribute in sysfs for one example. It also happens when the kernel is > configured with CONFIG_PM unset. > > Accordingly, update rzg2l_wdt_stop() and rzv2h_wdt_stop() to simply > discard the return value of pm_runtime_put(). > > This will facilitate a planned change of the pm_runtime_put() return > type to void in the future. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Guenter Roeck > --- > > This patch is part of a series, but it doesn't depend on anything else > in that series. The last patch in the series depends on it. > > It can be applied by itself and if you decide to do so, please let me > know. > > Otherwise, an ACK or equivalent will be appreciated, but also the lack > of specific criticism will be eventually regarded as consent. > > --- > drivers/watchdog/rzg2l_wdt.c | 4 +--- > drivers/watchdog/rzv2h_wdt.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > --- a/drivers/watchdog/rzg2l_wdt.c > +++ b/drivers/watchdog/rzg2l_wdt.c > @@ -132,9 +132,7 @@ static int rzg2l_wdt_stop(struct watchdo > if (ret) > return ret; > > - ret = pm_runtime_put(wdev->parent); > - if (ret < 0) > - return ret; > + pm_runtime_put(wdev->parent); > > return 0; > } > --- a/drivers/watchdog/rzv2h_wdt.c > +++ b/drivers/watchdog/rzv2h_wdt.c > @@ -174,9 +174,7 @@ static int rzv2h_wdt_stop(struct watchdo > if (priv->of_data->wdtdcr) > rzt2h_wdt_wdtdcr_count_stop(priv); > > - ret = pm_runtime_put(wdev->parent); > - if (ret < 0) > - return ret; > + pm_runtime_put(wdev->parent); > > return 0; > } > > >