From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6436F2BEC5E for ; Wed, 1 Apr 2026 13:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775050465; cv=none; b=iJzvUrAS8WwLDkt6xiSLUPvquN3hyid+vXIvrIajYibehIgHhizhRNek7tDjlCQVCTcg1Q1DOslqA/Y/pUCzkB+9/cBN5cf/B+7tRxBdysvys4Z6tAeLmsdJF4S/amnLqKPVPl6hoTFXbt9kRsAXywjPCJIDoyl3j3SKH/ySzuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775050465; c=relaxed/simple; bh=kjBuFtSmTQKymqjdsLBcLS3k+9y7bSIc4IA9L9bYLps=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E03YqJauz+LKzLG+FUo082QFK5zGov09gtboWlxlsGr4fqJ+KxoAzxiTRcPSrsxITrXowEL15+DZlJaLN8sE9vuRhestdFpDnK80q1rHc8g4Vb5QzVNochpPzK9i5rE/n0rGW2f7eC4mzgnjKxEaHZwZ2oP+WSeV3gvCopVfBJY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HaRbwsA9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FlELJEXO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HaRbwsA9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FlELJEXO" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 631CYhcX3081565 for ; Wed, 1 Apr 2026 13:34:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oUAsPqKJi8o/QNgAhqgHHlu6CHFNY+OVldJYYmN8WmE=; b=HaRbwsA9zcvj5hnu FSfUQ4P7CBk4VkzpCyYHXq2JYa7oZJzTqdbHosRUqEfH8ETOFCtLdj7w9HPZGH9w yKuKfjbn/6SYYdz0AwLOoYWNUOtb63EUW/rCYXPgVwruZFYuVdhe1AAcqpWJEtfU nhfcRUHwhdZrbO34byZ+8HmC4i1wnFol/zQtKmf/aAfpHNLIY0fLNi7RdwDBOHlj PIYymzyUBj5u/Rsl/DYlLWN+lsZ3O9j7SVoGaHx9d4Fb1OsS8pI5NCFVxi4RoCLm IUn916gYb29ZcIsndOk6a8SciOcD0E0jD6VDwloKkvw4GXOSwhCruhBuZNAeh6lh 3kSnUA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8kdkvbx1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 13:34:23 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35da09e73d5so1272382a91.3 for ; Wed, 01 Apr 2026 06:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775050463; x=1775655263; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oUAsPqKJi8o/QNgAhqgHHlu6CHFNY+OVldJYYmN8WmE=; b=FlELJEXOpAP16MkUtgH4kCKlNpx+WWKfZKZcbCYDfKHpe2U3dUdYrLi462xL+/OZdK Zlk30206T6B1kjKzCEQZkcHyskCMkxH6iF8oe/3uGNplzzXNM5AE/3DQ9ysgp4RbXfFn uAPU8u1/JI/2sXe3Hi5oHyx3aq0gU0AxyhVtLL2d3avsHi+F1wgeLryQaWmBsAuSGaNU eRIXq6M9xYsX6WUSnkUJeYlSSAQrdPmtnHMYalwxRCyX03IRXKQZPFbhoqyxr9Xzd2wq Rs2v94BrxTTDHYjqfHDrCHSJK4a/vXqPs3elW2MHCkk1WhJLhhExWHxarjs2tr3b9HaH MWAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775050463; x=1775655263; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oUAsPqKJi8o/QNgAhqgHHlu6CHFNY+OVldJYYmN8WmE=; b=SJEuN0Ao0Rs+/uhQVlAYC+siP5elNmHIxIr5uyrC1/aAUoYXtgg1smxB+V7CFL9sQv M4Ceh8p0na8qeDoT93OXzgEy5hftNP0u6NH5FMYb8ZJ6KKlPhJFqnywWmfYQ0IyNW+so VOVKCZa6LTSSKEKNj3KZxUIXqx7pfogVHM+xdfUHOAalPFlqscXbch2UqF/5cGwYEdqp axB6+2LM56eoVvybVMwXBX3TlRZj1/4FmBfrgUOw4xcdTOuie7Oi+Ouu2Gh78Shq/UqE 4PT6ZFYEWe+MwKcLGidKODbq5POi4pnX3hv5c+ZZXRgEmm7emyX71ywcRMrwJl9Ty35u fFDA== X-Forwarded-Encrypted: i=1; AJvYcCWb90n/3Ns7c/RvM/5pwCyfrZkXtbradoD1pe8OhSVCRjFH+X6uoOFLtWpBvEuLxcPyb8CMtbpXy9BVhwc=@vger.kernel.org X-Gm-Message-State: AOJu0YwOmOae0L2TH/Z+uZFOsWoFezwvoWYlealReb4kY8qlu+gR7nEx icTDto1kBomiOAAy7iLglY+Pjoho5RKQDhDREYrsZHkIwIzfNEhKwnVRX1lAhoLNxkglsB6ufhY 7FhSMtMdrMz/IuZTE8Emwbv9bIh6jkDDW7j9xVSU4cOL/ab+A/vc/bV3ohkvNZtWDWLc= X-Gm-Gg: ATEYQzxrDlDVjAjyS2dISdFHjk1xixtVZh55vXAArNTm3xoPjeibIz+/c6dkCQSFWRu 1zXoaGn14LqmO0BBWewmhwf48Bld5+lGV8EyVCt6yytoK6uSGvvPndKnCfxcmFUuxT+TJ0jtukf Ld4xe+DV54zbqjALq5G8qJberR8kZ0SErlW6fGSrV/WyiM6/D1MokSWksBc61UW0jww06PyG+BD 4wDh3T0A1mIAA4GNSL4f0VRwclUoCqs6mGXlfsF1vHoD79JwQVsQHHXDcu5g1MklORKrWcBtOHS atx43lglLFH55IrAe9aswIOo5Fp/OEhNE597ZyrZ7RSLs1Z/dQOz/JGsQfdX+yck4iYMUfvWEt1 PQ9RnnLds5l8iusod8UxEYHk56/bI8MQHTSrLMqFB4TojH+ZaOgHUhUfquz+Jcq2U4cKNKMyGSQ EuOzfx3X6Cd910 X-Received: by 2002:a17:90b:3952:b0:35b:90e7:c450 with SMTP id 98e67ed59e1d1-35dc6e770f8mr2198547a91.1.1775050462920; Wed, 01 Apr 2026 06:34:22 -0700 (PDT) X-Received: by 2002:a17:90b:3952:b0:35b:90e7:c450 with SMTP id 98e67ed59e1d1-35dc6e770f8mr2198508a91.1.1775050462395; Wed, 01 Apr 2026 06:34:22 -0700 (PDT) Received: from [10.133.33.205] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76b986ec97sm3472440a12.30.2026.04.01.06.34.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 06:34:21 -0700 (PDT) Message-ID: <4a3887f7-9445-4d46-b250-5fb160c9795b@oss.qualcomm.com> Date: Wed, 1 Apr 2026 21:34:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] arm64: dts: qcom: kaanapali-mtp: Enable bluetooth and Wifi To: Dmitry Baryshkov Cc: Jingyi Wang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 20260224-knp-dts-misc-v6-0-79d20dab8a60@oss.qualcomm.com References: <13745334-c2dd-4a97-90de-a5ee18cff6a7@oss.qualcomm.com> <0279f334-95ed-4df8-9e42-749fd854c551@oss.qualcomm.com> <3xb6ya4zxhmaode3u3al5r4g3rfzlq2ifbyodvwtr3qgt34pwc@ia2xqfaeufd2> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDEyNSBTYWx0ZWRfXzTRX4thn68Nv 0RrGWHwlDCcbaEyj0txMWxBz8H149u5xUERbQKYa1kFpNCLL4Fo4KbWwQ1uAGq4r2wXoxcGpgUX qJNYhfR4+7O6JwMGEoVtJA4a/LUBVJv/1fFSaStSkxsCREK2dSPF0z/TXT/xO/7ic/Xmkx6eZsd sx5u/TXm3ioPAQZk3GanGlnaicVV1mfv6kkIuZgQ8Yl0Bzj/ZE2/kONr9jLbYiauU5zkhR0zhpc zpUq769GmKYB4t8Kfzv+TSGdeMg9fQ24BRZKg0Yd3IK1LnmsdphLiznlFEWo7SgL53dVy/KBw7F x8nWjF+h5IJ92n3/HR9UCWJ3zwR+7TpuQcaYthZxVHTvcGA4k64EFflPCX1fraVumkSEJrGPAi2 rWqcEbY6wyc0IUvnWSSIohVy8etuJ+RQEzHEtML/b2A/k/v0Y41O+lgmRgCdBMkUxKvA2bqHKI3 mbv/YnvHlHgKs0neVlA== X-Proofpoint-GUID: N8XwXgURpVcRDliZKjQjj_B7X1CQrfRQ X-Authority-Analysis: v=2.4 cv=YsQChoYX c=1 sm=1 tr=0 ts=69cd1edf cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=UxcVjGXgwavKz8fSHwIA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: N8XwXgURpVcRDliZKjQjj_B7X1CQrfRQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_04,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010125 On 4/1/2026 7:08 PM, Dmitry Baryshkov wrote: >>>>> - Is the pin wired in the hardware? >>>> pin SW_CTRL is wired in hardware. >>> Granted your three answers, it can and should be described in the DT. >>> >>>> i have below confusions about 'swctrl-gpios' of 'qcom,wcn7850-pmu' >>>> which WCN7850 pin is 'swctrl-gpios' mean for ? >>>> Why to introduce 'swctrl-gpios' ? >>>> what problem does it solve ? >>>> how to solve the problem ? >>> Please descibe the hardware in the DT. Problem solving belongs to the >>> driver. >> sorry for not agreeing with your points here. >> >> it is better to correct or remove 'swctrl-gpios' within DT binding spec at least >> for 'qcom,wcn7850-pmu' with below reasons: >> >> 1) provided that 'swctrl-gpios' is for pin SW_CTRL of datasheet, binding spec's >> both description and its expected usage are wrong. > Please correct it. > >> 2) its driver does not parse and use the property 'swctrl-gpios', moreover, the >> property have no user within upstream DT tree. > There is no "driver" in the "DT bindings" > 'its driver' i mean here is the driver which drives the device which is generated by this DT node 'qcom,wcn7850-pmu'. source code of the driver is drivers/power/sequencing/pwrseq-qcom-wcn.c >> 3) the property is not mandatory based on binding spec. > Which is expected, because on some platforms it might be not wired up > and on the other platforms the pin to which it is wired to might be > unknown (think about all the phones for which the community doesn't have > schematics). > got your points and will explain mine at below 2) together. >> 4) upstream DT tree have had many such usages as mine which just set default pin >> configuration and not specify 'swctrl-gpios' explicitly. > I don't understand this part. > For DT node 'qcom,wcn7850-pmu' of products identified by the following dts file at least: wcn7850-pmu { compatible = "qcom,wcn7850-pmu"; pinctrl-names = "default"; // config SW_CTRL pin default settings, but pinctrl-0 = ....; // this DT node does not specify property 'swctrl-gpios'. .... } grep -l -r "qcom,wcn7850-pmu" arch/arm64/boot/dts/qcom/ | xargs grep -l -r "sw[_-]ctrl" arch/arm64/boot/dts/qcom/sm8550-hdk.dts arch/arm64/boot/dts/qcom/sm8650-qrd.dts arch/arm64/boot/dts/qcom/sm8750-mtp.dts arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts arch/arm64/boot/dts/qcom/sm8550-qrd.dts arch/arm64/boot/dts/qcom/sm8650-hdk.dts >> 5) kaanapali-mtp is originally preinstalled with android OS which supports some >> qualcomm specific feature which have not been supported by up-stream kernel. >> so kaanapali-mtp H/W has some wired pins which is not used by up-stream >> kernel sometimes > Again, what does that have to do with the hardware description? kaanapali-mtp hardware supports the feature pin SW_CTRL involved, but we can decide not to enable the feature based on requirements. any advise about how to correct DTS to not enable the feature SW_CTRL involved ?