mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Po-Yu Chuang <ratbert@faraday-tech.com>,
	Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, taoren@meta.com
Subject: Re: [PATCH net-next v6 4/5] net: ftgmac100: Support rgmii delay in old dts with AST2600
Date: Mon, 2 Mar 2026 19:01:19 +0100	[thread overview]
Message-ID: <4a3975a5-f002-4c32-b45f-0f04edbfd25f@lunn.ch> (raw)
In-Reply-To: <20260302-rgmii_delay_2600-v6-4-68319a4c4110@aspeedtech.com>

>  static int ftgmac100_set_ast2600_rgmii_delay(struct ftgmac100 *priv,
> -					     u32 rgmii_tx_delay,
> -					     u32 rgmii_rx_delay,
> -					     phy_interface_t phy_intf)
> +					     s32 rgmii_tx_delay,
> +					     s32 rgmii_rx_delay,

You introduced these parameters in the previous patch. Please get the
types correct from the start.

	Andrew

  reply	other threads:[~2026-03-02 18:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 10:24 [PATCH net-next v6 0/5] Add AST2600 RGMII delay into ftgmac100 Jacky Chou
2026-03-02 10:24 ` [PATCH net-next v6 1/5] dt-bindings: net: ftgmac100: Add delay properties for AST2600 Jacky Chou
2026-03-02 10:24 ` [PATCH net-next v6 2/5] ARM: dts: aspeed-g6: add aspeed,scu property for MAC Jacky Chou
2026-03-02 10:24 ` [PATCH net-next v6 3/5] net: ftgmac100: Add RGMII delay support for AST2600 Jacky Chou
2026-03-02 17:47   ` Andrew Lunn
2026-03-04  3:31     ` 回覆: " Jacky Chou
2026-03-04 20:15       ` Andrew Lunn
2026-03-05  4:45         ` Jacky Chou
2026-03-02 10:24 ` [PATCH net-next v6 4/5] net: ftgmac100: Support rgmii delay in old dts with AST2600 Jacky Chou
2026-03-02 18:01   ` Andrew Lunn [this message]
2026-03-04  3:32     ` 回覆: " Jacky Chou
2026-03-02 10:24 ` [PATCH net-next v6 5/5] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC Jacky Chou
2026-03-02 18:04   ` Andrew Lunn
2026-03-05  5:05     ` Jacky Chou
2026-03-05 13:16       ` Andrew Lunn
2026-03-06  5:24         ` Jacky Chou
2026-03-06 14:01           ` Andrew Lunn
2026-03-10  6:14             ` Jacky Chou
2026-03-02 18:08 ` [PATCH net-next v6 0/5] Add AST2600 RGMII delay into ftgmac100 Andrew Lunn
2026-03-03  1:30 ` Andrew Lunn
2026-03-03  2:44   ` 回覆: " Jacky Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a3975a5-f002-4c32-b45f-0f04edbfd25f@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=jacky_chou@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ratbert@faraday-tech.com \
    --cc=robh@kernel.org \
    --cc=taoren@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®