From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7283248866 for ; Mon, 14 Jul 2025 13:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752500676; cv=none; b=CTW3pb4jni1fixVS83cQaqoajnoxy6M1BWQqvMn0+nPuH93IGMG7xCUnIYAbTEhommrAK6CMJIQ3IsFzoJCPMYQQ/SVDga2u8ysZdJHNAYx+XEv8q8FrhPKmouC03KRqnN16IV+HaacM7HNGiuTvLX3cLmquN7WHgcJsUtQpk9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752500676; c=relaxed/simple; bh=L9rd/YFjBCYeu+vrNj99L08qC8r/zV90EKJEPXRCDgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s0P7FR1pE1gW8on+M2O5HcsbEerA8jRVjCWU3ipjIrIQFeXf+rMqpOyHPGYZLcWBMMXJxHBRNH+OysIQLKT6j99a5E/RVEY3y9owZ+vbdniiMPKAUkngO4sbqUxxj5XFLpeVnAZPjBh4hdRjI5+mBLRd1pAohmIhH4N3zOemsWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Sx0kOClg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sx0kOClg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752500673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X+GS2rPtBARL/ESHq8iljkHKPEQ7wONWjHbxi92M2D8=; b=Sx0kOClguq3BfG2Heo3DI1LQiZbi/N3tB1CxOJlpdKqiYFW9g1GpkEdxA9cfxC6tnPIECv ca1yOZM6y1MdJWLPi1diCvt2PINn4Gt04u/GP1DHgjd38HpEJb+oXSV0K5qrHLddvGhRtw ++Usl48VwP3L7Cs5xZ7J7VDJ8o6AXMs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-Qmw5lbwlOgmyhAue2sI_RQ-1; Mon, 14 Jul 2025 09:44:32 -0400 X-MC-Unique: Qmw5lbwlOgmyhAue2sI_RQ-1 X-Mimecast-MFC-AGG-ID: Qmw5lbwlOgmyhAue2sI_RQ_1752500671 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451d7de4ae3so27893355e9.2 for ; Mon, 14 Jul 2025 06:44:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752500671; x=1753105471; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=X+GS2rPtBARL/ESHq8iljkHKPEQ7wONWjHbxi92M2D8=; b=ST3zUqqgXT+UI1ynNkzGUA318vx6hPZbFxK3v/6Yt5Whe4lRaJlZf9XjRk6HMFZZ6u LAiCDNsAnLT8H0M8Dq1mWYSwJB1yEf0Fa3VT6EmZxVSH4OeGxpCWn3aLFtMiNygWjK8L VLq3xRm11509X7DCBYG+MRlewYSI515gKBJplIKsMLDz1+3NOjQ3IfplIZy73878vXS7 aH1eCPyrZbwU36yRLSHNJRfJ8M6E9ZmBLWQ/G3Syx6tSGk7vHi4T6RJ1aXkCJ225AL6t rmB1LqLBUb6HPL4Twdv0RdbtjH9Wa/40jlgoNmJgk3XSRLt1OEtlIVhhM/uEYQLabfDa NLkA== X-Forwarded-Encrypted: i=1; AJvYcCWXikzz8ie1mwdE1heaQHFEkJqve0MHWnJHYcbjyJupwxVnD9NP3BUDtMd0DIrg8mtwjl7tBROwBSRLkMQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwJnmY7dFSrtP9qccEnrnN0YRUnD2nlb578MIQ7xN8FNTQ5uV/6 CSEHBRumcaEa/U3CdMUkiHGrc83iqZjmoM/uyXqN/0MTHj6y6wbw+bYDjI0D9/wMFQaQtDjY8GB 56snrP/2f7ugdQUY7mGUZCcPh5nCq964deOItapO21Ucbwq/8IN4teoKO5eTer5zOUw== X-Gm-Gg: ASbGncuwUOabu2370IbDmnEF3M2ZLG0mTBujNn9KHqWruJDxe0AXsRGddKqgTlkf/lh F4nlXHqHx3MpPPZ/daO1I6rSZJ2qJfTLUL1+UK3WFjTR7y3+kAH+uTAPuKrFPvDBceGtUL/ENeX tcNLgve9hIsgm1mejFt4n2R25MHENQ+phUzxZprtn6lD/Z5uWyzsAud6ZSYi3aXwZuYiY08UBjh Xs+uhyC4eM86/CD8FixvAK+JeMODvVcdDVvFagLAtk4BRgZlLsbKwFqPB/3dv7RF153IOQGLFVc y/aSiC9GcjNP+vwHM7na0L5abvzxcHnX4OTxiK1sz2O78IgIklf9naNfBN3iUnxNM1lODdQzFbs vWg5CXU/jXBMBU6+2Vx3qpP13gYUr5Z7d7KZ2IO+/Vu30as7JpWeWJzTHOWOe3A+0 X-Received: by 2002:a05:600c:821a:b0:456:207e:fd86 with SMTP id 5b1f17b1804b1-456207f008bmr21905965e9.2.1752500671098; Mon, 14 Jul 2025 06:44:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3ScZAKbeGoqX2wP9/gRIpia/X8+PS57jXCXwanug3eBTNK8Z/wPQG4PIBWgLe3XbF2i1MEw== X-Received: by 2002:a05:600c:821a:b0:456:207e:fd86 with SMTP id 5b1f17b1804b1-456207f008bmr21905615e9.2.1752500670671; Mon, 14 Jul 2025 06:44:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0d732sm12689842f8f.52.2025.07.14.06.44.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 06:44:30 -0700 (PDT) Message-ID: <4a3e0759-caa1-4cfa-bc3f-402593f1eee3@redhat.com> Date: Mon, 14 Jul 2025 15:44:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard_region To: Mark Brown , wang lian Cc: Andrew Morton , SeongJae Park , Lorenzo Stoakes , Zi Yan , linux-kernel@vger.kernel.org, Christian Brauner , Jann Horn , Liam Howlett , Shuah Khan , Vlastimil Babka , gkwang , p1ucky0923 , ryncsn , "zijing . zhang" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20250714130009.14581-1-lianux.mm@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.07.25 15:39, Mark Brown wrote: > On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote: > >> Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared >> `vm_util.h` header to promote code reuse. >> >> In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro >> to ensure only the current test is skipped on permission failure, instead >> of terminating the entire test binary. > > These two changes look fine but they're not really related so should be > separate patches. Looking briefly at guard-regions.c I see a bunch more > use of ksft_exit_ functions that ought to be fixed as well, but your fix > is good. The FORCE_READ() could be factored out separately, and as part of the same patch, replace the "asm volatile("" : "+r" (XXX));" usage in * cow.c * hugetlb-madvise.c * migration.c * pagemap_ioctl.c * split_huge_page_test.c -- Cheers, David / dhildenb