mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hari Prasath <gehariprasath@ti.com>
To: Moteen Shah <m-shah@ti.com>, <krzk+dt@kernel.org>,
	<robh@kernel.org>, <conor+dt@kernel.org>, <nm@ti.com>,
	<vigneshr@ti.com>, <kristo@kernel.org>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <u-kumar1@ti.com>,
	<y-abhilashchandra@ti.com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio support
Date: Fri, 16 Jan 2026 17:22:47 +0530	[thread overview]
Message-ID: <4a46cbb7-f1b7-4509-8bd1-ffb192d1e2e9@ti.com> (raw)
In-Reply-To: <20260112104536.83309-4-m-shah@ti.com>

On 12/01/26 4:15 pm, Moteen Shah wrote:
> From: Jayesh Choudhary <j-choudhary@ti.com>
> 
> The audio support on J721S2-EVM is using PCM3168A codec
> connected to McASP4 serializers.
> 
> - Add the nodes for sound-card, audio codec, MAIN_I2C3 and
>    McASP4.
> - Add pinmux for I2C3, McASP4, AUDIO_EXT_REFCLK1 and
>    WKUP_GPIO_0.
> - Add necessary GPIO hogs to route the MAIN_I2C3 lines and
>    McASP serializer.
> - Add idle-state as 1 in mux0 and mux1 to route McASP signals
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Moteen Shah <m-shah@ti.com>
> ---
Looks good,
Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>

>   .../dts/ti/k3-j721s2-common-proc-board.dts    | 131 ++++++++++++++++++
>   1 file changed, 131 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index 4fea99519113..d9269a16956c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -150,6 +150,28 @@ transceiver4: can-phy4 {
>   		standby-gpios = <&exp_som 7 GPIO_ACTIVE_HIGH>;
>   		mux-states = <&mux1 1>;
>   	};
> +
> +	codec_audio: sound {
> +		compatible = "ti,j7200-cpb-audio";
> +		model = "j721e-cpb";
> +
> +		ti,cpb-mcasp = <&mcasp4>;
> +		ti,cpb-codec = <&pcm3168a_1>;
> +
> +		clocks = <&k3_clks 213 0>, <&k3_clks 213 1>,
> +			 <&k3_clks 157 299>, <&k3_clks 157 328>;
> +		clock-names = "cpb-mcasp-auxclk", "cpb-mcasp-auxclk-48000",
> +			      "cpb-codec-scki", "cpb-codec-scki-48000";
> +	};
> +
> +	i2c_mux: mux-controller-2 {
> +		compatible = "gpio-mux";
> +		#mux-state-cells = <1>;
> +		mux-gpios = <&wkup_gpio0 54 GPIO_ACTIVE_HIGH>;
> +		idle-state = <1>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&main_i2c3_mux_pins_default>;
> +	};
>   };
>   
>   &main_pmx0 {
> @@ -224,6 +246,22 @@ J721S2_IOPAD(0x03c, PIN_INPUT, 0) /* (U27) MCASP0_AFSX.MCAN5_RX */
>   			J721S2_IOPAD(0x038, PIN_OUTPUT, 0) /* (AB28) MCASP0_ACLKX.MCAN5_TX */
>   		>;
>   	};
> +
> +	mcasp4_pins_default: mcasp4-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_IOPAD(0x0c8, PIN_OUTPUT_PULLDOWN, 1) /* (AD28) MCASP4_ACLKX */
> +			J721S2_IOPAD(0x06c, PIN_OUTPUT_PULLDOWN, 1) /* (V26) MCASP4_AFSX */
> +			J721S2_IOPAD(0x068, PIN_INPUT_PULLDOWN, 1) /* (U28) MCASP4_AXR1 */
> +			J721S2_IOPAD(0x0c4, PIN_OUTPUT_PULLDOWN, 1) /* (AB26) MCASP4_AXR2 */
> +			J721S2_IOPAD(0x070, PIN_OUTPUT_PULLDOWN, 1) /* (R27) MCASP4_AXR3 */
> +		>;
> +	};
> +
> +	audio_ext_refclk1_pins_default: audio-ext-refclk1-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_IOPAD(0x078, PIN_OUTPUT, 1) /* (Y25) MCAN2_RX.AUDIO_EXT_REFCLK1 */
> +		>;
> +	};
>   };
>   
>   &wkup_pmx2 {
> @@ -321,6 +359,12 @@ J721S2_WKUP_IOPAD(0x104, PIN_INPUT, 0) /* (N26) MCU_ADC1_AIN6 */
>   			J721S2_WKUP_IOPAD(0x108, PIN_INPUT, 0) /* (N27) MCU_ADC1_AIN7 */
>   		>;
>   	};
> +
> +	main_i2c3_mux_pins_default: main-i2c3-mux-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_WKUP_IOPAD(0x038, PIN_OUTPUT, 7) /* (B27) WKUP_GPIO0_54 */
> +		>;
> +	};
>   };
>   
>   &wkup_pmx1 {
> @@ -396,6 +440,22 @@ exp2: gpio@22 {
>   				  "MLB_MUX_SEL", "MCAN_MUX_SEL", "MCASP2/SPI3_MUX_SEL", "PCIe_CLKREQn_MUX_SEL",
>   				  "CDCI2_RSTZ", "ENET_EXP_PWRDN", "ENET_EXP_RESETZ", "ENET_I2CMUX_SEL",
>   				  "ENET_EXP_SPARE2", "M2PCIE_RTSZ", "USER_INPUT1", "USER_LED1", "USER_LED2";
> +
> +		p09-hog {
> +			/* P09 - MCASP/TRACE_MUX_S0 */
> +			gpio-hog;
> +			gpios = <9 GPIO_ACTIVE_HIGH>;
> +			output-low;
> +			line-name = "MCASP/TRACE_MUX_S0";
> +		};
> +
> +		p10-hog {
> +			/* P10 - MCASP/TRACE_MUX_S1 */
> +			gpio-hog;
> +			gpios = <10 GPIO_ACTIVE_HIGH>;
> +			output-high;
> +			line-name = "MCASP/TRACE_MUX_S1";
> +		};
>   	};
>   };
>   
> @@ -657,3 +717,74 @@ &dphy_tx0 {
>   &dsi0 {
>   	status = "okay";
>   };
> +
> +&mux0 {
> +	idle-state = <0>;
> +};
> +
> +&mux1 {
> +	idle-state = <0>;
> +};
> +
> +&exp_som {
> +	p03-hog {
> +		/* P03 - CANUART_MUX_SEL1 */
> +		gpio-hog;
> +		gpios = <3 GPIO_ACTIVE_HIGH>;
> +		output-high;
> +		line-name = "CANUART_MUX_SEL1";
> +	};
> +};
> +
> +&k3_clks {
> +	/* Confiure AUDIO_EXT_REFCLK1 pin as output */
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&audio_ext_refclk1_pins_default>;
> +};
> +
> +&main_i2c3 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_i2c3_pins_default>;
> +	clock-frequency = <400000>;
> +	mux-states = <&i2c_mux 1>;
> +
> +	exp3: gpio@20 {
> +		compatible = "ti,tca6408";
> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	pcm3168a_1: audio-codec@44 {
> +		compatible = "ti,pcm3168a";
> +		reg = <0x44>;
> +		#sound-dai-cells = <1>;
> +		reset-gpios = <&exp3 0 GPIO_ACTIVE_LOW>;
> +		/* C_AUDIO_REFCLK1 -> MCAN2_RX (Y25) */
> +		clocks = <&audio_refclk1>;
> +		clock-names = "scki";
> +		VDD1-supply = <&vsys_3v3>;
> +		VDD2-supply = <&vsys_3v3>;
> +		VCCAD1-supply = <&vsys_5v0>;
> +		VCCAD2-supply = <&vsys_5v0>;
> +		VCCDA1-supply = <&vsys_5v0>;
> +		VCCDA2-supply = <&vsys_5v0>;
> +	};
> +};
> +
> +&mcasp4 {
> +	status = "okay";
> +	#sound-dai-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mcasp4_pins_default>;
> +	op-mode = <0>;          /* MCASP_IIS_MODE */
> +	tdm-slots = <2>;
> +	auxclk-fs-ratio = <256>;
> +	serial-dir = <	/* 0: INACTIVE, 1: TX, 2: RX */
> +		0 2 1 1
> +		0 0 0 0
> +		0 0 0 0
> +		0 0 0 0
> +	>;
> +};


  reply	other threads:[~2026-01-16 11:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 10:45 [PATCH 0/3] Enable analog audio support on J721S2 EVM Moteen Shah
2026-01-12 10:45 ` [PATCH 1/3] ti,j721e-system-controller.yaml: Allow audio-refclk as clock-controller child Moteen Shah
2026-01-15 17:31   ` Rob Herring (Arm)
2026-01-12 10:45 ` [PATCH 2/3] arm64: dts: ti: k3-j721s2-main: Add audio_refclk node Moteen Shah
2026-01-16 10:29   ` Hari Prasath
2026-01-12 10:45 ` [PATCH 3/3] arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio support Moteen Shah
2026-01-16 11:52   ` Hari Prasath [this message]
2026-01-16 13:04   ` Nishanth Menon
2026-02-04 11:18     ` Moteen Shah
  -- strict thread matches above, loose matches on Subject: below --
2025-06-04 10:46 [PATCH 0/3] Enable audio support for J721S2-EVM Jayesh Choudhary
2025-06-04 10:46 ` [PATCH 3/3] arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio support Jayesh Choudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a46cbb7-f1b7-4509-8bd1-ffb192d1e2e9@ti.com \
    --to=gehariprasath@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-shah@ti.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    --cc=y-abhilashchandra@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®