From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8185E366DA6 for ; Fri, 20 Feb 2026 19:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771616417; cv=none; b=a37lwGQXRGgynqeRIBYpxAz3tT3/QThzUQo0SwrbBrvgrIEuKGkRnb96yrIzVG9DOdUsvJ+lhDA7O1WWxx4i++sw1n22sKprY1grYGenKrioPocam5/oPeNGrADxCveYkaL+Rl9y7eHU/6AnBWK+S9ulF2/opPqNHnbC/sxfmj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771616417; c=relaxed/simple; bh=Y9f3ck/yIoQMHfgsAPViyCr7Gxf6kwkK1VidNxbh9UU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lt+XPtMmxormpmQ/rk3BayMYa6wX/brlB9Xf+CYh+flvvdaZDZDrTDFOFXvQi3hDdGjY8uf5MND/h9AhD6twaCKqEq55reDcEsVnQGpWcI9liEgSHQ8EKFyxoz2h8YFM9d236qiZm5ADOQ0mIrIQ9VwE8T9mKTU2Q9X6JoCc8s8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U5ZCa3j3; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U5ZCa3j3" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-436309f1ad7so1800768f8f.3 for ; Fri, 20 Feb 2026 11:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771616415; x=1772221215; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nyHPZhc6MnyvbtV+6dNUEPdByvvgCMiVIv5VMP5WfV4=; b=U5ZCa3j34hWifzzGaKjWOmW8xRuxahtuTHwUJv38HEwnSWNznlDs92PxsEl+bzQlQR FEaFEEKEQRYC89u8/HgGunrL8bZYZt3zZSHH2eQGsrIBuZywcBZ3RfR4q4/lTG4ZfUUy NrY99gmSfyk7xW9bBwmsJXbsCAcSxIupihE5bRWysl4/FuFFPG8goLSrgrzEbMiI3iVT lZDqVp2mQVDZV3ugQjx2Ttya3AK3Q+MaSxPP9kRyzPNPUXEMLIt0SbKauK59yfxVLC77 vzediZCq+uSnMWW5DkUiECh9NkeXYqFEUj1pMuTLsq1pWYSX2KL0+hQY5opHG+hKCRrP 3QwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771616415; x=1772221215; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nyHPZhc6MnyvbtV+6dNUEPdByvvgCMiVIv5VMP5WfV4=; b=U/nyjW3HGd7JM/lO9I6Fmv7k2eN3X7zDjTq+iy//dZJpJfAU2fbndtOEhVaLz53WiB HKm0MYunsi1rZ73ocC03Cjqx+LTTk5DUhMlRfLdtOYA2UIDW/I+ubQlaTO81FaZ8fm8S 9MmK9K6w3AyKf8zWn42GNv4Gx4yCvPeA2ycdcpWNHJ17QZ5tQJ+FzCbhbIJ0RIpo9Vi2 A0Pb1eQs/o8KW4Ud70WfB7YvcNVfJWfp5nT4O8qxRVo+gGrrynFirKX/1HF/RwFAZ+SU apsyvVK2QdzQv2oe1DduKZ7GlOt8+RmLViMbklvcy7D5sZS4V/t/saO9J3Ik5YYlR5Cg FyWg== X-Forwarded-Encrypted: i=1; AJvYcCUIoaY6OtT/eOyFZdG8ZBlhPpArl5zg8EyQUtK5U9PSlCCSAV8DzO2wxQl0C6hUetwQxcLWW2qq57dcjno=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5P21EJOgX8XsDoFBXrOlwcM4I8QCxI8OHWXd0nOQBy0Tn/TrS +wRgvFA5o4MbbP+wB1DBbWoRPmPv9sxX9ZXjKRIC6NjCaMsrJyKXg8u3 X-Gm-Gg: AZuq6aLxnXPXPdoFA0UXZYwjNRdgwDbDcS2tHP70nvpgI0AmAlK8UIcOYmjShwzaIFj OjfWCloFtSupfQw/+sUhSLhSvjwU7xiuAJM2SgMfhO167PfG1j3k3I35ItyqU/Y1gGMZ/nkAJ+t 1s48yyNqHFbU32F0dY2iNPnI/hEabnBPOpJxSKv3e2Pw7SjKBy3d3BL2f8unwlrYGBsPLpnHsVW PKf4HzsndDzRDDFXt2SOQgsKV6K1WCW49+Oj1zxxANlYLPfgkhjbeJSms4SS02XReqEx5xgjsZN rFbFJsVVXTxaWQ9Ag5lRjpOIJVEtSdbSKBUsdNkmaTUzoNGRiHoe/T23QJH8w8VsUBNFSczHeYT qPLnMP653kl1js9SakHqHEE7NSW0hvwcONT0C8peWWvIRs1WZuXsMsnFaXCXtEdwPLhHV9Y7vZQ +xGkExl6FZpo55ALB13QpUFX2JpqjfZrETuBIAggM2QegBFZp+rOWRhVma1iI= X-Received: by 2002:a05:6000:2910:b0:437:8111:e2d0 with SMTP id ffacd0b85a97d-4396f1562efmr1811172f8f.8.1771616414667; Fri, 20 Feb 2026 11:40:14 -0800 (PST) Received: from [10.247.12.125] ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d40004sm177552f8f.21.2026.02.20.11.40.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Feb 2026 11:40:14 -0800 (PST) Message-ID: <4a4afe2c-a592-432c-a46c-3446878501c9@gmail.com> Date: Fri, 20 Feb 2026 19:40:12 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/3] drm/syncobj: Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to query errors To: =?UTF-8?Q?Christian_K=C3=B6nig?= , michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com References: <20260220022631.2205037-1-yiconghui@gmail.com> <20260220022631.2205037-2-yiconghui@gmail.com> <9b952d44-6fc6-4594-9e16-78d529290c9d@gmail.com> Content-Language: en-US From: Yicong Hui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/20/26 5:07 PM, Christian König wrote: > On 2/20/26 18:05, Yicong Hui wrote: >>>> + >>>>   /** >>>>    * dma_fence_chain_find_seqno - find fence chain node by seqno >>>>    * @pfence: pointer to the chain node where to start >>>> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c >>>> index 2d4ab745fdad..322f64b72775 100644 >>>> --- a/drivers/gpu/drm/drm_syncobj.c >>>> +++ b/drivers/gpu/drm/drm_syncobj.c >>>> @@ -1654,14 +1654,17 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, >>>>   { >>>>       struct drm_syncobj_timeline_array *args = data; >>>>       struct drm_syncobj **syncobjs; >>>> +    unsigned int valid_flags = DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED | >>>> +                   DRM_SYNCOBJ_QUERY_FLAGS_ERROR; >>>>       uint64_t __user *points = u64_to_user_ptr(args->points); >>>> +    uint64_t __user *handles = u64_to_user_ptr(args->handles); >>>>       uint32_t i; >>>>       int ret; >>>>         if (!drm_core_check_feature(dev, DRIVER_SYNCOBJ_TIMELINE)) >>>>           return -EOPNOTSUPP; >>>>   -    if (args->flags & ~DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) >>>> +    if (args->flags & ~valid_flags) >>>>           return -EINVAL; >>>>         if (args->count_handles == 0) >>>> @@ -1680,6 +1683,22 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, void *data, >>>>           uint64_t point; >>> >>> Make a local variable "int error" here. >>> >>> ... >>> >>>> +            int64_t error = 0; >>> >>> The error code is an int and only 32bits. >> Understood, will change that! >> >>> >>>> + >>>> +            if (fence) >>>> +                error = dma_fence_chain_find_error(fence); >>>> + >>>> +            ret = copy_to_user(&handles[i], &error, sizeof(int64_t)); >>> >>> The handles are also only 32bits! >> Ah, that's my mistake. Was thrown off by the __u64 in the struct definition but it is obvious now that it is a u32. Fixed as well! >> >>> >>>> +            ret = ret ? -EFAULT : 0; >>>> +            if (ret) { >>>> +                dma_fence_put(fence); >>>> +                break; >>>> +            } >>>> + >>>> +        } >>>> + >>>>           chain = to_dma_fence_chain(fence); >>>>           if (chain) { >>> >>> In this code path whenever point is assigned something do a "error = dma_fence_get_status(fence);" and then eventually copy the error to userspace after copying the point. >>> >> >> Hi! Were you thinking something that looks a little bit like this? > > Yeah that looks like what I had in mind to. > > Thanks, > Christian. > Hi! What should I do at this point? Send a v3, or..? Thanks! Yicong