From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B9FC433F5 for ; Thu, 23 Sep 2021 11:13:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF37B61107 for ; Thu, 23 Sep 2021 11:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240562AbhIWLPB (ORCPT ); Thu, 23 Sep 2021 07:15:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240448AbhIWLPA (ORCPT ); Thu, 23 Sep 2021 07:15:00 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABB2EC061574 for ; Thu, 23 Sep 2021 04:13:28 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id u8so24553658lff.9 for ; Thu, 23 Sep 2021 04:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=z0SFg5XPiL4WJby2z1leZXw+OOsnwhmSnsCcKEN4ygk=; b=TceJ00O86yDAQeqnnk1WFSsXG+WQofeifCY5VdqnzSTOQqXfsfx3rp1cYjGB7c+CV0 7Niq6yY0S9iG0npsOQFU0PYswqr6MUMiZje8Z8po+9evq77oAse15QUFttiFaupZttjE 7ev5ZBmoeVe5TJeyBzRqPb3xoLM17s39airAjz/0dG/KMz/qyJPaPqMHZNPo8DQE1QNp +i9ckLxp4jX656M6rBW+DPcsBT1cmiqJhCEYbNISAjGKTrwUyOqS9S8+jCw4SgvsnOSi Xbi2L7O9eCrnhkFmGuuG3HS26y2zmO3N5+A/3HY9I9KAprie+0Rva/rt9n4CbLNk1bOw Yi1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=z0SFg5XPiL4WJby2z1leZXw+OOsnwhmSnsCcKEN4ygk=; b=ZauDvcWpGHeezL60J0viK057SkXDgCsK+8hvoSpc3k+riLt6o3UnbnM0U7o8QX48F1 7uhM+/4b8SLi2wCDjCxoMsKA4vAPYWAhyIJ2Ki55HIpso5O8BWkjbJE5O8r0VN5WL9RA CTXAzuAJ6hn8Su8p8JYD0RiO8/nuoRAW2z80S/F7ehIniivyPoNRqLKyeNKr2K0GJi7J dRgjDEqF4EtIzLx0kzf9Co6XOG6NNGBuvbCXbGkVE8u5A/KR7I37wugK9CXRCE5ZnVR7 +KIoq3qSGmyUXeGBrltVx4JyGeRKFPH1OfDQvaWahtu8ot3W9IZQe/0cNOebnAHFtyRI OV7A== X-Gm-Message-State: AOAM532deMWj3uwidNIcm/KQlvCFTXL2iTDEKij1GSPraqjoSSpDuVCn jrSk4EH10/MsWWxVX556DiQ= X-Google-Smtp-Source: ABdhPJygcHA8aODCwyu08fok6DpFLAp77494U9g/ZtlmPj1p5+Y305thcEH4TqTlc/GRwIYvaF65Iw== X-Received: by 2002:a05:651c:170e:: with SMTP id be14mr4340632ljb.487.1632395606947; Thu, 23 Sep 2021 04:13:26 -0700 (PDT) Received: from [192.168.1.11] ([217.117.246.37]) by smtp.gmail.com with ESMTPSA id v8sm338366lfe.6.2021.09.23.04.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 04:13:26 -0700 (PDT) Message-ID: <4a556764-9a0a-b453-c2d5-16c1a8cbea61@gmail.com> Date: Thu, 23 Sep 2021 14:13:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v9 16/16] staging: r8188eu: remove usb_vendor_req_mutex Content-Language: en-US To: Greg KH Cc: "Fabio M. De Francesco" , Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Martin Kaiser References: <20210921181834.29677-1-fmdefrancesco@gmail.com> <20210921181834.29677-17-fmdefrancesco@gmail.com> <4434c136-6bfc-9a25-d0ba-f989c655fa69@gmail.com> From: Pavel Skripkin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/23/21 14:07, Greg KH wrote: > On Thu, Sep 23, 2021 at 01:12:53PM +0300, Pavel Skripkin wrote: >> On 9/23/21 11:47, Pavel Skripkin wrote: >> > On 9/22/21 16:21, Pavel Skripkin wrote: >> > > On 9/21/21 21:18, Fabio M. De Francesco wrote: >> > > > From: Pavel Skripkin >> > > > >> > > > This mutex was used to protect shared buffer for USB requests. Since >> > > > buffer was removed in previous patch we can remove this mutex as well. >> > > > >> > > > Furthermore, because it was used to serialize the calls to the Core USB >> > > > API, we thoroughly tested the enabling of concurrent firing of USB requests >> > > > without the mutex and found no problems of any kind in common use cases. >> > > > >> > > > Co-developed-by: Fabio M. De Francesco >> > > > Signed-off-by: Fabio M. De Francesco >> > > > Signed-off-by: Pavel Skripkin >> > > >> > > Hi, Greg! >> > > >> > > If all is OK with previous 15 patches, please, do not take this one, it >> > > causes problems with connection... :) >> > > >> > > I don't understand what went wrong after v8, but anyway, this one should >> > > not be applied for now, since it's broken >> > > >> > > >> > > Thank you >> > > >> > > >> > >> > >> > Just to be clear: previous 15 patches _are_ tested and do not cause any >> > misbehavior or bugs. >> > >> > I guess, the stack buffer maybe the problem here, since it's the only >> > change on this side since v8. I didn't have a chance to take a closer >> > look, but I will do it on weekends, I hope :) >> > >> >> Oh, I found the problem by just looking at the code with clear mind: >> >> > -free_dvobj: >> > - if (status != _SUCCESS && pdvobjpriv) { >> > + if (pdvobjpriv) { >> > usb_set_intfdata(usb_intf, NULL); >> > kfree(pdvobjpriv); >> > pdvobjpriv = NULL; >> >> This if should be deleted completely, because we don't want to fail on every >> probe :) >> >> Sorry for noise... :( >> >> Greg, can you take first 15 patches, if they look good and then I will send >> fixed version of 16? AFAIU, you are ok with taking part of the series > > Please fix up and resend the whole series as our tools work best by > taking the whole thing. > > That way I "know" you tested them all :) It is true, but there was small error on testing side from me this time. I am testing with qemu and I forgot to copy new driver to qemu's shared folder (it was busy day or I was already asleep, idk). It resulted to testing old version of the driver. Next day I've tested new changes on top of this series and found the problem :) I am sorry for kind of lying, i've already fixed it locally, so it won't happen again With regards, Pavel Skripkin