From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 799C64508F7 for ; Wed, 8 Jul 2026 12:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515296; cv=none; b=JWNA16d3Q1M4Kxns50VCUP7FK3JAMGbZbs9wSJvyx45j5qwkY4XYmc+E/SH275djKrGujFqRGEH9jSrzaN+v0mzh6jW82RoHWCfYbEpQQbSj4I1nAc/j9eK9auJVrOsCQW88wBdJY3boPOS1GMe1KGMg8JRooXdVpFvuoUSiti8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515296; c=relaxed/simple; bh=NqIdz9eEaKfnjtFoMaD9625M1qr2VdseCv1Uqzseygc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=t7uTgLMcX8zRWHiXBzVUMMK9Ou8ZLGQtPhrz6JjeyfdC6QMi7v1QdMDrow0l+pj5dJc8J5E9zCWJgYBCu90Onk9mQNbEQSc3QhBEsi1LyzBKJm1EWgor5Zo1R4JGwNv1ogcSoDdku3br43v5rO/+3T/lXS2agab/9nomWF1JTEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OPchiDIQ; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OPchiDIQ" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-691c5776f95so1207586a12.3 for ; Wed, 08 Jul 2026 05:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783515293; x=1784120093; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=NqIdz9eEaKfnjtFoMaD9625M1qr2VdseCv1Uqzseygc=; b=OPchiDIQUJypNYvQDZ5Emw1SPIjZMHfIfJz/4WNNtBw34u0DgXs097IcHrO/tft+pL 5RkEn3HDA70TDl/nqQl5u5I6LbTRBPldanvHaX7C7u4VtoIRT2IjscdYeYVzwxqEtFC9 8zNLW4Xk/H9tKCf6NQvOInnKR/0wkVgN75Iqx934PbZbl/9eL8wGP7Ow+KidHDW+uaa3 WGFVUAxJa+hSHN7veFSM9/zOKXazGzNQd2EXwur8xbp2nFLePZheZnMkxfVVxEpfURil tOf1SXcjX0Gdu3aeDuF7dEPD/dELQ5kN0RvxrNi0R0XfUU7PypMXR3sP3DdwGKQwobSb qEiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783515293; x=1784120093; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NqIdz9eEaKfnjtFoMaD9625M1qr2VdseCv1Uqzseygc=; b=tAiuK8HVE7CYXqD/mJAaAIEtGU2AdveeIzAtowOYMYCgGsNfiknOYPELzCDZIfMqwt 2dEAnreGuo7Em//MMPufF8V7kHVj/j9e0kjNOsVf763IIQolJQUGSHgH3DlzP3I/8tMI YN2fFwK6ehKN2kALA3tPcgZLhvau7Wesb1FuZNJYkVm+gz29HSaJnO5Gupv7DRgwzvru bi++V7o2dFPL0Zo9cMVf8vKd+KXWa1LalIwwn2VEZGzLveIlu8wMTo0G8zAnd3ujtz51 gMfR16o5cfNI9ndbYIO0zKcB9lA7XslfjzmtKP+CLtgH7dH0j+A/D6Zn/Wl3b8y9cYoP JTrA== X-Forwarded-Encrypted: i=1; AHgh+Ro3Deka0hOBbGB4vTzgfJrz79/FIZeb7xBetuBd7G4EfnqMrfsUwJtCvn0qHVXDvoQloJkaQu7j91ZVTHg=@vger.kernel.org X-Gm-Message-State: AOJu0YzCK7rTrRVeXInFbqyQ2S3pk+7pza9AtQYE2gw4PZZEyXj7EuDj ethW8ptnuFQqgDtIfNQoa5a44kZhHDU8gma2BBA/5u1t962qKe2aB9kP399La5FSaFk= X-Gm-Gg: AfdE7clDq/2hfirfNPJwoZ42u6KxtNm8DIXgpmXrxNWh38sTNmPn0TRliGB3W1lIP3U ETLqObVdOb2kzkVH80QKw9V+Fj9gvNDGXnl9zlhgKQw47A46J1FFijEOfiLJnDQrlL7yQPQKvdb cDrXUcUAfFLuuU/aPwCkbwqhEP9WYD7cyzaGfzlL7gwUJ37UuJL/t8E0KwN0JwXTnaOQriP5ZjT lJLaqhh6FsOCOwCvg6O0JCu1mhyeo8v43dmXyp4jBynnsF76Ld+rNc9IqsWzcW6nEmb1A6gmRc+ BwxWR6xp2m8GdZJFLESSMsuowESnvjkZ5IUnXGZq/gLZaeTOJ/1Wcnl83RvJhUOqaZ7yvTUT6lf LvUBmvXci3rgE9c8MZPvvTkhnmagM3gnxxk1IPRyzYropcRPRYsHgY1Xi8btuFsJRjuDrfRIwKJ qz9XkSigMAITQmOwMFpYQ= X-Received: by 2002:a05:6402:1906:b0:698:b60b:aac2 with SMTP id 4fb4d7f45d1cf-69ab4453d30mr1054344a12.4.1783515292855; Wed, 08 Jul 2026 05:54:52 -0700 (PDT) Received: from draszik.lan ([212.129.81.171]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69aa613d4e2sm2000319a12.24.2026.07.08.05.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 05:54:52 -0700 (PDT) Message-ID: <4a5a09fd68fe45939bdcec4a3c5a781d664eb34c.camel@linaro.org> Subject: Re: [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= "(The Capable Hub)" Cc: Lee Jones , Michael Hennerich , Chen-Yu Tsai , Marek Vasut , James Ogletree , Fred Treven , Ben Bright , Support Opensource , Andy Shevchenko , Charles Keepax , Richard Fitzgerald , Chanwoo Choi , Krzysztof Kozlowski , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Andreas Werner , Samuel Kayode , Maxime Coquelin , Alexandre Torgue , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org, linux-omap@vger.kernel.org, imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Date: Wed, 08 Jul 2026 13:55:06 +0100 In-Reply-To: <5aec0fc2ac0cd1d2e27027ad0c180e2647bd494e.1783507945.git.u.kleine-koenig@baylibre.com> References: <5aec0fc2ac0cd1d2e27027ad0c180e2647bd494e.1783507945.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8+build1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-07-08 at 13:15 +0200, Uwe Kleine-K=C3=B6nig (The Capable Hub) = wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. >=20 > The mentioned robustness is relevant for a planned change to struct > i2c_device_id that replaces .driver_data by an anonymous union. >=20 > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) > --- > =C2=A0drivers/mfd/max77759.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 2 +- Reviewed-by: Andr=C3=A9 Draszik # for Maxim MAX7= 7759