From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Pasha Tatashin <pasha.tatashin@oracle.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: <linux@armlinux.org.uk>, <schwidefsky@de.ibm.com>,
<heiko.carstens@de.ibm.com>, <john.stultz@linaro.org>,
<sboyd@codeaurora.org>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
<tglx@linutronix.de>, <hpa@zytor.com>
Subject: Re: [PATCH v6 1/4] sched/clock: interface to allow timestamps early in boot
Date: Wed, 27 Sep 2017 21:52:36 +0800 [thread overview]
Message-ID: <4a62156c-ea0f-749f-e21b-37919dfda1df@cn.fujitsu.com> (raw)
In-Reply-To: <aed54345-b752-e93a-8be7-96df9b083f6c@oracle.com>
Hi Pasha, Peter
At 09/27/2017 09:16 PM, Pasha Tatashin wrote:
> Hi Peter,
>
> I am totally happy with removing notsc. This certainly simplifies the
> sched_clock code. Are there any issues with removing existing kernel
> parameters that I should be aware of?
>
We do not want to do that. Because, we use "notsc" to support Dynamic
Reconfiguration[1].
AFAIK, this feature enables hot-add system board which contains CPUs
and memories. But the CPUs in different board may have different TSCs
which are not consistent with the TSC from the existing CPUs. If we
hot-add a board directly, the machine may happen the inconsistency of
TSC.
We make our effort to specify the same TSC value as existing one through
hardware and firmware, but it is hard. So we recommend to specify
"notsc" option in command line for users who want to use Dynamic
Reconfiguration.
[1]
http://www.fujitsu.com/global/products/computing/servers/mission-critical/primequest/technology/availability/dynamic-reconfiguration.html
Thanks,
dou
> Thank you,
> Pasha
>
> On 09/27/2017 09:10 AM, Peter Zijlstra wrote:
>> On Wed, Sep 27, 2017 at 02:58:57PM +0200, Peter Zijlstra wrote:
>>> (we're violating "notsc" in any case and really should kill that
>>> option).
>>
>> Something like so; in particular simple_udelay_calibrate() will issue
>> RDTSC _way_ early, so there is absolutely no point in then pretending we
>> can't use RDTSC for sched_clock.
>>
>
>
>
next prev parent reply other threads:[~2017-09-27 13:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 18:03 [PATCH v6 0/4] Early boot time stamps for x86 Pavel Tatashin
2017-08-30 18:03 ` [PATCH v6 1/4] sched/clock: interface to allow timestamps early in boot Pavel Tatashin
2017-09-27 12:58 ` Peter Zijlstra
2017-09-27 13:10 ` Peter Zijlstra
2017-09-27 13:16 ` Pasha Tatashin
2017-09-27 13:52 ` Dou Liyang [this message]
2017-09-27 17:13 ` Pasha Tatashin
2017-09-27 18:05 ` Peter Zijlstra
2017-09-27 18:09 ` Peter Zijlstra
2017-09-28 10:03 ` Dou Liyang
2017-09-28 11:58 ` Peter Zijlstra
2017-09-28 12:12 ` Thomas Gleixner
2017-09-28 13:11 ` Pasha Tatashin
2017-09-29 15:00 ` Dou Liyang
2017-10-18 10:01 ` Dou Liyang
2017-10-18 13:38 ` Pavel Tatashin
2017-10-09 16:34 ` Pavel Tatashin
2017-10-18 21:01 ` Thomas Gleixner
2017-09-27 14:45 ` Russell King - ARM Linux
2017-09-27 17:10 ` Pasha Tatashin
2017-09-27 18:11 ` Peter Zijlstra
2017-08-30 18:03 ` [PATCH v6 2/4] time: sync read_boot_clock64() with persistent clock Pavel Tatashin
2017-08-30 18:03 ` [PATCH v6 3/4] x86/time: read_boot_clock64() implementation Pavel Tatashin
2017-08-30 18:03 ` [PATCH v6 4/4] x86/tsc: use tsc early Pavel Tatashin
[not found] ` <CALBSrqBKsojGGpe85GOg7jda-SJHLrR=pS-Pg-xa0SUg7j3OQA@mail.gmail.com>
2017-08-30 21:21 ` Fenghua Yu
2017-08-30 21:32 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a62156c-ea0f-749f-e21b-37919dfda1df@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=sboyd@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome