From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C51C43219 for ; Mon, 23 May 2022 15:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237870AbiEWPZG (ORCPT ); Mon, 23 May 2022 11:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237797AbiEWPZD (ORCPT ); Mon, 23 May 2022 11:25:03 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C85D85DBE4 for ; Mon, 23 May 2022 08:25:00 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id r3so10760041ljd.7 for ; Mon, 23 May 2022 08:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=2w+Ay74cy7OoOg37g3PaLjsP1sHLBt98ivncMEHUTZE=; b=orFcSTvpnjF2Ul0w/eFhjws6UEFRdIdVSVYukzC2tF+nVYSnHFaaxmflPfpw8qz8qF ik6PDz0cc8Oj7SbKnxObem78aoMCd+xjnQdgKZpY6s9du2FQPRFqXEjMx84zUfHaUSK5 +5aDtV1uK8iokGkuUohuvW0L7k1LR2OiZl2HdjndCXqss8DzPENH45G9Pn+m8EbPTZWj s+yQdMDgWjXD29XD7VpFK84XPEWt40wdVzAc/6a6ogfXkT3SjLENjQgnwyFLEMwVUB+D l6dZ/senYVrTWPdoKxCU+dfRc+i8YOVwhR0C5kGIt9sZB5w8tkbzjEogHF6UqQKtnniS cVUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=2w+Ay74cy7OoOg37g3PaLjsP1sHLBt98ivncMEHUTZE=; b=YcwSIC00R2xeMQwBroyvFUBe6z6uZYhx2WnLUZ/tkdf1X8qYncTcDX/6i8hCBzQDly i+ergkp9QzyqTZ+2VjafpJ8hhWvqNcCD1CxM+BmGnQ9ttfv5Vujkockt/vXjX43BSiO8 rarOzrH1geJ63yTiWwVEpu4La9q3egVAIJNpETgY/lz4+rZVQG5LdiQzVmLeRzDDCPKF hswMShYArFAvOgc3cfU8r+qjsCmlmwbAPM01dca61aJwgRJRRNZUEwclLvfJD9G/FLox SlHd39mRelsFWtO1NoQgIjFRcenGD8BQcv/veWVSZ4vBUw/DX1x9C7djDEpdeZ9Kghw7 M0Ig== X-Gm-Message-State: AOAM532E/DDgguZ9JbsOE1OnDH2mQpkq+FA6+ZtoMAWlSLU19KvGT+1X pADjgKrUJpwiGmdg7phWkZp0EQ== X-Google-Smtp-Source: ABdhPJwQ7LooGvEvT4dpWheOhDWqxQVg6IroKOSOYNqnIDRYboL3316+ca6IHfgol4Aq3EeOYOdhag== X-Received: by 2002:a2e:9c43:0:b0:250:a467:414 with SMTP id t3-20020a2e9c43000000b00250a4670414mr13242328ljj.358.1653319498852; Mon, 23 May 2022 08:24:58 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v4-20020a056512096400b0047255d2119bsm2026580lft.202.2022.05.23.08.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 08:24:58 -0700 (PDT) Message-ID: <4a69902f-a545-23a1-1430-e5ece16997e9@linaro.org> Date: Mon, 23 May 2022 17:24:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v1 11/19] dt-bindings: reset: npcm: Add support for NPCM8XX Content-Language: en-US From: Krzysztof Kozlowski To: Geert Uytterhoeven Cc: Tomer Maimon , Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , =?UTF-8?Q?Bj=c3=b6rn_Andersson?= , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , arm-soc , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , Linux Watchdog Mailing List , Linux ARM References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-12-tmaimon77@gmail.com> <86cd6a37-70ad-3a90-bc8a-dcd8b41f1175@linaro.org> <62562cdf-93e3-f642-5bbd-48329eff33ea@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/2022 17:22, Krzysztof Kozlowski wrote: >> I think you are taking a too-extremist standpoint. >> The two extremes are: >> 1. Numbers correspond to hardware numbers, and are easy to look up >> in the hardware documentation (e.g. GIC SPI interrupt numbers). >> => Use the hardcoded numbers in DTS. > > And such numbers (like GIC_SPI interrupt numbers) do not go to bindings. > They go to DTS only. > >> 2. Numbers do not correspond to hardware numbers, so we had to >> invent our own definitions and numbers, usually loosely >> based on some table in the hardware documentation. >> The driver will have to look up the numbers in a data >> structure, to know how to program the hardware. >> The numbers become part of the DT ABI, and cannot be changed >> (header file is append-only). >> => Use the binding definitions in DTS. > > Correct. > > However this patch is some mixture of both approaches. > > The same pointed by Arnd: > https://lore.kernel.org/linux-devicetree/CAK8P3a0fDJQvGLEtG0fxLkG08Fh9V7LEMPsx4AaS+2Ldo_xWxw@mail.gmail.com/ ...and one more from Arnd: https://lore.kernel.org/linux-devicetree/CAK8P3a1APzs74YTcZ=m43G3zrmwJZKcYSTvV5eDDQX-37UY7Tw@mail.gmail.com/ Best regards, Krzysztof