mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Daniil Dulov <d.dulov@aladdin.ru>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: Re: [PATCH] net: sfp: remove redundant NULL check
Date: Thu, 15 Feb 2024 18:32:06 +0100	[thread overview]
Message-ID: <4a7300f3-116a-4824-98c4-209a217a4a11@lunn.ch> (raw)
In-Reply-To: <Zc41kuP2iwK3AlWv@shell.armlinux.org.uk>

> However, I'll go back to my original point: this is *not* something
> that automated tools should be identifying, and it is *not* something
> that should be used to throw patches randomly out, especially where
> the commit message doesn't include human analysis details.

Hi Daniil

Could you work on SVACE and make it dump how it decided it was safe to
remove the NULL check. I assume it found the path via
sfp_register_socket(), and the NULL check in that. So it should be
able to dump that info in some form. sfp_bus_add_upstream() seems more
interesting and it would be interesting to know why it though a NULL
from there was impossible.

It would be great if the tool dumped some text which could be
cut/paste into the commit message as a justification for the change.

	Andrew

      reply	other threads:[~2024-02-15 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-11 15:08 Daniil Dulov
2024-02-13 12:43 ` Paolo Abeni
2024-02-14  1:26   ` Jakub Kicinski
2024-02-15 16:02 ` Russell King (Oracle)
2024-02-15 17:32   ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a7300f3-116a-4824-98c4-209a217a4a11@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=d.dulov@aladdin.ru \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lvc-project@linuxtesting.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®