From: Jens Axboe <axboe@fb.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Block fixes for 4.8-rc4
Date: Fri, 26 Aug 2016 22:42:01 -0600 [thread overview]
Message-ID: <4a76c468-f336-c0ed-75b8-2e600d786f86@fb.com> (raw)
In-Reply-To: <CA+55aFxk2EHr73xBgUz3D63yEkH4xmqJdk=XX=fYRNhLrWDNjg@mail.gmail.com>
On 08/26/2016 07:55 PM, Linus Torvalds wrote:
> On Fri, Aug 26, 2016 at 8:16 AM, Jens Axboe <axboe@fb.com> wrote:
>> Hi Linus,
>>
>> - Revert two previous floppy changes, since they caused a user visibile
>> regression. A better fix is in the works.
>
> Those reverts have no sign-off, and no explanation for them.
>
> No, a revert may not have any copyright value, but the sign-offs have
> been our main way to also see who actually did stuff and what the
> chain was. All the usual "who caused this" background for reverts.
>
> What was it that went wrong? Nobody knows. Not from the logs, at least.
You are right, those reverts should have the reasoning included.
> I pulled it, but just FYI: reverts need explanations too. They need to
> explain why they happened and what went wrong.
Thanks.
--
Jens Axboe
prev parent reply other threads:[~2016-08-27 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 15:16 Jens Axboe
2016-08-27 1:55 ` Linus Torvalds
2016-08-27 4:42 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a76c468-f336-c0ed-75b8-2e600d786f86@fb.com \
--to=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®