From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE2F51A9F83 for ; Mon, 29 Dec 2025 00:58:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766969885; cv=none; b=pntIhxXICepzkbljVfx52B4WkhO6pJbT4bwnI6+ja5xu6XKxa90WrSqmmmsO/Iaa8jmvWYYBs9nF1tykF+I0KLWaZDj1npdWF6q3cWIortI8AbJ2IL/FPeLA+3hQBdlDHslFKK9NwLBolUpUH/+Y2AN00P0RGQlj0epkICZfHTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766969885; c=relaxed/simple; bh=eXOy10oeUU64eQXYQ70XYcx1sMmIGm1IbQQLP4gGXVI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WqFivNcpOOADe7oG/TXr9+V4CgB6gDtryvPBW9YtePUyHL1LvewVF1LCrSIuOgfk3CZJWMpw40eC9otDiRLhHxKvsKxMgK/vKSQHSO6QL/Pwh3I7EuwPdmG4lEjDkuLj5Y4V4ZhONFQDHozf0PC7OeOdrGoJLFOhy86YfiDMlbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=ub5VsRSm; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="ub5VsRSm" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8b5c81bd953so1049112485a.1 for ; Sun, 28 Dec 2025 16:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1766969883; x=1767574683; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=udz/Ywp00lT4GZoeinIo9QMm0ZTiY0IiwK5PiD3CPXA=; b=ub5VsRSmVVLT+648b52IithkBBQvshYp3zNWt4nDIbL2M+pFXtnlhBTSFgcdWWS9pk N9I8ZCwgonrxA93vJ2oV61ftjZruSfPs8nhc/fgL2hbpcBqoxXoi+zrBYM1wIFKH026Y 9ogzxvZ10Dybab+ZBhY15zfn25xiKCbJp/7Txnyippx1HZpHdVMy1c31DkNzEHCgczxq oC8LSu/fy1gCbNMQxWZQ48BQLkLdu4nGZziCjbbZ8H3U2lViglRNhjUkNrb2zfukYP53 yOXkrLcnbgVt1q+mX5ti4l8TQeFNKt+eQC2FhQoje9+N5B8vSQC0fgB92DN0EPJsuy32 fK+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766969883; x=1767574683; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=udz/Ywp00lT4GZoeinIo9QMm0ZTiY0IiwK5PiD3CPXA=; b=c5qrWR5HhSKLGPvPkyeI+Kos7T1xqkHXseCIJflgsTPFHaolV+CDHMHNzpSeQtTj0b Im73PxH2zdhOjMd8eHdHk7OrLeCCUBSXE9d1WV3j6tMS2M7czWRicoAkXqpHx5tqEefa a02Lr84Nq40R/uF6y4BiBHHY/bUBhnFr2pyGEcb1QLW0dqYmK8GrxJ1zINxZkQmCp7p8 DDgJJdXNuHNwIiZWik2faNYnv0Gu3JEGeYeFXLcTCyNeI9wXlsnotIneAd2BQQ/9Gg7D xTZjPlTEXW3uoHtXDIZlx1+vd5Zivdl2WrQp0jtLePZ5OLIIQ4Wb27+j7qtg4M8jUUTC 0Qyw== X-Gm-Message-State: AOJu0Yzp+T8xU+6KH/6THKQV/q0Vx6wPpj2MXU105tm/nabwJGTrBltt RRtaUAItWDjyCH+bJXoji6epUz+X+AzNBou+2unRzI0ZhGVTQ2DV/AcPGzbScnmbr5I= X-Gm-Gg: AY/fxX4Y427tBWwks+YjgNm9IZmZ/bp///KwvL2FcVaxUmxvRCuPZ0g3fSUEDDROhmP rip+twZIYFuUhrXxSm4tjBc/bJYVniIx2PZSTIGYoxD3qm0wQyo/n7OX8UC1P9NGVwISaAypWwF ESSIo/Y5tYleKUz745tPkBWrFW7VQoILB5Tqg59/28jt5C0EoZ4GQ7onK/p+3lzoIkLnxLCOt/I U8R4Sx8MWmfQaxFZev5NWdHv+V2q66C2bjwaeH1vsAtEhvm+xDjvzYu4LKyJXzCzZyaoyfF7hBs 15cWfBHpf3c2DpLWdXS8wxNkQw18i7qAOAynzda3bF/OWVezPEDuuRw5HKMJRus9biHxSnGSVPp /ia/afPN0sDRFfLXx1TEo/8vSlm6rsNrVS+5S0n6DuTsHcR8bUxqbjiwY4kUiTuRRitmpSfp3sT ZszBWrAbfZ6fkNR7r9feCHpgu+GtfQ9GJs4e7m/Ei9MyE9TdeGbIQ= X-Google-Smtp-Source: AGHT+IHrk3/Wb1Ax/7CDf4gB7goVnIoiHZHZswEwc447eGOnME6q7KBjOR0207MAY/FczYBzti0BEg== X-Received: by 2002:a05:620a:4706:b0:8b2:ec00:7840 with SMTP id af79cd13be357-8c08fbde57cmr4105632385a.27.1766969882882; Sun, 28 Dec 2025 16:58:02 -0800 (PST) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c09689246asm2268104285a.20.2025.12.28.16.58.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Dec 2025 16:58:02 -0800 (PST) Message-ID: <4a76e9bf-926e-4b77-a2f8-ee4a72b2f1dd@riscstar.com> Date: Sun, 28 Dec 2025 18:58:00 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] i2c: spacemit: configure ILCR for accurate SCL frequency To: Troy Mitchell , Lee Jones , Yixun Lan , Andi Shyti , Alexandre Belloni , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org References: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> <20251118-p1-kconfig-fix-v3-1-8839c5ac5db3@linux.spacemit.com> <81eca0ab-47a3-4b12-98ae-fbd46a15ff93@riscstar.com> <569E6DA87DE510D5+aU4-1Jl9XxjAWQq4@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <569E6DA87DE510D5+aU4-1Jl9XxjAWQq4@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/26/25 1:52 AM, Troy Mitchell wrote: >>>> +static int spacemit_i2c_clk_set_rate(struct clk_hw *hw, unsigned long rate, >>>> + unsigned long parent_rate) >>>> +{ >>>> + struct spacemit_i2c_dev *i2c = container_of(hw, struct spacemit_i2c_dev, scl_clk_hw); >>>> + u32 lv, lcr, mask, shift, max_lv; >>>> + >>>> + lv = DIV_ROUND_UP(parent_rate, rate); >>> >>> Would DIV_ROUND_CLOSEST() give a more accurate value? >> I'll test it. > Same result. So I'll keep it. Is that true for all clock rates? Anyway, it's not a huge deal, but especially when the number of rates isn't very high this can make a difference. -Alex > - Troy