From: Ivan Mironov <mironov.ivan@gmail.com>
To: Sudarsana Reddy Kalluru <skalluru@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Ariel Elior <ariel.elior@cavium.com>,
Sudarsana Kalluru <sudarsana.kalluru@cavium.com>,
"everest-linux-l2@cavium.com" <everest-linux-l2@cavium.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [PATCH v1] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw
Date: Mon, 24 Dec 2018 20:16:38 +0500 [thread overview]
Message-ID: <4a78261cba6647cd9665ed42f175eeedf412b85b.camel@gmail.com> (raw)
In-Reply-To: <CY4PR18MB125333EFFE5875193E66927FD3BB0@CY4PR18MB1253.namprd18.prod.outlook.com>
On Mon, 2018-12-24 at 14:26 +0000, Sudarsana Reddy Kalluru wrote:
> Thanks a lot for root-causing the issue and the patch.
> Another (simpler) way to address this would be to invoke bnx2x_del_all_vlans() only for the newer chips, e.g.,
> + if (!CHIP_IS_E1(bp)) {
> /* Remove all currently configured VLANs */
> rc = bnx2x_del_all_vlans(bp);
> if (rc < 0)
> BNX2X_ERR("Failed to delete all VLANs\n");
> + }
> Could you please check on this?
Done. See the PATCH v2 in the mailing list. I tested it on my system.
prev parent reply other threads:[~2018-12-24 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 11:56 Ivan Mironov
2018-12-24 14:26 ` [EXT] " Sudarsana Reddy Kalluru
2018-12-24 15:16 ` Ivan Mironov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a78261cba6647cd9665ed42f175eeedf412b85b.camel@gmail.com \
--to=mironov.ivan@gmail.com \
--cc=ariel.elior@cavium.com \
--cc=davem@davemloft.net \
--cc=everest-linux-l2@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
--cc=sudarsana.kalluru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®