From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4CC542C518 for ; Wed, 19 Aug 2026 09:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787132934; cv=none; b=q1z4NNQeSxfAxyiccd3CJ762UIkN80zmr7n1DoLaImqKqIsdnk6jMloq+6LCH94JhTP9fjBocguoGdD/jvMU1ycrqUmJFXGlH3blpkba6Ngxyz+Dvqzxe1dHVdnPHqtgaIxzLEsVtMf/fvjtIQ2zTjjCVO1+/ae425HtSaddLgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787132934; c=relaxed/simple; bh=uQioOmaJVlJ2kqIbJb4zaXYWx9XtY7h0lBUVlxk8Fn0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DFJ5O3sB6DAqiw0OWfJuHEMlDM2IWcGb9JbMrhJNfZAM7t8+jVnaewqioqyaxS+sho+9lUohtOFqMQbQlhzvdic6athT4FcYyzmApHh0GdVO3qUSKTUNREPSJfxzk+lZPn1+yYgBoK+VPhC24NgLS8yNIf0i5MI3MGie61vPwcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ojg8774Y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QNBTBj1A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ojg8774Y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QNBTBj1A" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67J6ZDhF3171919 for ; Wed, 19 Aug 2026 09:48:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M4PDAKpq3CcCOlxu5k9j1hSRxD72WCqmgxRmVTcYDN4=; b=ojg8774YigChGZiN eoLVmQ4Bk4BvlGc8bAEsWZb5IJkbajvEI0r/xgHj1VecouaT6Urdht2+M/pYdx8Q afkQApDyt8S1NFkQElfPy92Etj3aNXx69611EGYJ9IFwiyfFZZSeAxsNp15yEejZ 7TvqrBK0FYO94KjKT1qjwaHKI/NQ1nJ8uc4dzg5xAp1amGUuXlD+LxBPZpd79kKx WHAa1tYNg3bmlJp2GYukPIVlfEt32ZQEC5CUXFvZmqXSEYaHMKSGUfVsuxytdy8O CljVxFa/84B84kZ63+kydj1nKC+umU3rRRDjPXeaukqaAdf120gRWcViz5x/zLd2 2Vcnlg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfkjhtg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 09:48:52 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38dc085b0a7so1906908a91.2 for ; Wed, 19 Aug 2026 02:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787132931; x=1787737731; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M4PDAKpq3CcCOlxu5k9j1hSRxD72WCqmgxRmVTcYDN4=; b=QNBTBj1AwFghmBxTf4uqSqGM5Kx0E/AeaTwMyM9XE5mM01+udk6cIV6tHCPrrqiFxk 0H6iJIvfapwVyfHZ+fYeTRnAG36oMmuF492zhNIBqYqGJ9wiFUmg2i1yQpXRWbEyIosx M0J5mB/vmWj11F5ko07U/oomCRY4J3ILJw6gjIEjVZIqzzEz3k1qDVgfc7LtpRLyLtZC bo1+ptjKp3Vbp58hlZMufRQCDgQ6GpFV4yezGgAxw35bNknmkH4ZeRh5Q9wPKOy5oAhN LMS1U8dW9A4nSsysefxkF2WJK0KvZIHMZuFP84NGfxoORTOOUQrqpeR/Yv8psk7cN+rM 8HCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787132931; x=1787737731; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=M4PDAKpq3CcCOlxu5k9j1hSRxD72WCqmgxRmVTcYDN4=; b=tLC6o3qVQQKVfbA7Frt6Cxee/inJ8qQY0CVzaflp3fflUuXg35UDlIaQfw1Bez6FTG JkP6kCR/UFiY7KOxiJL/vdprEf79ylVM04b/gQLa5yKi4pJz/M4M6200lheNmuVYlhr3 zq+OT7DYD+/UIKQhBzWPLswSYbn0BgLtk/XCXv/cuD9Z53QlSrrIGl3+GVLkwo1JP3/x OF9k5ns3fQYjrZeCxFa9AJ5nnGzMD/aYRnCW6hoQcOaPoB5b3EioeKri5v86zU8CiA0C XHMjx7tRvTVemiiv/RJaCBFxEi5E78Bsr9MG7Wsv91j41HiedViu72cHY7OYSrN/ArIY FJTg== X-Forwarded-Encrypted: i=1; AHgh+RpI3i/LTo2UsCTphboLTOCl4JZvl/qSoOK6is0hLrZK7+1uR51wpEZKkN5OdKpA1DclfyeZFlntN1mJcgk=@vger.kernel.org X-Gm-Message-State: AFuF++mjWlk6vEXXIgGIQSA7aOhYs7pC2sofjjnI6munx0y69Ed7DfNc oY8FjSBCxi8RfHJVhpTYIMTI9G43mVXD2SOXcohrjIahGEmfmf0QfHbitek+GinNImTryD/GQED 2a7tybmp3U89meSTalRDav7GtBMu3lIGe0wnd93TA2IpfkJc2Epi83UEB+t0ghY4i/cE= X-Gm-Gg: AR+sD10zkgt/C5Fjr3NFOpsL5v9Ye9as0enl9z8I5PxMIiYS/rQW0lCCyA3er2rEqSo v8AvXuheDNTNA+QSuJ3fuCGlgyhXVXamEKYr0ixRC2UxyWaFNGoZLj658v76C++7qI5WJ5xYOrS 2T1xhAX/IEUADRc5GbWUnIOrV5WH9VHIZZfGgplgoFZCXOoP3evSvihMvmGOo/X9CjCOSRgWMyi fedhPUi0vQRKbCE0pr4GFKe+JzYPZtgJXYODr1qArg2wGOqW+2z+oJE1M6JbziQ2wECu5PUXgEH 610t9dMHoR7ZAO1IAZF5Np9D5iS2lVZBubA2oVoMBzjyLG13IlaIMmlGX5sxpg6Yt4d+pA5dec5 mIHlxDCwKGZvYcHi6CobeWtPnXuUI7g== X-Received: by 2002:a17:90b:5250:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-3958125375amr6886833a91.14.1787132931094; Wed, 19 Aug 2026 02:48:51 -0700 (PDT) X-Received: by 2002:a17:90b:5250:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-3958125375amr6886753a91.14.1787132930634; Wed, 19 Aug 2026 02:48:50 -0700 (PDT) Received: from [10.217.216.255] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957faf6849sm2001049a91.10.2026.08.19.02.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 02:48:50 -0700 (PDT) Message-ID: <4a81f4ce-7b74-45b9-b3bf-942bbe625e4c@oss.qualcomm.com> Date: Wed, 19 Aug 2026 15:18:46 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] bus: mhi: ep: clients: Add loopback driver for data path testing To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Manivannan Sadhasivam , Jeff Hugo , mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Chaitanya Chundru References: <20260817-loopback_mhi-v5-0-50efc7360b7f@oss.qualcomm.com> <20260817-loopback_mhi-v5-3-50efc7360b7f@oss.qualcomm.com> Content-Language: en-US From: Sumit Kumar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=NoPhtcdJ c=1 sm=1 tr=0 ts=6a857c04 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=66wo3ehNeEoRUVuG-WUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: GMUU7ECpWHTF6iJksaaAOF2b9NiRzSOm X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDA3NCBTYWx0ZWRfX6AtwXQX0x70L Isk72KieGpy/YGddPhWgj1urOtkfKHu5dZimcv+OPFpETxivLlgCgP4BgeswAC+yFdfhRY4lEQK euufoRdZaYncgaGLuKmErurTyk6wGdQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDA3NCBTYWx0ZWRfXzXsSA1yvyRmg 6F3yWB6oYj4e/hIq1wKKTez6IL5HnT4i/C/MTjSB+PWZQuXTUs64pf5Vr+rizZn5dS3Gl8VUm5V 1rSBYOT8GuHDF4FgeTY/b9Xp2JK6YNAfiIxYfUvXXMVhqwho16+M9XLs89AJzhsrqqRYw75chV0 xe2H1eMoYEXfeFz0lnzLVsx2a+PoxNFpoY0shskmoLDCrNpXPtfHLGBadeLna1rtlluLWK9TT5t 0J+YtNBKouZklQH4GyC2G/ufjq6W6D5sbrRLpTxZBLJlNkwK9yRabXVofzBkXa2RI55o+hpWNN4 zrma7e9qHNbk+77ia+fESWqe4GafLkIorFTZqoLgPT9mh7sHt8k8KBJIINj7K1aAmrm3oKWeVE3 uDlPH3x6cnaZR4QXP5Qa32m9tI5PKhZsEY1CLB2x/4rq0wZyASAFQUZYbGF3PUUbq8a2Kvgt1at vEQrWSxbEhRL99BdsvA== X-Proofpoint-GUID: GMUU7ECpWHTF6iJksaaAOF2b9NiRzSOm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190074 On 8/18/2026 2:23 PM, Uwe Kleine-König wrote: > Hello, > > On Mon, Aug 17, 2026 at 03:44:36PM +0530, Sumit Kumar wrote: >> diff --git a/drivers/bus/mhi/ep/clients/loopback.c b/drivers/bus/mhi/ep/clients/loopback.c >> new file mode 100644 >> index 0000000000000000000000000000000000000000..18a92d6a40e0f7de277d155cdb5495d14a60c19d >> --- /dev/null >> +++ b/drivers/bus/mhi/ep/clients/loopback.c >> @@ -0,0 +1,130 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#include >> +#include > Similar as with my feedback for patch #1, please don't use > . Either rely on -> > -> , or explicitly include one of > the these headers but not . Will fix it after rebase in v6. > >> +#include >> +#include >> + >> [...] >> +static const struct mhi_device_id mhi_ep_loopback_id_table[] = { >> + { .chan = "LOOPBACK"}, >> + {} > Again, please add spaces before the closing }. sure. > >> +}; >> +MODULE_DEVICE_TABLE(mhi, mhi_ep_loopback_id_table); > Best regards > Uwe