mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pragnesh Papaniya <pragnesh.papaniya@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, sibi.sankar@oss.qualcomm.com,
	pankaj.patil@oss.qualcomm.com, rajendra.nayak@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: glymur: Add glymur BWMONs
Date: Thu, 19 Mar 2026 22:18:14 +0530	[thread overview]
Message-ID: <4a839c38-1534-4e57-852e-452876b521c1@oss.qualcomm.com> (raw)
In-Reply-To: <2d6d813b-b2e7-408c-bf58-86d25859bb40@oss.qualcomm.com>



On 3/3/2026 5:52 PM, Pragnesh Papaniya wrote:
> 
> 
> On 3/2/2026 6:27 PM, Konrad Dybcio wrote:
>> On 3/2/26 12:46 PM, Pragnesh Papaniya wrote:
>>> Add the CPU BWMON nodes for glymur SoCs.
>>>
>>> Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>>> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>>> Signed-off-by: Pragnesh Papaniya <pragnesh.papaniya@oss.qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/glymur.dtsi | 87 ++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 87 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
>>> index e269cec7942c..fd947b1a17dd 100644
>>> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
>>> @@ -2264,6 +2264,93 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ALWAYS>,
>>>  			};
>>>  		};
>>>  
>>> +		/* cluster0 */
>>> +		bwmon_cluster0: pmu@100c400 {
>>> +			compatible = "qcom,glymur-cpu-bwmon", "qcom,sdm845-bwmon";
>>> +			reg = <0x0 0x0100c400 0x0 0x600>;
>>> +
>>> +			interrupts = <GIC_SPI 903 IRQ_TYPE_LEVEL_HIGH>;
>>> +
>>> +			interconnects = <&hsc_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
>>> +					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>;
>>> +
>>> +			operating-points-v2 = <&cpu_bwmon_opp_table>;
>>> +
>>> +			cpu_bwmon_opp_table: opp-table {
>>> +				compatible = "operating-points-v2";
>>> +
>>> +				opp-0 {
>>> +					opp-peak-kBps = <800000>;
>>> +				};
>>
>> Can these values remain unchanged vs hamoa? Glymur has more memory
>> channels (as reflected in the icc driver) so the values send to rpmh
>> will be a third lower
>>
>> Similarly, hamoa has roughly the same values as kona, which has half
>> the channels
>>
>> Konrad
> opp-peak-kBps is proportional to bus_width and is calculated as follows:
>  
> opp-peak-kBps = (Hz * node_bus_width)/ 1000
>  
> All the existing targets do the same, since bcm_aggregate() in 
> bcm-voter.c divides max_peak with buswidth.
> 
> -Pragnesh
Ping

-Pragnesh

  reply	other threads:[~2026-03-19 16:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 11:46 Pragnesh Papaniya
2026-03-02 12:57 ` Konrad Dybcio
2026-03-03 12:22   ` Pragnesh Papaniya
2026-03-19 16:48     ` Pragnesh Papaniya [this message]
2026-03-23 14:21     ` Bjorn Andersson
2026-03-23 14:49       ` Konrad Dybcio
2026-03-23 14:38 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a839c38-1534-4e57-852e-452876b521c1@oss.qualcomm.com \
    --to=pragnesh.papaniya@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pankaj.patil@oss.qualcomm.com \
    --cc=rajendra.nayak@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®